From 7cca2c7fb328e64f1779993b60809eff6974b970 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 16 Nov 2016 08:59:52 +0200 Subject: new loplugin finalprotected look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- xmloff/inc/txtflde.hxx | 3 +-- xmloff/source/forms/formattributes.hxx | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) (limited to 'xmloff') diff --git a/xmloff/inc/txtflde.hxx b/xmloff/inc/txtflde.hxx index ba65fd435eff..61090c788738 100644 --- a/xmloff/inc/txtflde.hxx +++ b/xmloff/inc/txtflde.hxx @@ -210,7 +210,7 @@ public: enum ::xmloff::token::XMLTokenEnum MapAuthorFieldName(const css::uno::Reference< css::beans::XPropertySet > & xPropSet); enum ::xmloff::token::XMLTokenEnum MapSenderFieldName(const css::uno::Reference< css::beans::XPropertySet > & xPropSet); -protected: +private: SvXMLExport& GetExport() { return rExport; } @@ -407,7 +407,6 @@ protected: static OUString MakeSequenceRefName(sal_Int16 nSeqNo, const OUString& rSeqName); -private: // constants // service names diff --git a/xmloff/source/forms/formattributes.hxx b/xmloff/source/forms/formattributes.hxx index 5bed7db46f17..7167c1f82ccc 100644 --- a/xmloff/source/forms/formattributes.hxx +++ b/xmloff/source/forms/formattributes.hxx @@ -289,7 +289,7 @@ namespace xmloff AttributeAssignment() : pEnumMap(nullptr), bInverseSemantics(false) { } }; - protected: + private: typedef std::map AttributeAssignments; AttributeAssignments m_aKnownProperties; @@ -381,7 +381,7 @@ namespace xmloff const sal_uInt16 _nAttributeDefault, const SvXMLEnumMapEntry* _pValueMap, const css::uno::Type* _pType = nullptr); - protected: + private: /// some common code for the various add*Property methods AttributeAssignment& implAdd( const sal_Char* _pAttributeName, const OUString& _rPropertyName, -- cgit