From 81a3e3416dab99c11f7bfa61d1a859edbacbcacf Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Mon, 25 Nov 2019 16:52:49 +0100 Subject: Remove some redundantly user-declared copy ctors and assignment ops ...that trigger -Werror,-Wdeprecated-copy ("definition of implicit copy {constructor, assignment operator} for ... is deprecated beause it has a user-declared copy {assignment operator, constructor}") new in recent Clang 10 trunk (and which apparently warns about more cases then its GCC counterpart, for which we already adapted the code in the past, see e.g. the various "-Werror=deprecated-copy (GCC trunk towards GCC 9)" commits) Change-Id: Ie37bd820e6c0c05c74e1a862bb1d4ead5fb7cc9c Reviewed-on: https://gerrit.libreoffice.org/83698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93694 Reviewed-by: Miklos Vajna --- xmloff/source/core/attrlist.cxx | 6 ------ xmloff/source/style/xmlprmap.cxx | 17 ----------------- 2 files changed, 23 deletions(-) (limited to 'xmloff') diff --git a/xmloff/source/core/attrlist.cxx b/xmloff/source/core/attrlist.cxx index 805cafdd45b6..5db3e8c27b18 100644 --- a/xmloff/source/core/attrlist.cxx +++ b/xmloff/source/core/attrlist.cxx @@ -38,12 +38,6 @@ struct SvXMLTagAttribute_Impl { } - SvXMLTagAttribute_Impl( const SvXMLTagAttribute_Impl& r ) : - sName(r.sName), - sValue(r.sValue) - { - } - OUString sName; OUString sValue; }; diff --git a/xmloff/source/style/xmlprmap.cxx b/xmloff/source/style/xmlprmap.cxx index ff55ebd3b7a5..bad5361c1408 100644 --- a/xmloff/source/style/xmlprmap.cxx +++ b/xmloff/source/style/xmlprmap.cxx @@ -63,9 +63,6 @@ struct XMLPropertySetMapperEntry_Impl const XMLPropertyMapEntry& rMapEntry, const rtl::Reference< XMLPropertyHandlerFactory >& rFactory ); - XMLPropertySetMapperEntry_Impl( - const XMLPropertySetMapperEntry_Impl& rEntry ); - sal_uInt32 GetPropType() const { return nType & XML_TYPE_PROP_MASK; } }; @@ -85,20 +82,6 @@ XMLPropertySetMapperEntry_Impl::XMLPropertySetMapperEntry_Impl( assert(pHdl); } -XMLPropertySetMapperEntry_Impl::XMLPropertySetMapperEntry_Impl( - const XMLPropertySetMapperEntry_Impl& rEntry ) : - sXMLAttributeName( rEntry.sXMLAttributeName), - sAPIPropertyName( rEntry.sAPIPropertyName), - nType( rEntry.nType), - nXMLNameSpace( rEntry.nXMLNameSpace), - nContextId( rEntry.nContextId), - nEarliestODFVersionForExport( rEntry.nEarliestODFVersionForExport ), - bImportOnly( rEntry.bImportOnly), - pHdl( rEntry.pHdl) -{ - assert(pHdl); -} - struct XMLPropertySetMapper::Impl { std::vector maMapEntries; -- cgit