From b2318479c8635af8e022ff4f844e85a1f6b9f4de Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Sat, 29 Oct 2016 09:50:28 +0300 Subject: Work in progress on supporting XAdES-compliant signatures for ODF xmlsecurity is such a mess. Too many different classes that actually have more or less identical life-time, with names that smell of delusions of grandeur. "Manager", "security framework controller" etc for stuff that actually exist only during the execution of a simple dialog. And then a "helper" class that actually in on a higher level than a "framework controller". But oh well. Change-Id: I86e461b1bc91a0d8f5b7fb9f13a5be201729df1e --- xmlsecurity/source/component/documentdigitalsignatures.cxx | 4 ++++ xmlsecurity/source/component/documentdigitalsignatures.hxx | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) (limited to 'xmlsecurity/source/component') diff --git a/xmlsecurity/source/component/documentdigitalsignatures.cxx b/xmlsecurity/source/component/documentdigitalsignatures.cxx index 08da227b3ebd..4320a88dc59e 100644 --- a/xmlsecurity/source/component/documentdigitalsignatures.cxx +++ b/xmlsecurity/source/component/documentdigitalsignatures.cxx @@ -57,6 +57,10 @@ DocumentDigitalSignatures::DocumentDigitalSignatures( const Reference< XComponen { } +DocumentDigitalSignatures::~DocumentDigitalSignatures() +{ +} + void DocumentDigitalSignatures::initialize( const Sequence< Any >& aArguments) throw (css::uno::Exception, css::uno::RuntimeException, std::exception) { diff --git a/xmlsecurity/source/component/documentdigitalsignatures.hxx b/xmlsecurity/source/component/documentdigitalsignatures.hxx index bd07304ed20c..8f6515c9d570 100644 --- a/xmlsecurity/source/component/documentdigitalsignatures.hxx +++ b/xmlsecurity/source/component/documentdigitalsignatures.hxx @@ -45,7 +45,9 @@ class DocumentDigitalSignatures : public cppu::WeakImplHelper { private: css::uno::Reference< css::uno::XComponentContext > mxCtx; - // will be set by XInitialization. If not we assume true. false means an earlier version. + // will be set by XInitialization. If not we assume true. false means an earlier version (whatever that means, + // this is a string, not a boolean). + // Note that the code talks about "ODF version" even if this class is also used to sign OOXML. OUString m_sODFVersion; //The number of arguments which were passed in XInitialization::initialize int m_nArgumentsCount; @@ -58,6 +60,7 @@ private: public: explicit DocumentDigitalSignatures( const css::uno::Reference< css::uno::XComponentContext>& rxCtx ); + virtual ~DocumentDigitalSignatures() override; // for service registration... static OUString GetImplementationName() throw (css::uno::RuntimeException); -- cgit