From 21de55596c0fdc2be736c6d0369bd9d3783020be Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 28 Nov 2018 15:13:42 +0200 Subject: remove unnecessary "if (!empty()" checks before loops found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin --- xmlsecurity/source/framework/saxeventkeeperimpl.cxx | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'xmlsecurity/source/framework/saxeventkeeperimpl.cxx') diff --git a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx index 21d1ccc4bd2d..5358230f7a46 100644 --- a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx +++ b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx @@ -169,15 +169,11 @@ BufferNode* SAXEventKeeperImpl::addNewElementMarkBuffers() m_pNewBlocker = nullptr; } - if (!m_vNewElementCollectors.empty()) + for( const auto& i : m_vNewElementCollectors ) { - for( const auto& i : m_vNewElementCollectors ) - { - pBufferNode->addElementCollector(i); - } - - m_vNewElementCollectors.clear(); + pBufferNode->addElementCollector(i); } + m_vNewElementCollectors.clear(); } return pBufferNode; -- cgit