From 4386863e1a5b3aebaded5ff66e4bd29ca7ce67d0 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel@peralex.com>
Date: Mon, 17 Mar 2014 09:18:44 +0200
Subject: xmlsecurity: prefer passing OUString by reference

Change-Id: I44b96a8adc2f6309088d99ff3bce438f660d302d
---
 xmlsecurity/source/helper/documentsignaturehelper.cxx | 4 ++--
 xmlsecurity/source/helper/xmlsignaturehelper.cxx      | 2 +-
 xmlsecurity/source/helper/xsecctl.hxx                 | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'xmlsecurity/source/helper')

diff --git a/xmlsecurity/source/helper/documentsignaturehelper.cxx b/xmlsecurity/source/helper/documentsignaturehelper.cxx
index 11f6c6e7f1e9..2ec4f030be80 100644
--- a/xmlsecurity/source/helper/documentsignaturehelper.cxx
+++ b/xmlsecurity/source/helper/documentsignaturehelper.cxx
@@ -76,7 +76,7 @@ int compareVersions(
 //then mimetype and all content of META-INF must be excluded.
 void ImplFillElementList(
     std::vector< OUString >& rList, const Reference < css::embed::XStorage >& rxStore,
-    const OUString rRootStorageName, const bool bRecursive,
+    const OUString& rRootStorageName, const bool bRecursive,
     const DocumentSignatureAlgorithm mode)
 {
     OUString aMetaInfName(  "META-INF"  );
@@ -185,7 +185,7 @@ DocumentSignatureHelper::getDocumentAlgorithm(
 std::vector< OUString >
 DocumentSignatureHelper::CreateElementList(
     const Reference < css::embed::XStorage >& rxStore,
-    const OUString /*rRootStorageName*/, DocumentSignatureMode eMode,
+    DocumentSignatureMode eMode,
     const DocumentSignatureAlgorithm mode)
 {
     std::vector< OUString > aElements;
diff --git a/xmlsecurity/source/helper/xmlsignaturehelper.cxx b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
index b5e2869b4031..e32721046306 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper.cxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
@@ -75,7 +75,7 @@ bool XMLSignatureHelper::Init()
 
 void XMLSignatureHelper::SetStorage(
     const Reference < css::embed::XStorage >& rxStorage,
-    OUString sODFVersion)
+    const OUString& sODFVersion)
 {
     DBG_ASSERT( !mxUriBinding.is(), "SetStorage - UriBinding already set!" );
     mxUriBinding = new UriBindingHelper( rxStorage );
diff --git a/xmlsecurity/source/helper/xsecctl.hxx b/xmlsecurity/source/helper/xsecctl.hxx
index 0b5469b57541..c45836e99aeb 100644
--- a/xmlsecurity/source/helper/xsecctl.hxx
+++ b/xmlsecurity/source/helper/xsecctl.hxx
@@ -131,7 +131,7 @@ public:
         xReferenceResolvedListener = xListener;
     }
 
-    void addReference( sal_Int32 type, OUString uri, sal_Int32 keeperId )
+    void addReference( sal_Int32 type, const OUString& uri, sal_Int32 keeperId )
     {
         signatureInfor.vSignatureReferenceInfors.push_back(
                 SignatureReferenceInformation(type, uri));
-- 
cgit