From 5708534b942c1d0ce384f6a8473da6bb569410e7 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 7 Jun 2018 13:03:58 +0200 Subject: look for unnecessary calls to Reference::is() after an UNO_QUERY_THROW Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins Reviewed-by: Tor Lillqvist Reviewed-by: Mike Kaganski --- xmlsecurity/qa/unit/signing/signing.cxx | 2 -- 1 file changed, 2 deletions(-) (limited to 'xmlsecurity') diff --git a/xmlsecurity/qa/unit/signing/signing.cxx b/xmlsecurity/qa/unit/signing/signing.cxx index 99f70172c27a..d899024f5b0e 100644 --- a/xmlsecurity/qa/unit/signing/signing.cxx +++ b/xmlsecurity/qa/unit/signing/signing.cxx @@ -656,7 +656,6 @@ void SigningTest::test96097Calc() uno::Reference xDocStorable(mxComponent, uno::UNO_QUERY_THROW); - CPPUNIT_ASSERT(xDocStorable.is()); // Save a copy utl::TempFile aTempFileSaveCopy; @@ -705,7 +704,6 @@ void SigningTest::test96097Doc() uno::Reference xDocStorable(mxComponent, uno::UNO_QUERY_THROW); - CPPUNIT_ASSERT(xDocStorable.is()); // Save a copy utl::TempFile aTempFileSaveCopy; -- cgit