From e125c6c6693d4540ab3aacb11151e05b511b8051 Mon Sep 17 00:00:00 2001 From: Michael Stahl Date: Tue, 28 Apr 2020 16:53:57 +0200 Subject: replace hard-coded "1.2" ODF version strings Most of these are calls to DocumentDigitalSignatures::createWithVersion(), where it doesn't make a difference if "1.2" or "1.3" is passed in but maybe it will be different with "1.4". There is another ctor createDefault() which looks appropriate for non-ODF contexts and can also be used when no actual signing or verifying is done. In cases where there's an actual document its Storage has the version. Change-Id: Id636bbf965d9f96c7ed5f50774c509032525b2b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93091 Tested-by: Jenkins Reviewed-by: Michael Stahl --- xmlsecurity/qa/unit/signing/signing.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'xmlsecurity') diff --git a/xmlsecurity/qa/unit/signing/signing.cxx b/xmlsecurity/qa/unit/signing/signing.cxx index 4720ee340f7e..fb2c91fc3f42 100644 --- a/xmlsecurity/qa/unit/signing/signing.cxx +++ b/xmlsecurity/qa/unit/signing/signing.cxx @@ -845,8 +845,8 @@ CPPUNIT_TEST_FIXTURE(SigningTest, testSignatureLineOOXML) { // Given: A document (docx) with a signature line and a valid signature uno::Reference xSignatures( - security::DocumentDigitalSignatures::createWithVersion( - comphelper::getProcessComponentContext(), "1.2")); + security::DocumentDigitalSignatures::createDefault( + comphelper::getProcessComponentContext())); uno::Reference xStorage = comphelper::OStorageHelper::GetStorageOfFormatFromURL( -- cgit