custom: https://www.libreoffice.org/donate/
tle>Improve loplugin:cppunitassertequal for CPPUNIT_ASSERT(a &amp;&amp; b)</title>
<updated>2021-02-08T08:15:01+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2021-02-08T06:48:59+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=6b00d0576a310796590631d14c54d7d5ea6814ac'/>
<id>6b00d0576a310796590631d14c54d7d5ea6814ac</id>
<content type='text'>
...by re-enabling the code temporarily #if'ed-out in
a528392e71bc70136021be4e3d83732fccbb885e "Fixed/improved
loplugin:cppunitassertequals" (and which then triggers lots of other
lopglugin:cppunitassertequal CPPUNIT_ASSERT -&gt; CPPUNIT_ASSERT_EQUAL warnings).

For two css::uno::Reference equality comparisons in cppu/qa/test_any.cxx, it
was more straightforward to rewrite them with an explicit call to operator ==
(which silences loplugin:cppunitassertequal) than to adapt them to
CPPUNIT_ASSERT_EQUAL's requirement for arguments of identical types.

In sc/qa/unit/ucalc_pivottable.cxx, ScDPItemData needs toString, which has been
implemented trivially for now, but might want to combine that with the
DEBUG_PIVOT_TABLE-only ScDPItemData::Dump.

Change-Id: Iae6d09cf69bd4e52fe4411bba9e50c48e696291c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110546
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
...by re-enabling the code temporarily #if'ed-out in
a528392e71bc70136021be4e3d83732fccbb885e "Fixed/improved
loplugin:cppunitassertequals" (and which then triggers lots of other
lopglugin:cppunitassertequal CPPUNIT_ASSERT -&gt; CPPUNIT_ASSERT_EQUAL warnings).

For two css::uno::Reference equality comparisons in cppu/qa/test_any.cxx, it
was more straightforward to rewrite them with an explicit call to operator ==
(which silences loplugin:cppunitassertequal) than to adapt them to
CPPUNIT_ASSERT_EQUAL's requirement for arguments of identical types.

In sc/qa/unit/ucalc_pivottable.cxx, ScDPItemData needs toString, which has been
implemented trivially for now, but might want to combine that with the
DEBUG_PIVOT_TABLE-only ScDPItemData::Dump.

Change-Id: Iae6d09cf69bd4e52fe4411bba9e50c48e696291c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110546
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tdf#42949 Fix IWYU warnings in tools/</title>
<updated>2019-04-30T13:02:42+00:00</updated>
<author>
<name>Gabor Kelemen</name>
<email>kelemen.gabor2@nisz.hu</email>
</author>
<published>2019-04-29T21:40:38+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=83abdf803a023067ebc207fd82dde987df233754'/>
<id>83abdf803a023067ebc207fd82dde987df233754</id>
<content type='text'>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I47974f5c24819eb60e6724f42d51bb206dc26d21
Reviewed-on: https://gerrit.libreoffice.org/71557
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I47974f5c24819eb60e6724f42d51bb206dc26d21
Reviewed-on: https://gerrit.libreoffice.org/71557
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>More loplugin:cstylecast: tools</title>
<updated>2018-01-12T19:13:01+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2018-01-12T19:13:01+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=8456c2ba408b3bed160d3e5f050738301b225bd5'/>
<id>8456c2ba408b3bed160d3e5f050738301b225bd5</id>
<content type='text'>
auto-rewrite with &lt;https://gerrit.libreoffice.org/#/c/47798/&gt; "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ifb9ebc9623c8df14ea0d4c907001bd16c5b9ae59
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
auto-rewrite with &lt;https://gerrit.libreoffice.org/#/c/47798/&gt; "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ifb9ebc9623c8df14ea0d4c907001bd16c5b9ae59
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix typos</title>
<updated>2017-09-15T18:33:52+00:00</updated>
<author>
<name>Andrea Gelmini</name>
<email>andrea.gelmini@gelma.net</email>
</author>
<published>2017-09-15T16:51:23+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=894115b5739b48fc241f8cd5f9f7a1830161a22d'/>
<id>894115b5739b48fc241f8cd5f9f7a1830161a22d</id>
<content type='text'>
Change-Id: I78653129638b25f16e0816b6fff11e02100c85e7
Reviewed-on: https://gerrit.libreoffice.org/42321
Reviewed-by: Adolfo Jayme Barrientos &lt;fitojb@ubuntu.com&gt;
Tested-by: Adolfo Jayme Barrientos &lt;fitojb@ubuntu.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I78653129638b25f16e0816b6fff11e02100c85e7
Reviewed-on: https://gerrit.libreoffice.org/42321
Reviewed-by: Adolfo Jayme Barrientos &lt;fitojb@ubuntu.com&gt;
Tested-by: Adolfo Jayme Barrientos &lt;fitojb@ubuntu.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>long-&gt;sal_Int32 in Fraction</title>
<updated>2017-09-15T07:53:57+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2017-09-14T06:49:52+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=331e2e5ed3bf4e0b2c1fab3b7bca836170317827'/>
<id>331e2e5ed3bf4e0b2c1fab3b7bca836170317827</id>
<content type='text'>
because long is 32bits on Windows and 64bits on Linux.

Reasoning:
(a) all the users of Fraction used to be 32bit in the past
(b) this makes the Linux code behave the same as the Windows code
(c) changing it to 64bits would be dangerous because then call sites
could see silent truncation.

Change-Id: I2a36200623a3cf2e7d62ccad030a20614e1798fb
Reviewed-on: https://gerrit.libreoffice.org/42200
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
because long is 32bits on Windows and 64bits on Linux.

Reasoning:
(a) all the users of Fraction used to be 32bit in the past
(b) this makes the Linux code behave the same as the Windows code
(c) changing it to 64bits would be dangerous because then call sites
could see silent truncation.

Change-Id: I2a36200623a3cf2e7d62ccad030a20614e1798fb
Reviewed-on: https://gerrit.libreoffice.org/42200
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>