/

'feature/svg-optimisations'>feature/svg-optimisations LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
path: root/connectivity/source/commontools/TTableHelper.cxx
AgeCommit message (Collapse)Author
2024-07-27tdf#162227: use strict order of evaluations accessing columnsMike Kaganski
ODBC SQLGetData requires that data must be retrieved in increasing column number order, unless the driver supports SQL_GD_ANY_ORDER extension (see https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlgetdata-function). We can't emplace_back(getString(4), getInt(5), ..., getString(12), getInt(17)), because MSVC would reorder calls into getInt(17) -> getString(12) -> ..., and then MS SQL Server ODBC driver will give error on access of column 12 after column 17. This partially reverts commit e8248b5e4b19df8ba469d1ca3a762960c1a053b5 "cid#1545222 COPY_INSTEAD_OF_MOVE", 2023-12-19. Change-Id: I9bf53086e526c886c4794af51a60e61d4cce89ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171097 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-05-07loplugin:ostr in connectivityNoel Grandin
Change-Id: Ice633719b05240ab5a052b62ca4eafe89f97e12f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-19cid#1545222 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545241 COPY_INSTEAD_OF_MOVE cid#1545303 COPY_INSTEAD_OF_MOVE cid#1545315 COPY_INSTEAD_OF_MOVE cid#1545319 COPY_INSTEAD_OF_MOVE cid#1545322 COPY_INSTEAD_OF_MOVE Change-Id: I284ba6e395f72abd7939667a8367ac99ab64194d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-19emplace_back instead of push_backCaolán McNamara
Change-Id: I1ea43002aba460fb81f4b2e710a19f0c3fe87c64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160954 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2022-04-20loplugin:passstuffbyrefNoel Grandin
Change-Id: I336fd329b577b6fa141265d8bc7ce67784bd7306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>