Age | Commit message (Collapse) | Author |
|
Change-Id: Iac7bb1008806efbef42ee1f9b32df0788a7c9915
|
|
...with 09d5b31ebe187a4cd9f3efca5a7cb7f87e1e19f6 "loplugin:constantfunction:
store," which apparently over-eagerly reduced functionality that happened to be
constant in one specific implicit instantiation of a template, but not in
others.
(Plus, adapting the original code to silence false loplugin:staticmethods
warnings.)
Change-Id: I156df3aef1b3b0c9d36b2a54c57de29948749bde
|
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
|
|
Change-Id: Ie38450a082dc840714051ad65c297886038e68f3
|
|
Change-Id: Ibd23c1d96b093ae2670e7752691dad29c081639f
|
|
Change-Id: I13284409404ef77eb16164b7ce2074259d2cad12
|
|
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build
Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: I87b252d3d6e5322dbc4b6cc77b846766a0d35893
|
|
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
See http://nabble.documentfoundation.org/cppcheck-arrayIndexOutOfBounds-report-in-stortree-cxx-store-module-td4136432.html
Change-Id: I365befacf7d10bcbf0a159cfdcabd3eb1644d02b
|
|
...probably not worth dragging that unused code around any more
Change-Id: I4f22a704af862d8a1fe1f2202609f355ccee7c9c
|
|
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was
detrimental to loplugin:unreffun
Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
|
|
and
coverity#1242867 Unused value
Change-Id: I8ad069a5a84b97e956cafcd925fd733fb5ed9b2e
|
|
Change-Id: I416144a4ccf2856ce85ab4b24a69958615276cb9
|
|
Change-Id: I16430567b3d57016458bd7877c36bc6e01197741
|
|
Change-Id: I650fab8227fd8b6aeb4fd4d420cb820aefd80271
|
|
Change-Id: I5f05fc312032c50639f147f27353aa560a69f65a
|
|
to replace hand-rolled version
Change-Id: I30635aec81313e4e0d1b67b30c8992fd63bb1f67
|
|
VS 2013 warns: Conversion rules for arithmetic operations in the
comparison mean that one branch cannot be executed.
Change-Id: I85f6df16b0ced94677568441d87a588bed1bfb9b
|
|
Change-Id: I2317522af91c8c60672c72a3b514767039930e22
|
|
Finish the work of ec8617568ff091026b2f17cce3b547b1633fa6c4
Only one is left: SC_PROGRESS_CXX
Change-Id: Ifdc07ec377d7a84e92bc4b0a66ab82b1fc93f76a
Reviewed-on: https://gerrit.libreoffice.org/9636
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
|