/bin/

Age	Commit message (Collapse)	Author
2023-04-04	RES_REFMARKFLD_UPDATE no more (lots of zombie code)	Bjoern Michaelsen
	- RES_REFMARKFLD_UPDATE is only instantiated in SwEditShell::UpdateOneField - ... which passes it to DocumentFieldsManager::UpdateField, which * puts it in an SwUndoFieldFromDoc into the undo stack * and passes it to UpdateTextNode - SwUndoFieldFromDoc::UpdateField only uses it to pass it back again to DocumentFieldsManager::UpdateField - in UpdateTextNode RES_REFMARKFLD_UPDATE does not trigger any specific code thus: - replace UpdateTextNode with ForceUpdateTextNode - remove the message item from the SwUndoFieldFromDoc ctor - remove the message item as a parameter to DocumentFieldsManager::UpdateField as it was only ever used for RES_REFMARKFLD_UPDATE - remove the instantiation in SwEditShell::UpdateOneField - and finally: remove RES_REFMARKFLD_UPDATE itself Change-Id: I3f7e27a555a24630d6d5a2c1a40db9096195b826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150004 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-15	clean up SwRefMarkFieldUpdate a bit	Bjoern Michaelsen
	- remove SwRefMarkFieldUpdate: * it has only one unused field * replace with a plain SwPtrMsgPoolItem - hint constness: * SwUndoFieldFromDoc: make ctor arg hint const * DocumentFieldsManager: make UpdateField arg hint const * however, seeing this hint is: a/ constructed on the stack, but b/ stored as pointer in undo likely it would be best to remove it altogether. For now, make it at least static, so that there is no use after free. Change-Id: Ica51a2a2ce19e1938c3a367e9b4a9e01bbb75374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147030 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2022-08-04	clang-tidy modernize-pass-by-value in sw	Noel Grandin
	Change-Id: Ie5c250c64f95e649d33d3f3da7b54e81a4b81d0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137781 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-21	introduce SwNodeOffset strong typedef	Noel Grandin
	for indexing into node children. Replaces various usage of sal_uLong, tools::Long, sal_uInt32 with an underlying type of sal_Int32. Also add a NODE_OFFSET_MAX constant to replace usage of ULONG_MAX Change-Id: I2f466922e1ebc19029bb2883d2b29aa4c0614170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>