/codemaker/

loplugin:finalclasses in sc 2021-02-01T06:27:34+00:00 Noel noel.grandin@collabora.co.uk 2021-01-29T07:57:09+00:00 e65b1480426667622335aeb2e2413d3d8703a273 Change-Id: Iac689d15effa08dd6216d275ad5294471e48f1b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iac689d15effa08dd6216d275ad5294471e48f1b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110155
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

never null ScViewData* 2020-09-27T19:27:41+00:00 Caolán McNamara caolanm@redhat.com 2020-09-27T13:09:02+00:00 3f7b48c4a726f51bdc5c78886957c08506e4d336 Change-Id: If5ad4c637a8c4db67ca4bfe99612e90ae6237ff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If5ad4c637a8c4db67ca4bfe99612e90ae6237ff6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103513
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[f-p]* 2018-10-29T08:30:49+00:00 Gabor Kelemen kelemeng@ubuntu.com 2018-10-22T23:54:39+00:00 8ee49e6e8f5c37682d776fac4bc01479733b9d76 Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie40401e8706dda219b8578d180983811114cabed Reviewed-on: https://gerrit.libreoffice.org/62208 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie40401e8706dda219b8578d180983811114cabed
Reviewed-on: https://gerrit.libreoffice.org/62208
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

loplugin:includeform: sc 2017-10-23T20:45:57+00:00 Stephan Bergmann sbergman@redhat.com 2017-10-23T20:33:26+00:00 3e1d3c25e064c5a97a2c408faf23a9d0c6150d8a Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd

Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd

loplugin:constparam in sc part6 2017-08-25T12:45:42+00:00 Noel Grandin noel.grandin@collabora.co.uk 2017-08-25T11:10:36+00:00 407a126af45d93f83eb4dbdc358dd569bea4db6f Change-Id: Ifbb921b820b7210e7f9539e45d4852764a1e9cbd Reviewed-on: https://gerrit.libreoffice.org/41563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifbb921b820b7210e7f9539e45d4852764a1e9cbd
Reviewed-on: https://gerrit.libreoffice.org/41563
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 2017-04-25T07:31:31+00:00 Chris Sherlock chris.sherlock79@gmail.com 2017-04-13T22:42:15+00:00 da64d198ec3b31318c92ad4bcaab18cc2bf5cfdc Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

loplugin:override: No more need for the "MSVC dtor override" workaround 2016-09-13T11:19:22+00:00 Stephan Bergmann sbergman@redhat.com 2016-09-13T11:09:01+00:00 91dd2db17bd6cb9b357d1d69b187174e31eabef0 The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e

The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e