/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* * This file is part of the LibreOffice project. * * This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #include #include #include #include #include "clang/AST/Attr.h" #include "compat.hxx" #include "plugin.hxx" namespace { bool isSalBool(QualType type) { TypedefType const * t = type->getAs(); return t != nullptr && t->getDecl()->getNameAsString() == "sal_Bool"; } // Clang 3.2 FunctionDecl::isInlined doesn't work as advertised ("Determine // whether this function should be inlined, because it is either marked 'inline' // or 'constexpr' or is a member function of a class that was defined in the // class body.") but mis-classifies salhelper::Timer's isTicking, isExpired, and // expiresBefore members as defined in salhelper/source/timer.cxx as inlined: bool isInlined(FunctionDecl const & decl) { #if CLANG_VERSION >= 30300 return decl.isInlined(); #else (void)decl; return false; #endif } // It appears that, given a function declaration, there is no way to determine // the language linkage of the function's type, only of the function's name // (via FunctionDecl::isExternC); however, in a case like // // extern "C" { static void f(); } // // the function's name does not have C language linkage while the function's // type does (as clarified in C++11 [decl.link]); cf. // "Language linkage of function type": bool hasCLanguageLinkageType(FunctionDecl const * decl) { assert(decl != nullptr); if (decl->isExternC()) { return true; } #if CLANG_VERSION >= 30300 if (decl->isInExternCContext()) { return true; } #else if (decl->getCanonicalDecl()->getDeclContext()->isExternCContext()) { return true; } #endif return false; } enum class OverrideKind { NO, YES, MAYBE }; OverrideKind getOverrideKind(FunctionDecl const * decl) { CXXMethodDecl const * m = dyn_cast(decl); if (m == nullptr) { return OverrideKind::NO; } if (m->size_overridden_methods() != 0 || m->hasAttr()) { return OverrideKind::YES; } if (!dyn_cast(m->getDeclContext())->hasAnyDependentBases()) { return OverrideKind::NO; } return OverrideKind::MAYBE; } //TODO: current implementation is not at all general, just tests what we // encounter in practice: bool hasBoolOverload(FunctionDecl const * decl, bool mustBeDeleted) { unsigned n = decl->getNumParams(); auto res = decl->getDeclContext()->lookup(decl->getDeclName()); for (auto d = compat::begin(res); d != compat::end(res); ++d) { FunctionDecl const * f = dyn_cast(*d); if (f != nullptr && (!mustBeDeleted || f->isDeleted())) { if (f->getNumParams() == n) { bool hasSB = false; for (unsigned i = 0; i != n; ++i) { QualType t1 { decl->getParamDecl(i)->getType() }; bool isSB = isSalBool(t1); bool isSBRef = !isSB && t1->isReferenceType() && isSalBool(t1.getNonReferenceType()); QualType t2 { f->getParamDecl(i)->getType() }; if (!(isSB ? t2->isBooleanType() : isSBRef ? (t2->isReferenceType() && t2.getNonReferenceType()->isBooleanType()) : t2 == t1)) { goto next; } hasSB |= isSB || isSBRef; } return hasSB; // cheaply protect against the case where decl would have no // sal_Bool parameters at all and would match itself next:; } } } return false; } class SalBool: public RecursiveASTVisitor, public loplugin::RewritePlugin { public: explicit SalBool(InstantiationData const & data): RewritePlugin(data) {} virtual void run() override; bool VisitUnaryAddrOf(UnaryOperator const * op); bool VisitCallExpr(CallExpr * expr); bool VisitCStyleCastExpr(CStyleCastExpr * expr); bool VisitCXXStaticCastExpr(CXXStaticCastExpr * expr); bool VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr * expr); bool WalkUpFromParmVarDecl(ParmVarDecl const * decl); bool VisitParmVarDecl(ParmVarDecl const * decl); bool WalkUpFromVarDecl(VarDecl const * decl); bool VisitVarDecl(VarDecl const * decl); bool WalkUpFromFieldDecl(FieldDecl const * decl); bool VisitFieldDecl(FieldDecl const * decl); bool WalkUpFromFunctionDecl(FunctionDecl const * decl); bool VisitFunctionDecl(FunctionDecl const * decl); bool VisitValueDecl(ValueDecl const * decl); private: bool isInSpecialMainFile(SourceLocation spellingLocation) const; bool rewrite(SourceLocation location); std::set varDecls_; }; void SalBool::run() { if (compiler.getLangOpts().CPlusPlus) { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); for (auto decl: varDecls_) { SourceLocation loc { decl->getLocStart() }; TypeSourceInfo * tsi = decl->getTypeSourceInfo(); if (tsi != nullptr) { SourceLocation l { compiler.getSourceManager().getExpansionLoc( tsi->getTypeLoc().getBeginLoc()) }; SourceLocation end { compiler.getSourceManager().getExpansionLoc( tsi->getTypeLoc().getEndLoc()) }; assert(l.isFileID() && end.isFileID()); if (l == end || compiler.getSourceManager().isBeforeInTranslationUnit( l, end)) { for (;;) { unsigned n = Lexer::MeasureTokenLength( l, compiler.getSourceManager(), compiler.getLangOpts()); std::string s { compiler.getSourceManager().getCharacterData(l), n }; if (s == "sal_Bool") { loc = l; break; } if (l == end) { break; } l = l.getLocWithOffset(std::max(n, 1)); } } } if (!rewrite(loc)) { report( DiagnosticsEngine::Warning, "VarDecl, use \"bool\" instead of \"sal_Bool\"", loc) << decl->getSourceRange(); } } } } bool SalBool::VisitUnaryAddrOf(UnaryOperator const * op) { Expr const * e1 = op->getSubExpr()->IgnoreParenCasts(); if (isSalBool(e1->getType())) { DeclRefExpr const * e2 = dyn_cast(e1); if (e2 != nullptr) { VarDecl const * d = dyn_cast(e2->getDecl()); if (d != nullptr) { varDecls_.erase(d); } } } return true; } bool SalBool::VisitCallExpr(CallExpr * expr) { Decl const * d = expr->getCalleeDecl(); FunctionProtoType const * ft = nullptr; if (d != nullptr) { FunctionDecl const * fd = dyn_cast(d); if (fd != nullptr) { PointerType const * pt = fd->getType()->getAs(); QualType t2(pt == nullptr ? fd->getType() : pt->getPointeeType()); ft = t2->getAs(); assert( ft != nullptr || !compiler.getLangOpts().CPlusPlus || (fd->getBuiltinID() != Builtin::NotBuiltin && isa(t2))); // __builtin_*s have no proto type? } else { VarDecl const * vd = dyn_cast(d); if (vd != nullptr) { PointerType const * pt = vd->getType()->getAs(); ft = (pt == nullptr ? vd->getType() : pt->getPointeeType()) ->getAs(); } } } if (ft != nullptr) { for (unsigned i = 0; i != compat::getNumParams(*ft); ++i) { QualType t(compat::getParamType(*ft, i)); if (t->isLValueReferenceType()) { t = t.getNonReferenceType(); if (!t.isConstQualified() && isSalBool(t) && i < expr->getNumArgs()) { DeclRefExpr * ref = dyn_cast(expr->getArg(i)); if (ref != nullptr) { VarDecl const * d = dyn_cast(ref->getDecl()); if (d != nullptr) { varDecls_.erase(d); } } } } } } return true; } bool SalBool::VisitCStyleCastExpr(CStyleCastExpr * expr) { if (ignoreLocation(expr)) { return true; } if (isSalBool(expr->getType())) { SourceLocation loc { expr->getLocStart() }; while (compiler.getSourceManager().isMacroArgExpansion(loc)) { loc = compiler.getSourceManager().getImmediateMacroCallerLoc(loc); } if (compat::isMacroBodyExpansion(compiler, loc)) { StringRef name { Lexer::getImmediateMacroName( loc, compiler.getSourceManager(), compiler.getLangOpts()) }; if (name == "sal_False" || name == "sal_True") { return true; } } report( DiagnosticsEngine::Warning, "CStyleCastExpr, suspicious cast from %0 to %1", expr->getLocStart()) << expr->getSubExpr()->IgnoreParenImpCasts()->getType() << expr->getType() << expr->getSourceRange(); } return true; } bool SalBool::VisitCXXStaticCastExpr(CXXStaticCastExpr * expr) { if (ignoreLocation(expr)) { return true; } if (isSalBool(expr->getType())) { report( DiagnosticsEngine::Warning, "CXXStaticCastExpr, suspicious cast from %0 to %1", expr->getLocStart()) << expr->getSubExpr()->IgnoreParenImpCasts()->getType() << expr->getType() << expr->getSourceRange(); } return true; } bool SalBool::VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr * expr) { if (ignoreLocation(expr)) { return true; } if (isSalBool(expr->getType())) { report( DiagnosticsEngine::Warning, "CXXFunctionalCastExpr, suspicious cast from %0 to %1", expr->getLocStart()) << expr->getSubExpr()->IgnoreParenImpCasts()->getType() << expr->getType() << expr->getSourceRange(); } return true; } bool SalBool::WalkUpFromParmVarDecl(ParmVarDecl const * decl) { return VisitParmVarDecl(decl); } bool SalBool::VisitParmVarDecl(ParmVarDecl const * decl) { if (ignoreLocation(decl)) { return true; } if (isSalBool(decl->getType().getNonReferenceType())) { FunctionDecl const * f = dyn_cast(decl->getDeclContext()); if (f != nullptr) { // e.g.: typedef sal_Bool (* FuncPtr )( sal_Bool ); f = f->getCanonicalDecl(); if (!(hasCLanguageLinkageType(f) || (isInUnoIncludeFile( compiler.getSourceManager().getSpellingLoc( f->getNameInfo().getLoc())) && (!isInlined(*f) || f->hasAttr() || decl->getType()->isReferenceType() || hasBoolOverload(f, false))) || f->isDeleted() || hasBoolOverload(f, true))) { OverrideKind k = getOverrideKind(f); if (k != OverrideKind::YES) { SourceLocation loc { decl->getLocStart() }; TypeSourceInfo * tsi = decl->getTypeSourceInfo(); if (tsi != nullptr) { SourceLocation l { compiler.getSourceManager().getExpansionLoc( tsi->getTypeLoc().getBeginLoc()) }; SourceLocation end { compiler.getSourceManager().getExpansionLoc( tsi->getTypeLoc().getEndLoc()) }; assert(l.isFileID() && end.isFileID()); if (l == end || (compiler.getSourceManager() .isBeforeInTranslationUnit(l, end))) { for (;;) { unsigned n = Lexer::MeasureTokenLength( l, compiler.getSourceManager(), compiler.getLangOpts()); std::string s { compiler.getSourceManager().getCharacterData(l), n }; if (s == "sal_Bool") { loc = l; break; } if (l == end) { break; } l = l.getLocWithOffset(std::max(n, 1)); } } } // Only rewrite declarations in include files if a // definition is also seen, to avoid compilation of a // definition (in a main file only processed later) to fail // with a "mismatch" error before the rewriter had a chance // to act upon the definition (but use the heuristic of // assuming pure virtual functions do not have definitions); // also, do not automatically rewrite functions that could // implicitly override depend base functions (and thus stop // doing so after the rewrite; note that this is less // dangerous for return types than for parameter types, // where the function would still implicitly override and // cause a compilation error due to the incompatible return // type): if (!((compat::isInMainFile( compiler.getSourceManager(), compiler.getSourceManager().getSpellingLoc( dyn_cast( decl->getDeclContext()) ->getNameInfo().getLoc())) || f->isDefined() || f->isPure()) && k != OverrideKind::MAYBE && rewrite(loc))) { report( DiagnosticsEngine::Warning, ("ParmVarDecl, use \"bool\" instead of" " \"sal_Bool\"%0"), loc) << (k == OverrideKind::MAYBE ? (" (unless this member function overrides a" " dependent base member function, even" " though it is not marked 'override')") : "") << decl->getSourceRange(); } } } } } return true; } bool SalBool::WalkUpFromVarDecl(VarDecl const * decl) { return VisitVarDecl(decl); } bool SalBool::VisitVarDecl(VarDecl const * decl) { if (ignoreLocation(decl)) { return true; } if (!decl->isExternC() && isSalBool(decl->getType()) && !isInSpecialMainFile( compiler.getSourceManager().getSpellingLoc(decl->getLocStart()))) { varDecls_.insert(decl); } return true; } bool SalBool::WalkUpFromFieldDecl(FieldDecl const * decl) { return VisitFieldDecl(decl); } bool SalBool::VisitFieldDecl(FieldDecl const * decl) { if (ignoreLocation(decl)) { return true; } if (isSalBool(decl->getType())) { TagDecl const * td = dyn_cast(decl->getDeclContext()); assert(td != nullptr); if (!(((td->isStruct() || td->isUnion()) && compat::isExternCContext(*td)) || isInUnoIncludeFile( compiler.getSourceManager().getSpellingLoc( decl->getLocation())))) { SourceLocation loc { decl->getLocStart() }; TypeSourceInfo * tsi = decl->getTypeSourceInfo(); if (tsi != nullptr) { SourceLocation l { compiler.getSourceManager().getExpansionLoc( tsi->getTypeLoc().getBeginLoc()) }; SourceLocation end { compiler.getSourceManager().getExpansionLoc( tsi->getTypeLoc().getEndLoc()) }; assert(l.isFileID() && end.isFileID()); if (l == end || compiler.getSourceManager().isBeforeInTranslationUnit( l, end)) { for (;;) { unsigned n = Lexer::MeasureTokenLength( l, compiler.getSourceManager(), compiler.getLangOpts()); std::string s { compiler.getSourceManager().getCharacterData(l), n }; if (s == "sal_Bool") { loc = l; break; } if (l == end) { break; } l = l.getLocWithOffset(std::max(n, 1)); } } } if (!rewrite(loc)) { report( DiagnosticsEngine::Warning, "FieldDecl, use \"bool\" instead of \"sal_Bool\"", loc) << decl->getSourceRange(); } } } return true; } bool SalBool::WalkUpFromFunctionDecl(FunctionDecl const * decl) { return VisitFunctionDecl(decl); } bool SalBool::VisitFunctionDecl(FunctionDecl const * decl) { if (ignoreLocation(decl)) { return true; } if (isSalBool(compat::getReturnType(*decl).getNonReferenceType())) { FunctionDecl const * f = decl->getCanonicalDecl(); OverrideKind k = getOverrideKind(f); if (k != OverrideKind::YES && !(hasCLanguageLinkageType(f) || (isInUnoIncludeFile( compiler.getSourceManager().getSpellingLoc( f->getNameInfo().getLoc())) && (!isInlined(*f) || f->hasAttr())))) { SourceLocation loc { decl->getLocStart() }; SourceLocation l { compiler.getSourceManager().getExpansionLoc( loc) }; SourceLocation end { compiler.getSourceManager().getExpansionLoc( decl->getNameInfo().getLoc()) }; assert(l.isFileID() && end.isFileID()); if (compiler.getSourceManager().isBeforeInTranslationUnit(l, end)) { while (l != end) { unsigned n = Lexer::MeasureTokenLength( l, compiler.getSourceManager(), compiler.getLangOpts()); std::string s { compiler.getSourceManager().getCharacterData(l), n }; if (s == "sal_Bool") { loc = l; break; } l = l.getLocWithOffset(std::max(n, 1)); } } // Only rewrite declarations in include files if a definition is // also seen, to avoid compilation of a definition (in a main file // only processed later) to fail with a "mismatch" error before the // rewriter had a chance to act upon the definition (but use the // heuristic of assuming pure virtual functions do not have // definitions): if (!((compat::isInMainFile( compiler.getSourceManager(), compiler.getSourceManager().getSpellingLoc( decl->getNameInfo().getLoc())) || f->isDefined() || f->isPure()) && rewrite(loc))) { report( DiagnosticsEngine::Warning, "use \"bool\" instead of \"sal_Bool\" as return type%0", loc) << (k == OverrideKind::MAYBE ? (" (unless this member function overrides a dependent" " base member function, even though it is not marked" " 'override')") : "") << decl->getSourceRange(); } } } return true; } bool SalBool::VisitValueDecl(ValueDecl const * decl) { if (ignoreLocation(decl)) { return true; } if (isSalBool(decl->getType()) && !rewrite(decl->getLocStart())) { report( DiagnosticsEngine::Warning, "ValueDecl, use \"bool\" instead of \"sal_Bool\"", decl->getLocStart()) << decl->getSourceRange(); } return true; } bool SalBool::isInSpecialMainFile(SourceLocation spellingLocation) const { return compat::isInMainFile(compiler.getSourceManager(), spellingLocation) && (compiler.getSourceManager().getFilename(spellingLocation) == SRCDIR "/cppu/qa/test_any.cxx"); } bool SalBool::rewrite(SourceLocation location) { if (rewriter != nullptr) { //TODO: "::sal_Bool" -> "bool", not "::bool" SourceLocation loc { compiler.getSourceManager().getExpansionLoc( location) }; unsigned n = Lexer::MeasureTokenLength( loc, compiler.getSourceManager(), compiler.getLangOpts()); if (std::string(compiler.getSourceManager().getCharacterData(loc), n) == "sal_Bool") { return replaceText(loc, n, "bool"); } } return false; } loplugin::Plugin::Registration X("salbool", true); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */