# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#

module_directory:=$(dir $(realpath $(firstword $(MAKEFILE_LIST))))

include $(module_directory)/../solenv/gbuild/partial_build.mk

# vim: set noet sw=4 ts=4:
ee</id>
<content type='text'>
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.

So fix that, and then make it much smarter to avoid various
false positives.

Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.

So fix that, and then make it much smarter to avoid various
false positives.

Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Adapt to Clang 12 trunk RecursiveASTVisitor change</title>
<updated>2020-07-19T21:05:57+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2020-07-19T12:53:29+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=5d546de67b44dec23ecfa5a6378e2968912f8253'/>
<id>5d546de67b44dec23ecfa5a6378e2968912f8253</id>
<content type='text'>
&lt;https://github.com/llvm/llvm-project/commit/
5689b38c6a4220cc5f6ba68a56486229b10071bf&gt; "Removed a RecursiveASTVisitor feature
to visit operator kinds with different methods".

That change is incompatible in that before the change individual TraverseUnary*
and TraverseBin* functions were called, while now TraverseUnaryOperator and
TraverseBinaryOperator/TraverseCompoundAssignOperator are called for all the
different operators.  Fixed that with a few #if for the non-shared plugins, but
that doesn't work for the shared plugin.  So made the two affected plugins non-
shared for now and left a better fix as a TODO.

Change-Id: I5b87d329ae2c4c93bf605bb1ecc9641039f014a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99000
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
&lt;https://github.com/llvm/llvm-project/commit/
5689b38c6a4220cc5f6ba68a56486229b10071bf&gt; "Removed a RecursiveASTVisitor feature
to visit operator kinds with different methods".

That change is incompatible in that before the change individual TraverseUnary*
and TraverseBin* functions were called, while now TraverseUnaryOperator and
TraverseBinaryOperator/TraverseCompoundAssignOperator are called for all the
different operators.  Fixed that with a few #if for the non-shared plugins, but
that doesn't work for the shared plugin.  So made the two affected plugins non-
shared for now and left a better fix as a TODO.

Change-Id: I5b87d329ae2c4c93bf605bb1ecc9641039f014a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99000
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "simplify sharedplugin PostTraverse calls"</title>
<updated>2019-07-17T18:40:01+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2019-07-17T13:07:50+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=476fb5d26ea766ae1aa3238e2967480857872d29'/>
<id>476fb5d26ea766ae1aa3238e2967480857872d29</id>
<content type='text'>
This reverts commit ff55ad1aceb10b900254c8ad3629775b7789d60a,
Lubos prefers it the way it was.

Change-Id: I68edc21c438b6aa2fc819245dd9a3d590af3a278
Reviewed-on: https://gerrit.libreoffice.org/75790
Reviewed-by: Luboš Luňák &lt;l.lunak@collabora.com&gt;
Tested-by: Jenkins
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit ff55ad1aceb10b900254c8ad3629775b7789d60a,
Lubos prefers it the way it was.

Change-Id: I68edc21c438b6aa2fc819245dd9a3d590af3a278
Reviewed-on: https://gerrit.libreoffice.org/75790
Reviewed-by: Luboš Luňák &lt;l.lunak@collabora.com&gt;
Tested-by: Jenkins
</pre>
</div>
</content>
</entry>
<entry>
<title>make passparamsbyref a shared plugin</title>
<updated>2019-07-17T08:42:48+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2019-07-16T13:21:10+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=5f4ae86cfe05f6e4d42c9b106e2f6b0e348e890d'/>
<id>5f4ae86cfe05f6e4d42c9b106e2f6b0e348e890d</id>
<content type='text'>
Change-Id: I4119122f1bca77ee1424abdd90b0a0956b991704
Reviewed-on: https://gerrit.libreoffice.org/75743
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I4119122f1bca77ee1424abdd90b0a0956b991704
Reviewed-on: https://gerrit.libreoffice.org/75743
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>filter out AST in more plugins</title>
<updated>2018-08-23T14:34:48+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2018-08-23T12:35:15+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=1fd27a79318b2a762e3ae1590dde783ee656234b'/>
<id>1fd27a79318b2a762e3ae1590dde783ee656234b</id>
<content type='text'>
I seem to have missed quite a few in

    commit 9f4d23c15115d64febd6bf01f870cc157badd350
    filter out some of the AST in the plugins

This nets me another 14% improvement

Change-Id: I39b980b49ced560f768045dbedd3ddfef29306c1
Reviewed-on: https://gerrit.libreoffice.org/59501
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I seem to have missed quite a few in

    commit 9f4d23c15115d64febd6bf01f870cc157badd350
    filter out some of the AST in the plugins

This nets me another 14% improvement

Change-Id: I39b980b49ced560f768045dbedd3ddfef29306c1
Reviewed-on: https://gerrit.libreoffice.org/59501
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Clean away temporarily added using declarations</title>
<updated>2017-11-07T10:50:47+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2017-11-07T10:50:47+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=b35bb38f18fd94aa67af944f76b820d59380b78b'/>
<id>b35bb38f18fd94aa67af944f76b820d59380b78b</id>
<content type='text'>
Change-Id: I26734c13515394162d88351a1cbe2b20abdac865
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I26734c13515394162d88351a1cbe2b20abdac865
</pre>
</div>
</content>
</entry>
<entry>
<title>clang::Type vs. llvm::Type ambiguity</title>
<updated>2017-09-11T08:29:01+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2017-09-11T08:29:01+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=5bbfa7ab8ded08d73dcb86c5e9fa3692b629e5bf'/>
<id>5bbfa7ab8ded08d73dcb86c5e9fa3692b629e5bf</id>
<content type='text'>
Change-Id: Idba5c15f31b25b86e2bd7b9be348a17c184fec0d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Idba5c15f31b25b86e2bd7b9be348a17c184fec0d
</pre>
</div>
</content>
</entry>
<entry>
<title>fix compiler error in passparamsbyref</title>
<updated>2017-08-17T14:18:15+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2017-08-17T14:18:15+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=19522f05880d67fda63dc6c62c0f5afb851c6a31'/>
<id>19522f05880d67fda63dc6c62c0f5afb851c6a31</id>
<content type='text'>
Under clang-3.8 we get:

compilerplugins/clang/passparamsbyref.cxx:158:31: error: no member named
'isAssignmentOp' in 'clang::CXXOperatorCallExpr'

Change-Id: Icfba2b624f53f07418674237adc5a47819f73c43
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Under clang-3.8 we get:

compilerplugins/clang/passparamsbyref.cxx:158:31: error: no member named
'isAssignmentOp' in 'clang::CXXOperatorCallExpr'

Change-Id: Icfba2b624f53f07418674237adc5a47819f73c43
</pre>
</div>
</content>
</entry>
<entry>
<title>loplugin:passstuffbyref ignore params that are assigned to</title>
<updated>2017-08-17T11:18:34+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2017-08-17T10:50:30+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=d21b119df35ca43d3a4edeab2a809c345e0f617c'/>
<id>d21b119df35ca43d3a4edeab2a809c345e0f617c</id>
<content type='text'>
makes writing nice code awkward sometimes.

Also split plugin into two different plugins, the logic was getting
tangled up.

Change-Id: I232e314d29c766c160c29373988dc37a466505be
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
makes writing nice code awkward sometimes.

Also split plugin into two different plugins, the logic was getting
tangled up.

Change-Id: I232e314d29c766c160c29373988dc37a466505be
</pre>
</div>
</content>
</entry>