From 49a74350016b59c4cca054c5802b4437c0b3857f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Wed, 4 Oct 2023 15:19:13 +0100 Subject: [PATCH] cid#1545249 Bad bit shift operation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.19 If the promoted type of the left-hand operand is int, only the five lowest-order bits of the right-hand operand are used as the shift distance. It is as if the right-hand operand were subjected to a bitwise logical AND operator & (§15.22.1) with the mask value 0x1f (0b11111). The shift distance actually used is therefore always in the range 0 to 31, inclusive. so a >>> of 32 is the same as >>> 0 so this is result = 31 * result + (maxFrameSize ^ maxFrameSize); i.e. result = 31 * result + (0); which all looks a bit dubious. Working theory from https://gerrit.libreoffice.org/c/core/+/157571/1 is that at some point maxFrameSize was a long value, and then got changed to an int, but the hashCode() was not updated and should now read as changed here. result = 31 * result + maxFrameSize; --- src/main/java/org/java_websocket/drafts/Draft_6455.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/java_websocket/drafts/Draft_6455.java b/src/main/java/org/java_websocket/drafts/Draft_6455.java index 1e08448..635fa1f 100644 --- a/src/main/java/org/java_websocket/drafts/Draft_6455.java +++ b/src/main/java/org/java_websocket/drafts/Draft_6455.java @@ -1150,7 +1150,7 @@ public class Draft_6455 extends Draft { public int hashCode() { int result = negotiatedExtension != null ? negotiatedExtension.hashCode() : 0; result = 31 * result + (protocol != null ? protocol.hashCode() : 0); - result = 31 * result + (maxFrameSize ^ (maxFrameSize >>> 32)); + result = 31 * result + maxFrameSize; return result; } -- 2.41.0 'distro/collabora/cd-5.3'>distro/collabora/cd-5.3 LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
path: root/cui/uiconfig/ui/optuserpage.ui
AgeCommit message (Expand)Author
2021-01-21remove deprecated [x|y]align property for CheckBoxes and RadioButtonsCaolán McNamara
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
2021-01-06drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
2020-09-28tdf#137039 move the super long checkbox into the available whitespaceCaolán McNamara
2020-07-29Change e-mail to email in UIOlivier Hallot
2020-07-26tdf#118148 Add extended tips to optuserpage.uiOlivier Hallot
2019-11-19Options - User Data Dialog labels left alignandreas kainz
2019-03-12weld SvxGeneralTabPageCaolán McNamara
2019-02-12“Fax” has never been an initialism—don’t write it thusAdolfo Jayme Barrientos
2019-02-07complete the univerbation of E-mail to Email in the uiCaolán McNamara
2018-04-14look for check buttons without underlinesCaolán McNamara
2018-04-02drop the spurious invisible_char[_set] propertiesCaolán McNamara
2018-03-07tdf#115084: fix sloppy mnemonic IDKatarina Behrens
2018-03-05Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara
2018-02-21tdf#115015: make crypto settings better fit allocated spaceKatarina Behrens
2017-12-19List private GPG keys in crypto config dialogKatarina Behrens
2017-11-23gpg4libre: UI and config for adding GPG keys to user's identityKatarina Behrens
2017-07-21migrate to boost::gettextCaolán McNamara
2017-04-28tdf#105841: Avoid REGRESSION!!!Tor Lillqvist
2016-08-23Simplify user name option GUI: Just a single "name" fieldTor Lillqvist
2016-04-12tdf#99104 Checkbox in User Data page isn’t aligned to anything in the sectionAdolfo Jayme Barrientos
2016-02-20Options: Some layout tweaks and copyeditingAdolfo Jayme Barrientos
2014-11-01fdo#78826 HIG: missing colons and capitalization in cui, filterAdolfo Jayme Barrientos