-*- Mode: diff -*- diff --git a/core/fpdfapi/font/cpdf_cidfont.cpp b/core/fpdfapi/font/cpdf_cidfont.cpp index f5a51b24e..8b308d0a6 100644 --- a/core/fpdfapi/font/cpdf_cidfont.cpp +++ b/core/fpdfapi/font/cpdf_cidfont.cpp @@ -755,7 +755,7 @@ int CPDF_CIDFont::GlyphFromCharCode(uint32_t charcode, bool* pVertGlyph) { uint32_t maccode = CharCodeFromUnicodeForFreetypeEncoding( FT_ENCODING_APPLE_ROMAN, name_unicode); index = maccode ? FT_Get_Char_Index(face, maccode) - : FT_Get_Name_Index(face, name); + : FT_Get_Name_Index(face, const_cast(name)); } if (index == 0 || index == 0xffff) return charcode ? static_cast(charcode) : -1; diff --git a/core/fpdfapi/font/cpdf_truetypefont.cpp b/core/fpdfapi/font/cpdf_truetypefont.cpp index 0a59b54eb..a96e11759 100644 --- a/core/fpdfapi/font/cpdf_truetypefont.cpp +++ b/core/fpdfapi/font/cpdf_truetypefont.cpp @@ -91,7 +91,7 @@ void CPDF_TrueTypeFont::LoadGlyphMap() { FT_ENCODING_APPLE_ROMAN, m_Encoding.UnicodeFromCharCode(charcode)); if (!maccode) { - m_GlyphIndex[charcode] = FT_Get_Name_Index(face, name); + m_GlyphIndex[charcode] = FT_Get_Name_Index(face, const_cast(name)); } else { m_GlyphIndex[charcode] = FT_Get_Char_Index(face, maccode); } @@ -105,7 +105,7 @@ void CPDF_TrueTypeFont::LoadGlyphMap() { m_GlyphIndex[charcode] = FT_Get_Char_Index(face, 32); continue; } - m_GlyphIndex[charcode] = FT_Get_Name_Index(face, name); + m_GlyphIndex[charcode] = FT_Get_Name_Index(face, const_cast(name)); if (m_GlyphIndex[charcode] != 0 || !bToUnicode) continue; diff --git a/core/fpdfapi/font/cpdf_type1font.cpp b/core/fpdfapi/font/cpdf_type1font.cpp index 55510e7d7..2f13f00b8 100644 --- a/core/fpdfapi/font/cpdf_type1font.cpp +++ b/core/fpdfapi/font/cpdf_type1font.cpp @@ -263,7 +263,7 @@ void CPDF_Type1Font::LoadGlyphMap() { static_cast(charcode)); if (name) { m_Encoding.SetUnicode(charcode, UnicodeFromAdobeName(name)); - m_GlyphIndex[charcode] = FT_Get_Name_Index(m_Font.GetFaceRec(), name); + m_GlyphIndex[charcode] = FT_Get_Name_Index(m_Font.GetFaceRec(), const_cast(name)); } else { m_GlyphIndex[charcode] = FT_Get_Char_Index( m_Font.GetFaceRec(), static_cast(charcode)); @@ -294,7 +294,7 @@ void CPDF_Type1Font::LoadGlyphMap() { continue; m_Encoding.SetUnicode(charcode, UnicodeFromAdobeName(name)); - m_GlyphIndex[charcode] = FT_Get_Name_Index(m_Font.GetFaceRec(), name); + m_GlyphIndex[charcode] = FT_Get_Name_Index(m_Font.GetFaceRec(), const_cast(name)); if (m_GlyphIndex[charcode] != 0) continue; diff --git a/core/fpdfdoc/cpdf_metadata.cpp b/core/fpdfdoc/cpdf_metadata.cpp index 228a0c137..bf512beb3 100644 --- a/core/fpdfdoc/cpdf_metadata.cpp +++ b/core/fpdfdoc/cpdf_metadata.cpp @@ -77,7 +77,7 @@ std::vector CPDF_Metadata::CheckForSharedForm() const { CFX_XMLParser parser(stream); std::unique_ptr doc = parser.Parse(); if (!doc) - return {}; + return std::vector(); std::vector unsupported; CheckForSharedFormInternal(doc->GetRoot(), &unsupported); diff --git a/core/fxcodec/jpx/cjpx_decoder.cpp b/core/fxcodec/jpx/cjpx_decoder.cpp index 9391d61ab..490ce2230 100644 --- a/core/fxcodec/jpx/cjpx_decoder.cpp +++ b/core/fxcodec/jpx/cjpx_decoder.cpp @@ -75,7 +75,7 @@ absl::optional alloc_rgb(size_t size) { if (!data.b) return absl::nullopt; - return data; + return std::move(data); } void sycc_to_rgb(int offset, diff --git a/core/fxge/cfx_font.cpp b/core/fxge/cfx_font.cpp index a2a44df39..d6cedee46 100644 --- a/core/fxge/cfx_font.cpp +++ b/core/fxge/cfx_font.cpp @@ -48,25 +48,9 @@ struct OUTLINE_PARAMS { // TODO(crbug.com/pdfium/1400): When FT_Done_MM_Var() is more likely to be // available to all users in the future, remove FreeMMVar() and use // FT_Done_MM_Var() directly. -// -// Use weak symbols to check if FT_Done_MM_Var() is available at runtime. -#if !BUILDFLAG(IS_WIN) -extern "C" __attribute__((weak)) decltype(FT_Done_MM_Var) FT_Done_MM_Var; -#endif void FreeMMVar(FXFT_FaceRec* rec, FXFT_MM_VarPtr variation_desc) { -#if BUILDFLAG(IS_WIN) - // Assume `use_system_freetype` GN var is never set on Windows. - constexpr bool has_ft_done_mm_var_func = true; -#else - static const bool has_ft_done_mm_var_func = !!FT_Done_MM_Var; -#endif - if (has_ft_done_mm_var_func) { - FT_Done_MM_Var(CFX_GEModule::Get()->GetFontMgr()->GetFTLibrary(), - variation_desc); - } else { FXFT_Free(rec, variation_desc); - } } FX_RECT FXRectFromFTPos(FT_Pos left, FT_Pos top, FT_Pos right, FT_Pos bottom) { diff --git a/third_party/base/numerics/safe_conversions_impl.h b/third_party/base/numerics/safe_conversions_impl.h index 44c921a14..0152a89b7 100644 --- a/third_party/base/numerics/safe_conversions_impl.h +++ b/third_party/base/numerics/safe_conversions_impl.h @@ -89,7 +89,7 @@ constexpr typename std::make_unsigned::type SafeUnsignedAbs(T value) { // TODO(jschuh): Switch to std::is_constant_evaluated() once C++20 is supported. // Alternately, the usage could be restructured for "consteval if" in C++23. -#define IsConstantEvaluated() (__builtin_is_constant_evaluated()) +#define IsConstantEvaluated() (false) // TODO(jschuh): Debug builds don't reliably propagate constants, so we restrict // some accelerated runtime paths to release builds until this can be forced diff --git a/third_party/base/span.h b/third_party/base/span.h index ed2a3c8de..87493861c 100644 --- a/third_party/base/span.h +++ b/third_party/base/span.h @@ -211,7 +211,7 @@ class TRIVIAL_ABI GSL_POINTER span { #else template > - constexpr span(Container& container) + span(Container& container) : span(container.data(), container.size()) {} #endif @@ -225,7 +225,7 @@ class TRIVIAL_ABI GSL_POINTER span { // Conversions from spans of compatible types: this allows a span to be // seamlessly used as a span, but not the other way around. template > - constexpr span(const span& other) : span(other.data(), other.size()) {} + span(const span& other) : span(other.data(), other.size()) {} span& operator=(const span& other) noexcept { if (this != &other) { ReleaseEmptySpan(); diff --git a/third_party/libopenjpeg/openjpeg.c b/third_party/libopenjpeg/openjpeg.c index 29d3ee528..d5c7a1bc9 100644 --- a/third_party/libopenjpeg/openjpeg.c +++ b/third_party/libopenjpeg/openjpeg.c @@ -433,7 +433,7 @@ OPJ_BOOL OPJ_CALLCONV opj_setup_decoder(opj_codec_t *p_codec, return OPJ_FALSE; } -OPJ_API OPJ_BOOL OPJ_CALLCONV opj_decoder_set_strict_mode(opj_codec_t *p_codec, +OPJ_BOOL OPJ_CALLCONV opj_decoder_set_strict_mode(opj_codec_t *p_codec, OPJ_BOOL strict) { if (p_codec) {