/extras/

4-7-2'>distro/mimo/mimo-5-4-7-2 LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
path: root/chart2/source/tools/DataSourceHelper.cxx
AgeCommit message (Collapse)Author
2025-02-20use more concrete UNO types in some local varsNoel Grandin
found by a clang plugin I created. Change-Id: I72ebc2b6fadb854a12d69a543facf2fd7e4f1e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-07loplugin:ostr in chart2Noel Grandin
Change-Id: I2985b6793a776639214a25bf9732c000b9026bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167236 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-03-27tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski
'chart2' module was cleaned. Change-Id: Ib4cdb3c8a21d0ed47f4970894d416327df5e68a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164864 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2023-03-29expand out ChartModelHelper::findDiagramNoel Grandin
since it just calls findFirstChartDiagram Change-Id: I21eb9a747127ad54f3b5875074a7bf7ffbf79e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-19move getDataSeries inside chart2::DiagramNoel Grandin
Change-Id: Ie60d288dba9c8d006de03c80d3cfc7bf8f108782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18move getCategories/setCategories inside chart2::DiagramNoel Grandin
Change-Id: I7c6b4e92bb131cc3c6b5b4eedb3304128b8bd988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-23Recheck module chart2 with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-02-17loplugin:unusedmethodsNoel Grandin
Change-Id: I58c60262ca543bafb4db4433dbb98b195f7571ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-09use more concrete types in chart2, DataSourceNoel Grandin
Change-Id: I513491e8d39ee79edf8521d279bd32031cf22a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-08use more concrete types in chart2, DataSeriesNoel Grandin
Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-07crashtesting ooo#20372Noel Grandin
this reverts parts of the "use more concrete types in chart2, LabeledDataSequence" commits, since writer uses it's own implementation of the XLabeledDataSequence UNO interface Change-Id: Icc2c5e9a38f789cddd9fbca63301397ce759fbff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129587 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, LabeledDataSequenceNoel Grandin
Change-Id: Iecc22ad488fff7d0536ffa37f4cde7da460c2c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129458 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, DataSourceNoel Grandin
Change-Id: If5001a8a8fc1103a8d662429d3077c7ce81cc2b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, LabeledDataSequenceNoel Grandin
Change-Id: I88d5b7e045814cbd40750ebe927e6a76d5a463d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-31use more concrete types in chart2, DataSeriesNoel Grandin
Change-Id: Ib07ed6ec3321dc617cfec872d16683cf5de60907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-28use more concrete types in chart2, ChartModelNoel Grandin
Change-Id: I0f1c50448f6ab744e40d8744340685f59f139261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-25use more concrete types in chart2, DiagramNoel Grandin
Change-Id: I40cd39d0878dc56e4e86e05149c9744cb563d745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-24use more concrete types in chart2, ChartModelNoel Grandin
Change-Id: I86b7fa98a6d4a269637ac042a9bb99b41ab90b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128870 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-24use more concrete types in chart2, ChartModelNoel Grandin
Change-Id: I621cc667d914ddfbfc84a9dd5a71bc76d411954b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128847 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-22remove css::chart::XChartTypeTemplateNoel Grandin
these are purely internal interfaces, they cannot be used from outside chart2. Change-Id: Ib89e98e8099c34a530951bd85236fced216aff18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-19use more concrete types in chart2, DiagramNoel Grandin
Change-Id: I870f6d9fa4c0b51cf7c887199079fdbabbca1fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128597 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-29Prepare for removal of non-const operator[] from Sequence in chart2Mike Kaganski
Change-Id: I71e0b458c4dd2a85e36a485e3efa72b1077b0e54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124346 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-14Avoid COW overhead using css::uno::SequenceMike Kaganski
The scenarios are: 1. Calling sequence's begin() and end() in pairs to pass to algorithms (both calls use getArray(), which does the COW checks) 2. In addition to #1, calling end() again when checking result of find algorithms, and/or begin() to calculate result's distance 3. Using non-const sequences in range-based for loops, which internally do #1 4. Assigning sequence to another sequence variable, and then modifying one of them In many cases, the sequences could be made const, or treated as const for the purposes of the algorithms (using std::as_const, std::cbegin, and std::cend). Where algorithm modifies the sequence, it was changed to only call getArray() once. For that, css::uno::toNonConstRange was introduced, which returns a struct (sublclass of std::pair) with two iterators [begin, end], that are calculated using one call to begin() and one call to getLength(). To handle #4, css::uno::Sequence::swap was introduced, that swaps the internal pointer to uno_Sequence. So when a local Sequence variable should be assigned to another variable, and the latter will be modified further, it's now possible to use swap instead, so the two sequences are kept independent. The modified places were found by temporarily removing non-const end(). Change-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123542 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08Simplify Sequences initializations (chart2)(part1)Julien Nabet
Change-Id: I97ddde9659f337932b4165b794a769b83882126d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116802 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>