Age | Commit message (Collapse) | Author |
|
Change-Id: Ic18d30239e8741f8a28e81e423d3dc223d709a93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176409
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I030bc4c824ba8946104fe2e6adfd3b445de2b238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176348
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I682acfa4e41a3cce5f4639d79004bea985cabce3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176112
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I30067b88b3d1e196f7ecfd150f5215cc93adf095
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154931
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I500e9e58c84486307c50f4ccb878ad0340412246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151039
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I00ae07a9d02e834de34f8dd7a7f53f0c68490832
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136627
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
... rather than scheme: and path.
Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Id3355be0e763217a4915b53d22220c30536415e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126852
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I59ea0d0dbd203590e7cedec51d0481c953e5172b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118155
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Mostly done by a script
for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
< UITest: introduce guarded context managers >
Change-Id: I513c76fe3536ce2d541b3588ce3f23990a0771be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118145
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Iaa03d37a9ac3862b8cb08a81e37a611632433880
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118077
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Mostly done with a script
for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
< UITest: introduce guarded context managers >
Change-Id: I9def7e8fd8256c3131ca2904f78976b9cd59aa96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118037
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This reverts commit 374baf308979306aa35575118c40ccd7caae1e29.
Many uitests are failing randomly in jenkins for no apparent
reason
Change-Id: I5960330fab4967518bfeea32b3b8c5f8bfbea57e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117752
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Mostly done by a script
for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
< UITest: introduce guarded context managers >
Change-Id: I75ef7712af3676363a9a464acf83f6f68ffc4f85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117617
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This patch includes:
* A README.help.md as a general documentation for the different
help types, the LO code and help-related build options.
* Adds --disable-xmlhelp for removing the xmlhelp support from the
build. Disable for iOS, Android and Emscripten. This was partly
included in HAVE_FEATURE_DESKTOP before.
* Rename WITH_HELP define to WITH_HELPPACKS, which reflects the
actual usage AFAIK.
* Depend --with-omindex on --with-help=online and don't override
the --with-help setting. Error out on conflicting options.
* Depend --with-helppack-integration on build help variants, which
actually result in help packs.
Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a
("Building without --with-help is not supposed to disable help
functionality").
Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
so even if an assert fails, the dialog is closed afterwards
for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
< UITest: introduce guarded context managers >
Change-Id: I9a3adb52546238d960eeaaaf03b6bdbbd5718cf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117392
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
However, without the additional 'FOCUS' action, the test would no longer verify
the fix for <https://bugs.documentfoundation.org/show_bug.cgi?id=141166>
"Crash in: mergedlo.dll: Press "Help" button in Hyperlink dialog", namely
92220638362755f0e776e222fa4e8b79377e75eb "tdf#141166 widget with id 'tabcontrol'
might not be a TabControl": At least for a --without-help Linux build, in
Window::RequestHelp at vcl/source/window/window.cxx:1897,
> else if (!mpWindowImpl->maHelpRequestHdl.IsSet() || mpWindowImpl->maHelpRequestHdl.Call(*this))
the leading `!mpWindowImpl->maHelpRequestHdl.IsSet()` would be true, so the
trailing `mpWindowImpl->maHelpRequestHdl.Call(*this)` would not be called and
would thus not lead to the problematic call of VclBuilder::get<TabControl>.
Change-Id: I35a687834b4eef46b81cc032c2f298ded8490f8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113347
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5a37f30941a73c276bc238fa9fbdfcfd8381791f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112563
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...similar to how it already got skipped with
10fbf2b80e11620f3fc1691aa7968e6d3d460db9 "Skip a problematic UITest for
--with-help=html/online". (And note how the check for "-DWITH_HELP" in $SCPDEFS
would unfortunately also hit for the --with-help=html case, see configure.ac, if
that were not already filtered with the preceding check, anyway.)
The better fix would arguably be to make the code close both the "LibreOffice
Help" window and the "LibreOffice Help Not Installed" dialog, whichever shows up
for a given configuration. But this temporary fix at least gets --with-help
builds like <https://ci.libreoffice.org/job/lo_ubsan/1961/> going again.
Change-Id: I9d9d6ffeb26a056fa3fe65085264d75822e7646c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113372
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I703eba78bb2980ac27dd11f36e03ef86c9662338
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112993
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: If81d02ad19232250c49b4446a905603250a5a2b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112938
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ic27bcaa1c6ca370abc6b1e44eac91c5e6eb41ca7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Also change an accelerator on the Internet tab to avoid
clashing with the new one for Mail tab
Change-Id: I24a03647ccba6901b1865f5ca4228e54d686d662
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108358
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
For the content of the selection it should not make a difference if that range
is "backward" or "forward", but the latter looks cleaner.
Change-Id: Ibc27ac257c9338f9b17ace10fbec938b1db394eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99932
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
They had been added with 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest :
Avoid any timing issue in test_insert_hyperlink" and
1cdda798def040fe778348061c0e18b28aa0e6bd "Further timing issues with
test_insert_hyperlink", but 63049e98a659290229d3356e76d49cea44575011 "Reliably
set up controls of hyperlink dialog in constructor" now argues that they are
probably not necessary after all: For one, they had presumably been added as
blind fixes, without actually understanding what's going on (that's at least
true for the second, monkey-see-monkey-do one by me). And for another, after I
had seen their failures frequently with my local ASan+UBSan Linux build, I
haven't seen them at all in lots of executions of that test with the
63049e98a659290229d3356e76d49cea44575011 fix included.
So lets assume that those "magic" calls are indeed not necessary after all. If
we run into trouble again, they can be added back.
Change-Id: I6f4417c9fd243758a03a4de05270f342e7147d27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99931
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
<https://ci.libreoffice.org/job/lo_ubsan/1709/> still failed with
> FAIL: test_insert_hyperlink (hyperlinkdialog.HyperlinkDialog)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/hyperlinkdialog.py", line 71, in test_insert_hyperlink
> self.assertEqual(get_state_as_dict(xindication)["Text"], "link")
> AssertionError: '' != 'link'
> + link
>
so try a fix similar to 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid
any timing issue in test_insert_hyperlink"
Change-Id: I04b1616f3c5028065aafadbd73e0e52ef220ce5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99669
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I090e28fb6d902ff0e2f9e7a9ef447133a29a85a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99520
Tested-by: Jenkins
Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This test case tests the Hyperlink Dialog in inserting a Hyperlink .
Also it tests the Vertical TabControl Support that added here:
https://gerrit.libreoffice.org/c/core/+/98135
Change-Id: Ic7975cc12425dbcba24b0261404585ded006e5e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98160
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|