/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
 * This file is part of the LibreOffice project.
 *
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/.
 *
 * This file incorporates work covered by the following license notice:
 *
 *   Licensed to the Apache Software Foundation (ASF) under one or more
 *   contributor license agreements. See the NOTICE file distributed
 *   with this work for additional information regarding copyright
 *   ownership. The ASF licenses this file to you under the Apache
 *   License, Version 2.0 (the "License"); you may not use this file
 *   except in compliance with the License. You may obtain a copy of
 *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 */
#pragma once

#include <svtools/ehdl.hxx>
#include <svtools/svtdllapi.h>

// error codes
#define SO_ERR(x) ErrCode(ErrCodeArea::So, ErrCodeClass::So, x)
#define SO_WRN(x) ErrCode(WarningFlag::Yes, ErrCodeArea::So, ErrCodeClass::So, x)

#define ERRCODE_SO_GENERALERROR             SO_ERR(1)
#define ERRCODE_SO_CANNOT_DOVERB_NOW        SO_WRN(28)
#define ERRCODE_SO_NOVERBS                  SO_ERR(30)
#define ERRCODE_SO_NOTIMPL                  SO_ERR(33)

// error contexts
#define ERRCTX_SO_DOVERB        1

SVT_DLLPUBLIC extern const ErrMsgCode RID_SO_ERROR_HANDLER[];
SVT_DLLPUBLIC extern const ErrMsgCode RID_SO_ERRCTX[];

/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
ternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8'/>
<id>4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8</id>
<content type='text'>
The bugdoc has a macro in it, and after closing the document -&gt; start
center -&gt; opening it again, you could no longer trigger the macro by
clicking on the URL field in the Calc cell.

The problem is that we cache protocol handler instances since
3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4 (framework: avoid re-creating
protocol handler instances all the time, 2022-05-02) in frames, but we
failed to invalidate this cache when the component of the frame changes.

Fix the problem by clearing the cache in XFrameImpl::setComponent(),
which gets called in this somewhat rare case when a frame gets reused to
host a different component.

[ No testcase, I'm not sure how to close a document without disposing
its XFrame from code. ]

Change-Id: I73ee83ec017f476803010cbf9e514315fc797371
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143998
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
Tested-by: Jenkins
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The bugdoc has a macro in it, and after closing the document -&gt; start
center -&gt; opening it again, you could no longer trigger the macro by
clicking on the URL field in the Calc cell.

The problem is that we cache protocol handler instances since
3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4 (framework: avoid re-creating
protocol handler instances all the time, 2022-05-02) in frames, but we
failed to invalidate this cache when the component of the frame changes.

Fix the problem by clearing the cache in XFrameImpl::setComponent(),
which gets called in this somewhat rare case when a frame gets reused to
host a different component.

[ No testcase, I'm not sure how to close a document without disposing
its XFrame from code. ]

Change-Id: I73ee83ec017f476803010cbf9e514315fc797371
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143998
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
Tested-by: Jenkins
</pre>
</div>
</content>
</entry>
<entry>
<title>clang-tidy modernize-pass-by-value in framework</title>
<updated>2022-06-02T10:12:15+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2022-06-02T08:44:17+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=c60ad041e8f48759062d652ca20216c424768fa4'/>
<id>c60ad041e8f48759062d652ca20216c424768fa4</id>
<content type='text'>
Change-Id: I024653154c51389bb27f3e94b422ff7fc1c9b46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135296
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I024653154c51389bb27f3e94b422ff7fc1c9b46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135296
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>framework: avoid re-creating protocol handler instances all the time</title>
<updated>2022-05-02T19:59:28+00:00</updated>
<author>
<name>Miklos Vajna</name>
<email>vmiklos@collabora.com</email>
</author>
<published>2022-05-02T14:25:31+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4'/>
<id>3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4</id>
<content type='text'>
Once you install an extension that adds its own protocol handlers (e.g.
&lt;https://github.com/niocs/ProtocolHandlerExtension&gt;), DispatchProvider
re-creates this protocol handler every time the custom menu gets opened
or a command gets dispatched.

This allows the dispatch provider to avoid managing the lifecycle of
those protocol handler instances, but in case the constructor of those
handlers is expensive, this leads to performance problems.

Introduce a map of handler instances in DispatchProvider to avoid
unnecessary re-creation and re-initialization: these instances get the
same XFrame anyway (the DispatchProvider is owned by the frame), so this
is meant to be safe.

No testcase for this -- the problem is only visible if you have an UNO
service registered in the global UNO service registry, but by the time
our cppunit tests run, that is already a fixed list, so this would be
hard to test from code.

Change-Id: I6d69906a795a2d5a67706002d635b6cb3091b856
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133706
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
Tested-by: Jenkins
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Once you install an extension that adds its own protocol handlers (e.g.
&lt;https://github.com/niocs/ProtocolHandlerExtension&gt;), DispatchProvider
re-creates this protocol handler every time the custom menu gets opened
or a command gets dispatched.

This allows the dispatch provider to avoid managing the lifecycle of
those protocol handler instances, but in case the constructor of those
handlers is expensive, this leads to performance problems.

Introduce a map of handler instances in DispatchProvider to avoid
unnecessary re-creation and re-initialization: these instances get the
same XFrame anyway (the DispatchProvider is owned by the frame), so this
is meant to be safe.

No testcase for this -- the problem is only visible if you have an UNO
service registered in the global UNO service registry, but by the time
our cppunit tests run, that is already a fixed list, so this would be
hard to test from code.

Change-Id: I6d69906a795a2d5a67706002d635b6cb3091b856
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133706
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
Tested-by: Jenkins
</pre>
</div>
</content>
</entry>
<entry>
<title>tdf#124176 Use pragma once in f*</title>
<updated>2021-03-23T12:07:09+00:00</updated>
<author>
<name>Vincent LE GARREC</name>
<email>libreoffice@le-garrec.fr</email>
</author>
<published>2021-03-06T07:21:49+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=90c978f839e5029c69b4acb70f37909ee3016614'/>
<id>90c978f839e5029c69b4acb70f37909ee3016614</id>
<content type='text'>
filter, forms, fpicker, framework

Change-Id: I55a25ad2dc3749e63465e638e8eeea3c322eabbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112047
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas &lt;ilmari.lauhakangas@libreoffice.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
filter, forms, fpicker, framework

Change-Id: I55a25ad2dc3749e63465e638e8eeea3c322eabbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112047
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas &lt;ilmari.lauhakangas@libreoffice.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>loplugin:finalclasses in framework</title>
<updated>2020-01-14T14:27:00+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2020-01-14T08:12:35+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=47c0d10b02f6f89ef11f5eb6ce86efb5edb69f30'/>
<id>47c0d10b02f6f89ef11f5eb6ce86efb5edb69f30</id>
<content type='text'>
Change-Id: I5405a123e887173fe4b90d66dab6225bf43883ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86740
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I5405a123e887173fe4b90d66dab6225bf43883ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86740
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tdf#42949 Fix IWYU warnings in framework/*/*hxx</title>
<updated>2019-11-11T08:48:23+00:00</updated>
<author>
<name>Gabor Kelemen</name>
<email>kelemen.gabor2@nisz.hu</email>
</author>
<published>2019-11-01T22:29:42+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=e4bf92ae344e0db16177de7fc9eed432339d8705'/>
<id>e4bf92ae344e0db16177de7fc9eed432339d8705</id>
<content type='text'>
Also drop unused framework/inc/fwkdllapi.h

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9e79266f273b778f4a8bd3330b1b0353a2e01a61
Reviewed-on: https://gerrit.libreoffice.org/81927
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also drop unused framework/inc/fwkdllapi.h

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9e79266f273b778f4a8bd3330b1b0353a2e01a61
Reviewed-on: https://gerrit.libreoffice.org/81927
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>framework: cleanup xinterface.hxx includes</title>
<updated>2017-06-07T23:10:13+00:00</updated>
<author>
<name>Jochen Nitschke</name>
<email>j.nitschke+logerrit@ok.de</email>
</author>
<published>2017-06-07T12:19:25+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=f95cb2841a373cd9665f0f0462cec0efd2b544aa'/>
<id>f95cb2841a373cd9665f0f0462cec0efd2b544aa</id>
<content type='text'>
Change-Id: I66b27e623e411c9ba9c5ba17c46c052336d031b8
Reviewed-on: https://gerrit.libreoffice.org/38503
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
Reviewed-by: Jochen Nitschke &lt;j.nitschke+logerrit@ok.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I66b27e623e411c9ba9c5ba17c46c052336d031b8
Reviewed-on: https://gerrit.libreoffice.org/38503
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
Reviewed-by: Jochen Nitschke &lt;j.nitschke+logerrit@ok.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>framework: cleanup xtypeprovider.hxx includes</title>
<updated>2017-06-07T12:00:27+00:00</updated>
<author>
<name>Jochen Nitschke</name>
<email>j.nitschke+logerrit@ok.de</email>
</author>
<published>2017-06-07T10:26:12+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=a83740ebcf91649ff2611582b124bf2d0ce2e133'/>
<id>a83740ebcf91649ff2611582b124bf2d0ce2e133</id>
<content type='text'>
LayoutManager uses macro impl from comphelper, so use declarations
from comphelper too.

Change-Id: I638492849742782d48c3bb5439c2255e72f9f694
Reviewed-on: https://gerrit.libreoffice.org/38496
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
Tested-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
LayoutManager uses macro impl from comphelper, so use declarations
from comphelper too.

Change-Id: I638492849742782d48c3bb5439c2255e72f9f694
Reviewed-on: https://gerrit.libreoffice.org/38496
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
Tested-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>