/jurt/source/

='https://go.suokunlong.cn:88/cgit/lo/core/atom/setup_native/source/win32/customactions/regactivex/regactivex.cxx?h=master' type='application/atom+xml'/>
summaryrefslogtreecommitdiff
path: root/setup_native/source/win32/customactions/regactivex/regactivex.cxx
AgeCommit message (Collapse)Author
2024-04-30WaE: C6011 Dereferencing NULL pointer warnings from unchecked mallocCaolán McNamara
Change-Id: I14892e3d0badb4a46b82624b86d78eb9bcb8eed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2019-11-26loplugin:consttobool (clang-cl)Stephan Bergmann
Change-Id: I81fea38cd737a8be74e6ece333ca37cc434a1c33 Reviewed-on: https://gerrit.libreoffice.org/83765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19loplugin:fakebool (clang-cl)Stephan Bergmann
...plus follow-up loplugin:implicitboolconversion and loplugin:redundantcast Change-Id: I9fc9c5cb46fbb50da87ff80af64cb0dfda3e5f90 Reviewed-on: https://gerrit.libreoffice.org/83207 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-26loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd Reviewed-on: https://gerrit.libreoffice.org/68378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-18Get rid of Windows .def files in setup_native, use __declspec(dllexport)Stephan Bergmann
For one, replacing the dated .def files with equivalent functionality should be a good move all by itself. And for another, it paves the way for using loplugin:external with clang-cl on Windows, which uses the heuristic of not warning about functions that are explicitly marked as __declspec(dllexport). Change-Id: I6efd50a8c5ce2a166ca0dd4e5f472118f3f9a071 Reviewed-on: https://gerrit.libreoffice.org/60691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02setup_native: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ie9f63d982acf368d27bb5b97728b060a80e8bd67 Reviewed-on: https://gerrit.libreoffice.org/49047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-28setup_native: use more Unicode in MSI custom actionsMike Kaganski
Change-Id: Id47ea566c9cf508116216625fe00013e8326b165 Reviewed-on: https://gerrit.libreoffice.org/42839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18Use even more WIN32_LEAN_AND_MEANMike Kaganski
Change-Id: I538fe5b41156366e0e87b3a93e58a3947afd18f5 Reviewed-on: https://gerrit.libreoffice.org/42398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-31loplugin:constparams: setup_native (clang-cl)Stephan Bergmann
Change-Id: I36331a6caf560c7622f72c2fafa968522f44f5e9
2016-10-16clang-cl loplugin: setup_nativeStephan Bergmann
Change-Id: I424164d19ba59697d39b3a3888ec2f743a3a832c Reviewed-on: https://gerrit.libreoffice.org/29853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-13LoadLibraryEx returns null on errorStephan Bergmann
Returning <= HINSTANCE_ERROR (aka 32) on error was apparently a feature of LoadLibrary in 16-bit Windows 3 times. Change-Id: Idf9fbd84ac1fadb67449968b65cd5e8e391a39f2 Reviewed-on: https://gerrit.libreoffice.org/29752 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-07Work towards tdf#72606 EasyHack _tstring/TCHAR eliminationskswales
Functions suffixed with A/W (ANSI/Wide) as needed for clarity This completes the _tstring/TCHAR/TEXT elimination for setup_native/ Change-Id: I66292fd490a09f75b8691274255ba41870074065 Reviewed-on: https://gerrit.libreoffice.org/25771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-18-Werror,-Wwritable-stringsStephan Bergmann
Change-Id: I18d4d9153009ff132fe07b30ad55025e3875a180
2015-11-18-Werror,-Wwritable-stringsStephan Bergmann
Change-Id: I016006135012699b4e14e869c036f4d295e5cde2
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-02We don't support Win9x anymore, remove legacy codeJesús Corrius
Change-Id: I12afdc1c25bb09d20fd0698831642b953e08bb63