Age | Commit message (Collapse) | Author |
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
|
|
Change-Id: Id8b6723e7d3d8a66f5a657628e1467edda509cfa
|
|
Change-Id: I6cc2ed1777a797c74b4a6d9618af6a62ad5ff247
|
|
Change-Id: I612a4f8ee1e49b1468a2898678660bd66902fc96
|
|
Change-Id: I45a716abba68521c5ebc203eed205e717efead7b
Reviewed-on: https://gerrit.libreoffice.org/8315
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This change "solves" the visual problem. But I don't think so
this is the best solution
Change-Id: I658f7a4182578e49644ae6de281f221499d61ad3
Reviewed-on: https://gerrit.libreoffice.org/6602
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
|
|
Change-Id: I54729ad816efd4e51e13c0a2985c591920750d59
|
|
And removed nearly all xub_StrLen in starmath.
Some sal_uInt16 which were xub_StrLen before
9a0d753b84aed53083bed3ed460308b771f432a8 are also converted to sal_Int32
where applicable.
Change-Id: I31d7794f4c7aa840545edff41a102b76bb39e042
Reviewed-on: https://gerrit.libreoffice.org/5817
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
|
|
Change-Id: I8c51db8fce8c5eea1ac7bd5751aa7f3212ef1166
Reviewed-on: https://gerrit.libreoffice.org/5790
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Elements Dock needs to have the same behavior of Elements window. After insert some symbol, if
this symbol have some placeholder, select the first placehold to user put some data.
This increases usability of Elements Dock.
Change-Id: Idc57cc6817d94f698632eb938600a55c8f9afbd8
Reviewed-on: https://gerrit.libreoffice.org/5780
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
We need to swap values of selection in Math when they're make in RTL selection, because Math don't support RTL.
Change-Id: I4f8acfb560fa486ecc9f2569f1f331fa6f28d2d4
Reviewed-on: https://gerrit.libreoffice.org/5722
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
When click in Elements Dock, we need to put focus in formula edit. Elements window do
this, so this needs to be done in Elements Dock too.
Change-Id: I8265d85fcf997344d8269345260499b3690521cb
Reviewed-on: https://gerrit.libreoffice.org/5760
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Fix a regression from 356b2f0edfd5a01ed05976c1bdb74948ff84b5fd.
This regression was about the setSelection function. We inserted the command with a space
in the right side of the string, but our selection was not counting the " " character.
So, reasign the variable with the space solve this issue.
Change-Id: Ic48f1afaec89c6eefe73d051d3b0eba7edbf557e
Reviewed-on: https://gerrit.libreoffice.org/5688
Reviewed-by: Ricardo Montania <ricardo@linuxafundo.com.br>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Now it works this way:
* Auto close in end of current line of formula
* Auto close when we have "<?>" selected
* Auto close when we're in the beginning of current line.
We're adding a space between the brakets, like this: "[ ]" and putting the
cursor in the center of these brackets.
Change-Id: I8d77bfd7c33f875e7f4070343e634c2b6c45d33c
Reviewed-on: https://gerrit.libreoffice.org/5388
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
|
|
Change 467d5e0a2e074ff2afb4d1b1a37cff2094b0895b fixed insertions of
space in front of commands for Elements dialog only.
This change also fixes insertion via Elements dock.
Change-Id: I37f8510bc4a6dc0145026ca04fbb0443e1e31cd0
Reviewed-on: https://gerrit.libreoffice.org/5225
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
Another verification needs to be done, auto close when it's in the end of line.
Change-Id: I675ac6b6a0477fc9b5747860df8dff2866189433
Reviewed-on: https://gerrit.libreoffice.org/5008
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
Check if we hit the left bracket, left parenthesis or left braces, insert the right close character
and set the current position to center the characters.
Change-Id: If1ee8a00799ef0933d5dfd51c32f669a2a27b2a7
Reviewed-on: https://gerrit.libreoffice.org/4374
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
|
|
Co-work with Rodolfo Ribeiro Gomes <rodolforg@gmail.com>. Thanks a lot man!
Verify if there is a space before insert a new command to not merge
variables.
Also, just make atributions in EndPos when it is needed, to make this more clear.
Change-Id: Ia5ddb4c4c8233b3779c0ee0c7009e181cfe5d1c3
Reviewed-on: https://gerrit.libreoffice.org/3983
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
(cherry picked from commit b73c741c4f792c71623127fdc711dc3f38603083)
Conflicts:
starmath/source/edit.cxx
Change-Id: Ie073deabb1a48f3479a9c6bbf89d1e40f5cea663
|
|
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used
also in RTF import Calc and Writer, so that could benefit as well.
* changed all EditEngine,Outliner,... related paragraph index/count
variables from sal_uInt16 to sal_Int32
* sal_Int32 instead of sal_uInt32 to match accessibility API
* matched some Outliner methods' paragraph parameters from sal_uLong
to sal_Int32
* containers capable to hold size_t nevertheless are limited to a
maximum of sal_Int32
* changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to
SAL_MAX_INT32
+ added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize
ESelection with what previously were hard coded 0xFFFF all over the
place
+ for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL
to initialize an ESelection spanning all available text like
aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL)
Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00
Reviewed-on: https://gerrit.libreoffice.org/3838
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
|
|
replaced lots of Len() with isEmpty()
Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I88873eec738a068152e7d7be0dc4ab86fcfe345a
|
|
Change-Id: I9921e9803e5d63fafffbfcf15e5c4fc2c9080669
|
|
Change-Id: If3be0db9213c405525f01c92aa4dd039e3aa6aad
Reviewed-by: Philipp Riemer <ruderphilipp@gmail.com>
|
|
mingwport35: i#117796: MinGW fix to VistaFilePickerImpl.cxx
Patch contributed by Takashi Ono
http://svn.apache.org/viewvc?view=revision&revision=1172092
|
|
Change-Id: I51abdf8539801f6d93cdc1a21a7e0e1a3d5ef785
|
|
More than two lines are removed for readability.
Change-Id: Ibff6cf68d7c512e240a54065b54a225bb23a782b
|
|
Change-Id: Ida50737f540459bd0e709c49414c3a7f4d042a47
|