# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
#*************************************************************************
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
#*************************************************************************

$(eval $(call sc_unoapi_common,indexenumeration_sheetlinksenumeration))

# vim: set noet sw=4 ts=4:
on warning)

Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
we can just take a "const &amp;".

(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)

Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
Tested-by: Jenkins
</pre>
</div>
</content>
</entry>
<entry>
<title>loplugin:ostr in svx</title>
<updated>2024-05-11T10:41:09+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2024-05-10T11:18:59+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=bc91cc47505c448ded7297074ccff809b59e8ed1'/>
<id>bc91cc47505c448ded7297074ccff809b59e8ed1</id>
<content type='text'>
Change-Id: Ia765a03e033acb82e367873380d289587ea87d6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167449
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
Tested-by: Jenkins
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ia765a03e033acb82e367873380d289587ea87d6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167449
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
Tested-by: Jenkins
</pre>
</div>
</content>
</entry>
<entry>
<title>Just use Any ctor instead of makeAny in svx</title>
<updated>2022-05-03T19:48:15+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2022-05-03T15:01:57+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=1d2b6b709e81eec8600118b3402d82707aa113bc'/>
<id>1d2b6b709e81eec8600118b3402d82707aa113bc</id>
<content type='text'>
Change-Id: I59b1b3f817a9028f132456ea5094f38f88674d00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133768
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I59b1b3f817a9028f132456ea5094f38f88674d00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133768
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>sw: remove an unused include</title>
<updated>2021-12-09T07:25:30+00:00</updated>
<author>
<name>Miklos Vajna</name>
<email>vmiklos@collabora.com</email>
</author>
<published>2021-12-08T18:42:31+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=c1128c74ad6a9efdb18db897271c7f3202a8a829'/>
<id>c1128c74ad6a9efdb18db897271c7f3202a8a829</id>
<content type='text'>
Change-Id: Ib7be7fac788e06ee885d0eca9c082b145c889ef9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126552
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ib7be7fac788e06ee885d0eca9c082b145c889ef9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126552
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>return XShape from SdrObject::getUnoShape</title>
<updated>2021-11-07T06:29:38+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel@peralex.com</email>
</author>
<published>2021-11-06T18:58:54+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=7a61256f9e68201ef7b331ca3e1b4c3302104631'/>
<id>7a61256f9e68201ef7b331ca3e1b4c3302104631</id>
<content type='text'>
instead of XInterface, to make it obvious what the reality of the
requirement is

Change-Id: Icdd4113f2a0ece930305f4d8ba010b81d24f43c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124802
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
instead of XInterface, to make it obvious what the reality of the
requirement is

Change-Id: Icdd4113f2a0ece930305f4d8ba010b81d24f43c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124802
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Prepare for removal of non-const operator[] from Sequence in svx</title>
<updated>2021-10-31T14:49:07+00:00</updated>
<author>
<name>Mike Kaganski</name>
<email>mike.kaganski@collabora.com</email>
</author>
<published>2021-10-29T07:13:01+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=5b54ba7084d6b575814af26be30cf5af5dfca12c'/>
<id>5b54ba7084d6b575814af26be30cf5af5dfca12c</id>
<content type='text'>
Change-Id: Ib5fda9469f9a1987cf9071c0e228c582cfb3dfa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124397
Tested-by: Jenkins
Reviewed-by: Mike Kaganski &lt;mike.kaganski@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ib5fda9469f9a1987cf9071c0e228c582cfb3dfa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124397
Tested-by: Jenkins
Reviewed-by: Mike Kaganski &lt;mike.kaganski@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid repeating the return type from the declaration</title>
<updated>2021-09-07T06:15:18+00:00</updated>
<author>
<name>Miklos Vajna</name>
<email>vmiklos@collabora.com</email>
</author>
<published>2021-09-06T18:08:31+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=084f60a07cf5ba41d4dd8f9bb2726c78eb8a7874'/>
<id>084f60a07cf5ba41d4dd8f9bb2726c78eb8a7874</id>
<content type='text'>
Change-Id: I0dce02d10b8c74e80f5672e2dd580b6837ba3291
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121732
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I0dce02d10b8c74e80f5672e2dd580b6837ba3291
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121732
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Adapt the remaining OUString functions to std string_view</title>
<updated>2020-12-11T20:25:10+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2020-12-11T16:44:34+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=35e471bb4d1388cf5afcdcee214cf5111edf44e3'/>
<id>35e471bb4d1388cf5afcdcee214cf5111edf44e3</id>
<content type='text'>
...for LIBO_INTERNAL_ONLY.  These had been missed by
1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take
std::u16string_view parameters" because they did not match the multi-overload
pattern that was addressed there, but they nevertheless benefit from being
changed just as well (witness e.g. the various resulting changes from copy() to
subView()).

This showed a conversion from OStringChar to std::string_view to be missing
(while the corresponding conversion form OUStringChar to std::u16string_view was
already present).

The improvement to loplugin:stringadd became necessary to fix

&gt; [CPT] compilerplugins/clang/test/stringadd.cxx
&gt; error: 'error' diagnostics expected but not seen:
&gt;   File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd]
&gt;   File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd]
&gt; 2 errors generated.

Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
...for LIBO_INTERNAL_ONLY.  These had been missed by
1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take
std::u16string_view parameters" because they did not match the multi-overload
pattern that was addressed there, but they nevertheless benefit from being
changed just as well (witness e.g. the various resulting changes from copy() to
subView()).

This showed a conversion from OStringChar to std::string_view to be missing
(while the corresponding conversion form OUStringChar to std::u16string_view was
already present).

The improvement to loplugin:stringadd became necessary to fix

&gt; [CPT] compilerplugins/clang/test/stringadd.cxx
&gt; error: 'error' diagnostics expected but not seen:
&gt;   File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd]
&gt;   File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd]
&gt; 2 errors generated.

Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>loplugin:const* make some params and methods const</title>
<updated>2020-10-06T16:35:45+00:00</updated>
<author>
<name>Noel</name>
<email>noelgrandin@gmail.com</email>
</author>
<published>2020-10-06T11:09:02+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=2ac309188820036b1b99f983e8b793445e9b2ab2'/>
<id>2ac309188820036b1b99f983e8b793445e9b2ab2</id>
<content type='text'>
Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>