# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#

$(eval $(call gb_Library_Library,propertyhdl_x64))

$(eval $(call gb_Library_set_x64,propertyhdl_x64,YES))

$(eval $(call gb_Library_use_custom_headers,propertyhdl_x64,\
	shell/source \
))

$(eval $(call gb_Library_set_include,propertyhdl_x64,\
	-I$(SRCDIR)/shell/inc \
	$$(INCLUDE) \
))

$(eval $(call gb_Library_add_defs,propertyhdl_x64,\
	-DISOLATION_AWARE_ENABLED \
	-DWIN32_LEAN_AND_MEAN \
	-UNOMINMAX \
))

$(eval $(call gb_Library_use_externals,propertyhdl_x64,\
	expat_x64 \
	zlib_x64 \
))

$(eval $(call gb_Library_use_system_win32_libs,propertyhdl_x64,\
	advapi32 \
	comctl32 \
	gdi32 \
	gdiplus \
	kernel32 \
	msvcprt \
	msvcrt \
	oldnames \
	ole32 \
	oleaut32 \
	propsys \
	shell32 \
	shlwapi \
	user32 \
	uuid \
))

$(eval $(call gb_Library_use_static_libraries,propertyhdl_x64,\
	shell_xmlparser_x64 \
	shlxthandler_common_x64 \
))

$(eval $(call gb_Library_add_ldflags,propertyhdl_x64,\
	/DEF:$(SRCDIR)/shell/source/win32/shlxthandler/prophdl/propertyhdl.def \
	/NODEFAULTLIB:libcmt.lib \
))

$(eval $(call gb_Library_add_x64_generated_exception_objects,propertyhdl_x64,\
    CustomTarget/shell/source/win32/shlxthandler/prophdl/propertyhdl \
))

# vim: set shiftwidth=4 tabstop=4 noexpandtab:
7166cf87d398072607c13
Reviewed-on: https://gerrit.libreoffice.org/67473
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I0eebd82b96d630da0597166cf87d398072607c13
Reviewed-on: https://gerrit.libreoffice.org/67473
Tested-by: Jenkins
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2</title>
<updated>2018-11-10T22:11:28+00:00</updated>
<author>
<name>Tamás Zolnai</name>
<email>tamas.zolnai@collabora.com</email>
</author>
<published>2018-11-10T16:34:31+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=afbfe42e63cdba1a18c292d7eb4875009b0f19c0'/>
<id>afbfe42e63cdba1a18c292d7eb4875009b0f19c0</id>
<content type='text'>
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d
Reviewed-on: https://gerrit.libreoffice.org/63241
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai &lt;tamas.zolnai@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d
Reviewed-on: https://gerrit.libreoffice.org/63241
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai &lt;tamas.zolnai@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>remove more rtl::OUString and OString prefixes</title>
<updated>2018-10-24T12:43:34+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2018-10-23T10:06:00+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=6f50961e69406a17d6ec998956a6b33208b1001b'/>
<id>6f50961e69406a17d6ec998956a6b33208b1001b</id>
<content type='text'>
which seem to have snuck back in since the great rounds of removals.

Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1
Reviewed-on: https://gerrit.libreoffice.org/62229
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
which seem to have snuck back in since the great rounds of removals.

Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1
Reviewed-on: https://gerrit.libreoffice.org/62229
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>a whole bunch of SAL_WARN_UNUSED</title>
<updated>2017-01-31T05:32:03+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2017-01-27T12:41:46+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=2670ca3fc597decae78499d1397539668eb84e5e'/>
<id>2670ca3fc597decae78499d1397539668eb84e5e</id>
<content type='text'>
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6
Reviewed-on: https://gerrit.libreoffice.org/33693
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6
Reviewed-on: https://gerrit.libreoffice.org/33693
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cppuhelper: fix loplugin:cppunitassertequals warnings</title>
<updated>2016-09-09T08:23:44+00:00</updated>
<author>
<name>Miklos Vajna</name>
<email>vmiklos@collabora.co.uk</email>
</author>
<published>2016-09-09T07:18:57+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=b3c72c734087b178cbcf1622e1088335c6eaf6a7'/>
<id>b3c72c734087b178cbcf1622e1088335c6eaf6a7</id>
<content type='text'>
Change-Id: Ia7c3de84b8001a30dbe1863be58a9639167cfa11
Reviewed-on: https://gerrit.libreoffice.org/28760
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.co.uk&gt;
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ia7c3de84b8001a30dbe1863be58a9639167cfa11
Reviewed-on: https://gerrit.libreoffice.org/28760
Reviewed-by: Miklos Vajna &lt;vmiklos@collabora.co.uk&gt;
Tested-by: Jenkins &lt;ci@libreoffice.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>remove unnecessary use of void in function declarations</title>
<updated>2015-04-15T09:47:12+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel@peralex.com</email>
</author>
<published>2015-04-14T10:44:47+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=71b809959bb8f775d83dc52628448bb8b8322b28'/>
<id>71b809959bb8f775d83dc52628448bb8b8322b28</id>
<content type='text'>
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
</pre>
</div>
</content>
</entry>
<entry>
<title>Removed duplicated includes</title>
<updated>2014-10-31T16:18:30+00:00</updated>
<author>
<name>Andrea Gelmini</name>
<email>andrea.gelmini@gelma.net</email>
</author>
<published>2014-10-31T06:39:30+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=c70f1545e2df5818f251b558dcc64a83d3c270d3'/>
<id>c70f1545e2df5818f251b558dcc64a83d3c270d3</id>
<content type='text'>
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot &lt;gerrit@libreoffice.org&gt;
Reviewed-by: Michael Stahl &lt;mstahl@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot &lt;gerrit@libreoffice.org&gt;
Reviewed-by: Michael Stahl &lt;mstahl@redhat.com&gt;
</pre>
</div>
</content>
</entry>