# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#

$(eval $(call gb_CppunitTest_CppunitTest,svgio))

$(eval $(call gb_CppunitTest_set_componentfile,svgio,svgio/svgio))

$(eval $(call gb_CppunitTest_set_include,svgio,\
    $$(INCLUDE) \
    -I$(SRCDIR)/svgio/inc \
))

$(eval $(call gb_CppunitTest_use_externals,svgio,\
    boost_headers \
    libxml2 \
))

$(eval $(call gb_CppunitTest_use_api,svgio,\
    offapi \
    udkapi \
))

$(eval $(call gb_CppunitTest_use_library_objects,svgio,\
    svgio \
))

$(eval $(call gb_CppunitTest_use_libraries,svgio,\
    basegfx \
    drawinglayer \
    cppu \
    cppuhelper \
    comphelper \
    sal \
    sax \
    svt \
    test \
    unotest \
    tl \
    vcl \
	$(gb_UWINAPI) \
))

$(eval $(call gb_CppunitTest_add_exception_objects,svgio,\
    svgio/qa/cppunit/SvgImportTest \
))

$(eval $(call gb_CppunitTest_use_ure,svgio))
$(eval $(call gb_CppunitTest_use_vcl,svgio))

$(eval $(call gb_CppunitTest_use_components,svgio,\
    configmgr/source/configmgr \
    dtrans/util/mcnttype \
    framework/util/fwk \
    i18npool/util/i18npool \
    package/source/xstor/xstor \
    package/util/package2 \
    toolkit/util/tk \
    sfx2/util/sfx \
    ucb/source/core/ucb1 \
    ucb/source/ucp/file/ucpfile1 \
    unotools/util/utl \
    sax/source/expatwrap/expwrap \
))

$(eval $(call gb_CppunitTest_use_configuration,svgio))

# vim: set noet sw=4 ts=4:
575edf98ccd5b15af8eafa6a3a7b64034</id>
<content type='text'>
Change-Id: If863d28c6db470faa0d22273020888d4219e069e
Reviewed-on: https://gerrit.libreoffice.org/74559
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: If863d28c6db470faa0d22273020888d4219e069e
Reviewed-on: https://gerrit.libreoffice.org/74559
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>improve loplugin simplifyconstruct</title>
<updated>2019-04-15T06:37:54+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2019-04-12T16:39:22+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=b52f309f2b9037ee53ab8ac2d66967c012ba82f1'/>
<id>b52f309f2b9037ee53ab8ac2d66967c012ba82f1</id>
<content type='text'>
to find stuff like
   OUString s = OUString("xxx")

Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04
Reviewed-on: https://gerrit.libreoffice.org/70697
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
to find stuff like
   OUString s = OUString("xxx")

Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04
Reviewed-on: https://gerrit.libreoffice.org/70697
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>make (some) clang plugins share the same RecursiveASTVisitor</title>
<updated>2019-03-12T11:36:57+00:00</updated>
<author>
<name>Luboš Luňák</name>
<email>l.lunak@collabora.com</email>
</author>
<published>2019-03-07T13:31:17+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=adb08e892b37ea9e155abbdee4e0c9951a1d163b'/>
<id>adb08e892b37ea9e155abbdee4e0c9951a1d163b</id>
<content type='text'>
Each plugin currently uses its own recursive AST run, which adds up.
This patch adds another shared plugin which internally contains all
(suitable) plugins and dispatches to them from the same one recursive
run. This patch converts ~25 plugins and for starmath's accessibility.cxx
reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any
plugins). As there are almost 50 more plugins to go, this can theoretically
result in 4.56s final time, although probably not all plugins can be
that easily converted, if at all.

This mostly requires very little change in many plugins (see e.g.
BadStatics), some even work without any functionality change (e.g.
CharRightShift). Traverse* calls require some changes but are often
not that difficult. WalkUp* probably can't be supported, although some
plugins can(?) possibly be adjusted to not rely on them. And of course
some plugins can be left as they are, using their own recursive run.
See description at the top of generator.cxx for description of how to
convert a plugin.

The sharedvisitor.cxx source is generated based on scanning relevant
plugin sources using a clang-based scanner/generator. The generated
source is intentionally included instead of getting always generated,
as the generating currently takes some time, so it should get updated
in git whenever a change in a plugin triggers a source change in it.

Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01
Reviewed-on: https://gerrit.libreoffice.org/68026
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
Reviewed-by: Luboš Luňák &lt;l.lunak@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Each plugin currently uses its own recursive AST run, which adds up.
This patch adds another shared plugin which internally contains all
(suitable) plugins and dispatches to them from the same one recursive
run. This patch converts ~25 plugins and for starmath's accessibility.cxx
reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any
plugins). As there are almost 50 more plugins to go, this can theoretically
result in 4.56s final time, although probably not all plugins can be
that easily converted, if at all.

This mostly requires very little change in many plugins (see e.g.
BadStatics), some even work without any functionality change (e.g.
CharRightShift). Traverse* calls require some changes but are often
not that difficult. WalkUp* probably can't be supported, although some
plugins can(?) possibly be adjusted to not rely on them. And of course
some plugins can be left as they are, using their own recursive run.
See description at the top of generator.cxx for description of how to
convert a plugin.

The sharedvisitor.cxx source is generated based on scanning relevant
plugin sources using a clang-based scanner/generator. The generated
source is intentionally included instead of getting always generated,
as the generating currently takes some time, so it should get updated
in git whenever a change in a plugin triggers a source change in it.

Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01
Reviewed-on: https://gerrit.libreoffice.org/68026
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
Reviewed-by: Luboš Luňák &lt;l.lunak@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>change some clang plugins to FilteringPlugins</title>
<updated>2019-03-11T18:44:33+00:00</updated>
<author>
<name>Luboš Luňák</name>
<email>l.lunak@collabora.com</email>
</author>
<published>2019-03-05T15:15:22+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=a62ad33b0eb1dac70f91a409d11ac1bcdb624842'/>
<id>a62ad33b0eb1dac70f91a409d11ac1bcdb624842</id>
<content type='text'>
As far as I can tell these do not need to scan everything, so the filtering
(and faster) base plugin is sufficient.

Change-Id: I0912a730bb5ec9670d1faa5c83f573902118cc95
Reviewed-on: https://gerrit.libreoffice.org/68872
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As far as I can tell these do not need to scan everything, so the filtering
(and faster) base plugin is sufficient.

Change-Id: I0912a730bb5ec9670d1faa5c83f573902118cc95
Reviewed-on: https://gerrit.libreoffice.org/68872
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve loplugin:simplifyconstruct warnings</title>
<updated>2018-09-14T08:39:50+00:00</updated>
<author>
<name>Stephan Bergmann</name>
<email>sbergman@redhat.com</email>
</author>
<published>2018-09-13T19:21:20+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=c62d02bcb9192c839767d6824751002696c3ed3f'/>
<id>c62d02bcb9192c839767d6824751002696c3ed3f</id>
<content type='text'>
Change-Id: I0a64d0eb9938d5a99416dbe4078ba4c05e5d588b
Reviewed-on: https://gerrit.libreoffice.org/60465
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I0a64d0eb9938d5a99416dbe4078ba4c05e5d588b
Reviewed-on: https://gerrit.libreoffice.org/60465
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann &lt;sbergman@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>loplugin:simplifyconstruct exclude std::unique_ptr with custom deleter</title>
<updated>2018-09-13T11:31:41+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2018-09-13T11:31:41+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=b74db4138342f646fda061eac5d6759ecf2c366f'/>
<id>b74db4138342f646fda061eac5d6759ecf2c366f</id>
<content type='text'>
Change-Id: I8f4ba883747a2aace88786ef807fd7c338bef5da
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I8f4ba883747a2aace88786ef807fd7c338bef5da
</pre>
</div>
</content>
</entry>
<entry>
<title>new loplugin simplifyconstruct</title>
<updated>2018-09-13T09:15:33+00:00</updated>
<author>
<name>Noel Grandin</name>
<email>noel.grandin@collabora.co.uk</email>
</author>
<published>2018-06-22T09:56:37+00:00</published>
<link rel='alternate' type='text/html' href='https://go.suokunlong.cn:88/cgit/lo/core/commit/?id=61e94390a3b86024b76c3418fe8c5e517c5c5123'/>
<id>61e94390a3b86024b76c3418fe8c5e517c5c5123</id>
<content type='text'>
no need to init smart pointers with nullptr, they all have default
constructors that do this already

Change-Id: Ief20c060daa0def8c1aa82f1cf8dc4bc696761e9
Reviewed-on: https://gerrit.libreoffice.org/59818
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
no need to init smart pointers with nullptr, they all have default
constructors that do this already

Change-Id: Ief20c060daa0def8c1aa82f1cf8dc4bc696761e9
Reviewed-on: https://gerrit.libreoffice.org/59818
Tested-by: Jenkins
Reviewed-by: Noel Grandin &lt;noel.grandin@collabora.co.uk&gt;
</pre>
</div>
</content>
</entry>