/svtools/

The build showed a missing UT and led to a problem due to the hand-made ItemSet-like SearchAttrItemList. The state 'invalid' seems to be used as 'unused' marker. It should be changed to use SfxPoolItemHolder and not need that. For now, set by using an own loop to set to that state. Change-Id: Ifc51aad60570569a1e37d3084a5e307eed47d06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165035 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> 
I checked if this is used, but it can be replaced
using Clear() -> all. This prevents that the whole
array of Items in an ItemSet gets set to
INVALID_POOL_ITEM.

I also checked if INVALID_POOL_ITEM/IsInvalidItem
is needed at all representing SfxItemState::DONTCARE
but it is and still will need to be set for individual
Items.

At last checked if SfxItemState::UNKNOWN and
::DISABLED really need to be separate states, but
indeed there are some rare cases that need that.

To make things more consistent I also renamed
SfxItemState::DONTCARE to SfxItemState::INVALID
to better match Set/IsInvalid calls at ItemSet.

The build showed a missing UT and led to a problem
due to the hand-made ItemSet-like SearchAttrItemList.
The state 'invalid' seems to be used as 'unused'
marker. It should be changed to use SfxPoolItemHolder
and not need that. For now, set by using an own loop
to set to that state.

Change-Id: Ifc51aad60570569a1e37d3084a5e307eed47d06c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165035
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
tdf#155630 Use common getPolygon for sd 2023-07-03T20:21:18+00:00 Dr. David Alan Gilbert dave@treblig.org 2023-07-01T13:34:19+00:00 a780c820f5cf3bfbb5d88bd5c6ca670e0a0c730f Unfortunately the SetLineEnds in sw is different enough from sw and sc to make sharing it a pain. However we can share the GetPolygon function we already moved into svx. Expose the svx function into the header and use it in sd. Change-Id: I05b0f820286c8ce848fa0d6c69603d3625c2b4d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> 
Unfortunately the SetLineEnds in sw is different enough from sw and sc
to make sharing it a pain.  However we can share the GetPolygon function
we already moved into svx.
Expose the svx function into the header and use it in sd.

Change-Id: I05b0f820286c8ce848fa0d6c69603d3625c2b4d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153828
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
tdf#155630 Move sc's SetLineEnds into svx 2023-07-03T19:33:44+00:00 Dr. David Alan Gilbert dave@treblig.org 2023-06-30T22:41:15+00:00 32fd602d3918be032d79322f76021c6ebc27ccba SetLineEnds is duped in sc,sd and sw. Swing SetLineEnds into svx where we'll share it. Note: a) We also move it's helper function getPolygon b) sc, sd and sw use different values for the magic nWidth value so parameterise Change-Id: I6011b41d9db7b7fab364038227e1866fb9d64b02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153826 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> 
SetLineEnds is duped in sc,sd and sw.  Swing SetLineEnds into
svx where we'll share it.

Note: a) We also move it's helper function getPolygon
  b) sc, sd and sw use different values for the magic nWidth value
     so parameterise
Change-Id: I6011b41d9db7b7fab364038227e1866fb9d64b02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153826
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
path: root/vcl/source/outdev/textline.cxx
AgeCommit message (Expand)Author
2024-10-22move vcl::DeleteOnDeinit to toolsNoel Grandin
2024-09-03ofz#70815 Timeout, reduce this limit for fuzzingCaolán McNamara
2024-06-20Resolves tdf#153223 - Suppress variable line height when skia is offHeiko Tietze
2024-04-17Drop FRound, and use generalized basegfx::froundMike Kaganski
2024-04-14Use more o3tl::convertMike Kaganski
2023-12-30move IsFuzzing to comphelperCaolán McNamara
2023-10-03ofz: Timeout, reduce limitCaolán McNamara
2023-07-25Convert internal vcl bitmap formats transparency->alpha (II)Noel Grandin
2023-07-23vcl: Drop now unneeded DevicePoint typedefKhaled Hosny
2023-07-23vcl: Use GetTextArray() when drawing mnemonicsKhaled Hosny
2023-07-23vcl: Use double for width in OutputDevice::ImplDrawTextLine()Khaled Hosny
2023-06-10Revert "tdf#151968: Fix vertical position of RTL spelling wavy line"خالد حسني
2023-05-02ofz#57493 TimeoutCaolán McNamara
2023-03-30ofz#57493 TimeoutCaolán McNamara
2023-03-05ofz#56551 TimeoutCaolán McNamara
2023-02-22tdf#151968: Fix vertical position of RTL spelling wavy lineKhaled Hosny
2023-02-07ofz#55771 TimeoutCaolán McNamara
2023-02-07improve readability of VirtualDevice constructorNoel Grandin
2023-02-04ofz#55620 TimeoutCaolán McNamara
2023-01-11rename BitmapEx::GetAlpha to GetAlphaMaskNoel Grandin
2022-12-16ofz#54334 Timeout on 8192 width/height font and underlineCaolán McNamara
2022-12-01vcl: remove unnecessary includesChris Sherlock
2022-11-29SalLayout::mnUnitsPerPixel is always 1Caolán McNamara
2022-09-30vcl: Use the same underline sizes for overlinesKhaled Hosny
2022-04-25ofz#46905 Null-dereferenceCaolán McNamara
2022-04-09no public data members in GlyphItemLuboš Luňák
2022-01-16tdf#146439 retain precise base start pos when using ResolutionIndependentLayoutCaolán McNamara
2022-01-12keep positions as DeviceCoordinate within SalLayoutCaolán McNamara