1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
|
#!/bin/python
# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
# ui-rules-enforcer enforces the .ui rules and properties used by LibreOffice
# mostly the deprecations of
# https://developer.gnome.org/gtk4/stable/gtk-migrating-3-to-4.html
# and a few other home cooked rules
# for any existing .ui this should parse it and overwrite it with the same content
# e.g. for a in `git ls-files "*.ui"`; do bin/ui-rules-enforcer.py $a; done
import lxml.etree as etree
import sys
def add_truncate_multiline(current):
use_truncate_multiline = False
istarget = current.get('class') == "GtkEntry" or current.get('class') == "GtkSpinButton"
insertpos = 0
for child in current:
add_truncate_multiline(child)
insertpos = insertpos + 1;
if not istarget:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "truncate_multiline" or attributes.get("name") == "truncate-multiline":
use_truncate_multiline = True
if istarget and not use_truncate_multiline:
truncate_multiline = etree.Element("property")
attributes = truncate_multiline.attrib
attributes["name"] = "truncate-multiline"
truncate_multiline.text = "True"
current.insert(insertpos - 1, truncate_multiline)
def do_replace_button_use_stock(current, use_stock, use_underline, label, insertpos):
if not use_underline:
underline = etree.Element("property")
attributes = underline.attrib
attributes["name"] = "use-underline"
underline.text = "True"
current.insert(insertpos - 1, underline)
current.remove(use_stock)
attributes = label.attrib
attributes["translatable"] = "yes"
attributes["context"] = "stock"
if label.text == 'gtk-add':
label.text = "_Add"
elif label.text == 'gtk-apply':
label.text = "_Apply"
elif label.text == 'gtk-cancel':
label.text = "_Cancel"
elif label.text == 'gtk-close':
label.text = "_Close"
elif label.text == 'gtk-delete':
label.text = "_Delete"
elif label.text == 'gtk-edit':
label.text = "_Edit"
elif label.text == 'gtk-help':
label.text = "_Help"
elif label.text == 'gtk-new':
label.text = "_New"
elif label.text == 'gtk-no':
label.text = "_No"
elif label.text == 'gtk-ok':
label.text = "_OK"
elif label.text == 'gtk-remove':
label.text = "_Remove"
elif label.text == 'gtk-revert-to-saved':
label.text = "_Reset"
elif label.text == 'gtk-yes':
label.text = "_Yes"
else:
raise Exception(sys.argv[1] + ': unknown label', label.text)
def replace_button_use_stock(current):
use_underline = False
use_stock = None
label = None
isbutton = current.get('class') == "GtkButton"
insertpos = 0
for child in current:
replace_button_use_stock(child)
insertpos = insertpos + 1;
if not isbutton:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "use_underline" or attributes.get("name") == "use-underline":
use_underline = True
if attributes.get("name") == "use_stock" or attributes.get("name") == "use-stock":
use_stock = child
if attributes.get("name") == "label":
label = child
if isbutton and use_stock != None:
do_replace_button_use_stock(current, use_stock, use_underline, label, insertpos)
def do_replace_image_stock(current, stock):
attributes = stock.attrib
attributes["name"] = "icon-name"
if stock.text == 'gtk-add':
stock.text = "list-add"
elif stock.text == 'gtk-remove':
stock.text = "list-remove"
elif stock.text == 'gtk-paste':
stock.text = "edit-paste"
elif stock.text == 'gtk-index':
stock.text = "vcl/res/index.png"
elif stock.text == 'gtk-refresh':
stock.text = "view-refresh"
elif stock.text == 'gtk-dialog-error':
stock.text = "dialog-error"
elif stock.text == 'gtk-apply':
stock.text = "sw/res/sc20558.png"
elif stock.text == 'gtk-missing-image':
stock.text = "missing-image"
elif stock.text == 'gtk-copy':
stock.text = "edit-copy"
elif stock.text == 'gtk-go-back':
stock.text = "go-previous"
elif stock.text == 'gtk-go-forward':
stock.text = "go-next"
elif stock.text == 'gtk-go-down':
stock.text = "go-down"
elif stock.text == 'gtk-go-up':
stock.text = "go-up"
elif stock.text == 'gtk-goto-first':
stock.text = "go-first"
elif stock.text == 'gtk-goto-last':
stock.text = "go-last"
elif stock.text == 'gtk-new':
stock.text = "document-new"
elif stock.text == 'gtk-media-stop':
stock.text = "media-playback-stop"
elif stock.text == 'gtk-media-play':
stock.text = "media-playback-start"
elif stock.text == 'gtk-media-next':
stock.text = "media-skip-forward"
elif stock.text == 'gtk-media-previous':
stock.text = "media-skip-backward"
elif stock.text == 'gtk-close':
stock.text = "window-close"
elif stock.text == 'gtk-help':
stock.text = "help-browser"
else:
raise Exception(sys.argv[1] + ': unknown stock name', stock.text)
def replace_image_stock(current):
stock = None
isimage = current.get('class') == "GtkImage"
for child in current:
replace_image_stock(child)
if not isimage:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "stock":
stock = child
if isimage and stock != None:
do_replace_image_stock(current, stock)
def remove_check_button_align(current):
xalign = None
yalign = None
ischeckorradiobutton = current.get('class') == "GtkCheckButton" or current.get('class') == "GtkRadioButton"
for child in current:
remove_check_button_align(child)
if not ischeckorradiobutton:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "xalign":
xalign = child
if attributes.get("name") == "yalign":
yalign = child
if ischeckorradiobutton:
if xalign != None:
if xalign.text != "0":
raise Exception(sys.argv[1] + ': non-default xalign', xalign.text)
current.remove(xalign)
if yalign != None:
if yalign.text != "0.5":
raise Exception(sys.argv[1] + ': non-default yalign', yalign.text)
current.remove(yalign)
def remove_check_button_relief(current):
relief = None
ischeckorradiobutton = current.get('class') == "GtkCheckButton" or current.get('class') == "GtkRadioButton"
for child in current:
remove_check_button_relief(child)
if not ischeckorradiobutton:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "relief":
relief = child
if ischeckorradiobutton:
if relief != None:
current.remove(relief)
def remove_check_button_image_position(current):
image_position = None
ischeckorradiobutton = current.get('class') == "GtkCheckButton" or current.get('class') == "GtkRadioButton"
for child in current:
remove_check_button_image_position(child)
if not ischeckorradiobutton:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "image_position" or attributes.get("name") == "image-position":
image_position = child
if ischeckorradiobutton:
if image_position != None:
current.remove(image_position)
def remove_spin_button_input_purpose(current):
input_purpose = None
isspinbutton = current.get('class') == "GtkSpinButton"
for child in current:
remove_spin_button_input_purpose(child)
if not isspinbutton:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "input_purpose" or attributes.get("name") == "input-purpose":
input_purpose = child
if isspinbutton:
if input_purpose != None:
current.remove(input_purpose)
def remove_spin_button_max_length(current):
max_length = None
isspinbutton = current.get('class') == "GtkSpinButton"
for child in current:
remove_spin_button_max_length(child)
if not isspinbutton:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "max_length" or attributes.get("name") == "max-length":
max_length = child
if isspinbutton:
if max_length != None:
current.remove(max_length)
def remove_track_visited_links(current):
track_visited_links = None
islabel = current.get('class') == "GtkLabel"
for child in current:
remove_track_visited_links(child)
if not islabel:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "track_visited_links" or attributes.get("name") == "track-visited-links":
track_visited_links = child
if track_visited_links != None:
current.remove(track_visited_links)
def remove_double_buffered(current):
double_buffered = None
for child in current:
remove_double_buffered(child)
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "double_buffered" or attributes.get("name") == "double-buffered":
double_buffered = child
if double_buffered != None:
current.remove(double_buffered)
def remove_skip_pager_hint(current):
skip_pager_hint = None
for child in current:
remove_skip_pager_hint(child)
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "skip_pager_hint" or attributes.get("name") == "skip-pager-hint":
skip_pager_hint = child
if skip_pager_hint != None:
current.remove(skip_pager_hint)
def remove_expander_label_fill(current):
label_fill = None
isexpander = current.get('class') == "GtkExpander"
for child in current:
remove_expander_label_fill(child)
if not isexpander:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "label_fill" or attributes.get("name") == "label-fill":
label_fill = child
if label_fill != None:
current.remove(label_fill)
def remove_expander_spacing(current):
spacing = None
isexpander = current.get('class') == "GtkExpander"
for child in current:
remove_expander_spacing(child)
if not isexpander:
continue
if child.tag == "property":
attributes = child.attrib
if attributes.get("name") == "spacing":
spacing = child
if spacing != None:
current.remove(spacing)
def enforce_menubutton_indicator_consistency(current):
draw_indicator = None
image = None
ismenubutton = current.get('class') == "GtkMenuButton"
insertpos = 0
for child in current:
enforce_menubutton_indicator_consistency(child)
if not ismenubutton:
continue
if child.tag == "property":
insertpos = insertpos + 1;
attributes = child.attrib
if attributes.get("name") == "draw_indicator" or attributes.get("name") == "draw-indicator":
draw_indicator = child
elif attributes.get("name") == "image":
image = child
if ismenubutton:
if draw_indicator == None:
if image == None:
# if there is no draw indicator and no image there should be a draw indicator
draw_indicator = etree.Element("property")
attributes = draw_indicator.attrib
attributes["name"] = "draw-indicator"
draw_indicator.text = "True"
current.insert(insertpos, draw_indicator)
else:
# if there is no draw indicator but there is an image that image should be open-menu-symbolic or x-office-calendar
for status_elem in tree.xpath("/interface/object[@id='" + image.text + "']/property[@name='icon_name' or @name='icon-name']"):
if status_elem.text != 'x-office-calendar':
status_elem.text = "open-menu-symbolic"
def enforce_active_in_group_consistency(current):
group = None
active = None
isradiobutton = current.get('class') == "GtkRadioButton"
insertpos = 0
for child in current:
enforce_active_in_group_consistency(child)
if not isradiobutton:
continue
if child.tag == "property":
insertpos = insertpos + 1;
attributes = child.attrib
if attributes.get("name") == "group":
group = child
if attributes.get("name") == "active":
active = child
if isradiobutton:
if active != None and active.text != "True":
raise Exception(sys.argv[1] + ': non-standard active value', active.text)
if group != None and active != None:
# if there is a group then we are not the leader and should not be active
current.remove(active)
elif group == None and active == None:
# if there is no group then we are the leader and should be active
active = etree.Element("property")
attributes = active.attrib
attributes["name"] = "active"
active.text = "True"
current.insert(insertpos, active)
with open(sys.argv[1], encoding="utf-8") as f:
header = f.readline()
f.seek(0)
# remove_blank_text so pretty-printed input doesn't disrupt pretty-printed
# output if nodes are added or removed
parser = etree.XMLParser(remove_blank_text=True)
tree = etree.parse(f, parser)
# make sure <property name="label" translatable="no"></property> stays like that
# and doesn't change to <property name="label" translatable="no"/>
for status_elem in tree.xpath("//property[@name='label' and string() = '']"):
status_elem.text = ""
root = tree.getroot()
# do some targeted conversion here
# tdf#138848 Copy-and-Paste in input box should not append an ENTER character
if not sys.argv[1].endswith('/multiline.ui'): # let this one alone not truncate multiline pastes
add_truncate_multiline(root)
replace_button_use_stock(root)
replace_image_stock(root)
remove_check_button_align(root)
remove_check_button_relief(root)
remove_check_button_image_position(root)
remove_spin_button_input_purpose(root)
remove_spin_button_max_length(root)
remove_track_visited_links(root)
remove_expander_label_fill(root)
remove_expander_spacing(root)
enforce_menubutton_indicator_consistency(root)
enforce_active_in_group_consistency(root)
remove_double_buffered(root)
remove_skip_pager_hint(root)
with open(sys.argv[1], 'wb') as o:
# without encoding='unicode' (and the matching encode("utf8")) we get &#XXXX replacements for non-ascii characters
# which we don't want to see changed in the output
o.write(etree.tostring(tree, pretty_print=True, method='xml', encoding='unicode', doctype=header[0:-1]).encode("utf8"))
# vim: set shiftwidth=4 softtabstop=4 expandtab:
|