blob: c4a61e77228116b910c41c3f703c6b68e96d0ef7 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include "plugin.hxx"
/**
the comma operator is best used sparingly
*/
namespace {
class CommaOperator:
public RecursiveASTVisitor<CommaOperator>, public loplugin::Plugin
{
public:
explicit CommaOperator(InstantiationData const & data): Plugin(data) {}
virtual void run() override
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitBinaryOperator(const BinaryOperator* );
};
bool CommaOperator::VisitBinaryOperator(const BinaryOperator* binaryOp)
{
if (ignoreLocation(binaryOp)) {
return true;
}
// Ignore FD_SET expanding to "...} while(0, 0)" in some Microsoft
// winsock2.h (TODO: improve heuristic of determining that the whole
// binaryOp is part of a single macro body expansion):
if (compiler.getSourceManager().isMacroBodyExpansion(
binaryOp->getLocStart())
&& compiler.getSourceManager().isMacroBodyExpansion(
binaryOp->getOperatorLoc())
&& compiler.getSourceManager().isMacroBodyExpansion(
binaryOp->getLocEnd())
&& ignoreLocation(
compiler.getSourceManager().getSpellingLoc(
binaryOp->getOperatorLoc())))
{
return true;
}
if (binaryOp->getOpcode() != BO_Comma) {
return true;
}
const Stmt* parent = parentStmt(binaryOp);
if (parent != nullptr) {
if (isa<ParenExpr>(parent)) {
return true;
}
if (isa<BinaryOperator>(parent)) {
return true;
}
if (isa<ForStmt>(parent)) {
return true;
}
if (isa<ExprWithCleanups>(parent)) {
const Stmt* parent2 = parentStmt(parent);
if (isa<ForStmt>(parent2)) {
return true;
}
}
}
// parent->dump();
report(
DiagnosticsEngine::Warning, "comma operator hides code",
binaryOp->getOperatorLoc())
<< binaryOp->getSourceRange();
return true;
}
loplugin::Plugin::Registration< CommaOperator > X("commaoperator", true);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
