blob: e701b38849f25d540f45beb65da1b99cd77044ba (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* Based on LLVM/Clang.
*
* This file is distributed under the University of Illinois Open Source
* License. See LICENSE.TXT for details.
*
*/
#include "check.hxx"
#include "plugin.hxx"
#include <clang/Lex/Lexer.h>
#include <fstream>
#include <set>
namespace loplugin
{
/*
This is a compile check.
Check that DBG_UNHANDLED_EXCEPTION is always the first statement in a catch block, otherwise
it does not work properly.
*/
class DbgUnhandledException : public loplugin::FilteringPlugin<DbgUnhandledException>
{
public:
explicit DbgUnhandledException(InstantiationData const& data);
virtual void run() override;
bool VisitCallExpr(CallExpr const* call);
bool TraverseCXXCatchStmt(CXXCatchStmt*);
private:
CXXCatchStmt const* currCatchStmt = nullptr;
};
DbgUnhandledException::DbgUnhandledException(const InstantiationData& data)
: FilteringPlugin(data)
{
}
void DbgUnhandledException::run()
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool DbgUnhandledException::TraverseCXXCatchStmt(CXXCatchStmt* catchStmt)
{
auto prevCatchStmt = currCatchStmt;
currCatchStmt = catchStmt;
auto rv = RecursiveASTVisitor::TraverseCXXCatchStmt(catchStmt);
currCatchStmt = prevCatchStmt;
return rv;
}
bool DbgUnhandledException::VisitCallExpr(const CallExpr* call)
{
if (ignoreLocation(call))
return true;
const FunctionDecl* func = call->getDirectCallee();
if (!func)
return true;
if (!func->getIdentifier() || func->getName() != "DbgUnhandledException")
return true;
if (!currCatchStmt)
{
report(DiagnosticsEngine::Warning, "DBG_UNHANDLED_EXCEPTION outside catch block",
compat::getBeginLoc(call));
return true;
}
auto catchBlock = dyn_cast<CompoundStmt>(currCatchStmt->getHandlerBlock());
if (!catchBlock)
{
report(DiagnosticsEngine::Warning,
"something wrong with DBG_UNHANDLED_EXCEPTION, no CompoundStmt?",
compat::getBeginLoc(call));
return true;
}
if (catchBlock->size() < 1)
{
report(DiagnosticsEngine::Warning,
"something wrong with DBG_UNHANDLED_EXCEPTION, CompoundStmt size == 0?",
compat::getBeginLoc(call));
return true;
}
Stmt const* firstStmt = *catchBlock->body_begin();
if (auto exprWithCleanups = dyn_cast<ExprWithCleanups>(firstStmt))
firstStmt = exprWithCleanups->getSubExpr();
if (firstStmt != call)
{
report(DiagnosticsEngine::Warning,
"DBG_UNHANDLED_EXCEPTION must be first statement in catch block",
compat::getBeginLoc(call));
}
return true;
}
static Plugin::Registration<DbgUnhandledException> X("dbgunhandledexception");
} // namespace
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
