blob: 4127aa305ba92205d7433988c1df04f29d11ffa1 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <string>
#include <set>
#include "plugin.hxx"
// Find places where we call a method with values == the values specified in the parameter defaults.
// i.e. where the code might as well not specify anything.
namespace {
class DefaultParams:
public RecursiveASTVisitor<DefaultParams>, public loplugin::Plugin
{
public:
explicit DefaultParams(InstantiationData const & data): Plugin(data) {}
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitCallExpr(CallExpr * callExpr);
};
bool DefaultParams::VisitCallExpr(CallExpr * callExpr) {
if (ignoreLocation(callExpr)) {
return true;
}
if (callExpr->getNumArgs() == 0) {
return true;
}
if (callExpr->getDirectCallee() == nullptr) {
return true;
}
const FunctionDecl* functionDecl = callExpr->getDirectCallee()->getCanonicalDecl();
unsigned i = callExpr->getNumArgs() - 1;
Expr* arg = callExpr->getArg(i);
// variadic functions
if (i >= functionDecl->getNumParams()) {
return true;
}
if (arg->isDefaultArgument()) {
return true;
}
// ignore this, it seems to trigger an infinite recursion
if (isa<UnaryExprOrTypeTraitExpr>(arg))
return true;
const ParmVarDecl* parmVarDecl = functionDecl->getParamDecl(i);
const Expr* defaultArgExpr = parmVarDecl->getDefaultArg();
if (parmVarDecl->hasDefaultArg() &&
defaultArgExpr &&
defaultArgExpr->getType()->isIntegralType(compiler.getASTContext()))
{
APSInt x1, x2;
if (arg->EvaluateAsInt(x1, compiler.getASTContext()) &&
defaultArgExpr->EvaluateAsInt(x2, compiler.getASTContext()) &&
x1 == x2)
{
report(
DiagnosticsEngine::Warning,
"not necessary to pass this argument, it defaults to the same value",
arg->getSourceRange().getBegin())
<< arg->getSourceRange();
/*report(
DiagnosticsEngine::Warning,
"default method parameter declaration here",
parmVarDecl->getSourceRange().getBegin())
<< parmVarDecl->getSourceRange();*/
}
}
return true;
}
loplugin::Plugin::Registration< DefaultParams > X("defaultparams");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
