1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <memory>
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include "plugin.hxx"
#include "check.hxx"
/**
The types 'long' and 'unsigned long' are different sizes on different platforms, making them wholly unsuitable
for portable code.
And when I mean different sizes, I mean 64bit Linux and 64bit Windows have different sizes.
*/
namespace {
static bool startswith(const std::string& rStr, const char* pSubStr) {
return rStr.compare(0, strlen(pSubStr), pSubStr) == 0;
}
class DropLong:
public RecursiveASTVisitor<DropLong>, public loplugin::Plugin
{
public:
explicit DropLong(loplugin::InstantiationData const & data): Plugin(data) {}
virtual void run() override
{
std::string fn( compiler.getSourceManager().getFileEntryForID(
compiler.getSourceManager().getMainFileID())->getName() );
loplugin::normalizeDotDotInFilePath(fn);
if (startswith(fn, SRCDIR "/sal/"))
return;
if (startswith(fn, SRCDIR "/desktop/unx/"))
return;
if (startswith(fn, SRCDIR "/bridges/"))
return;
if (startswith(fn, SRCDIR "/registry/"))
return;
if (startswith(fn, SRCDIR "/tools/source/generic/fract.cxx"))
return;
if (startswith(fn, SRCDIR "/tools/source/generic/bigint.cxx"))
return;
// TODO figure out how to cope with iterators
if (startswith(fn, SRCDIR "/cppu/source/threadpool/jobqueue.cxx"))
return;
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitBinAssign(BinaryOperator const *);
bool VisitVarDecl(VarDecl const *);
bool VisitCastExpr(CastExpr const *);
private:
bool isOK(QualType lhs, QualType rhs);
};
bool DropLong::VisitBinAssign(BinaryOperator const * expr)
{
if (ignoreLocation(expr))
return true;
StringRef fileName { compiler.getSourceManager().getFilename(expr->getExprLoc()) };
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/include/tools/bigint.hxx"))
return true;
auto lhsType = expr->getLHS()->getType();
auto rhsType = expr->getRHS()->IgnoreCasts()->getType();
if (!isOK(lhsType, rhsType))
{
report(
DiagnosticsEngine::Warning,
"rather replace %0 with %1",
expr->getExprLoc())
<< lhsType
<< rhsType
<< expr->getSourceRange();
// lhsType->dump();
}
return true;
}
bool DropLong::VisitVarDecl(VarDecl const * varDecl)
{
if (ignoreLocation(varDecl))
return true;
StringRef fileName { compiler.getSourceManager().getFilename(varDecl->getLocation()) };
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/include/tools/bigint.hxx"))
return true;
if (!varDecl->hasInit())
return true;
auto lhsType = varDecl->getType();
auto rhsType = varDecl->getInit()->IgnoreCasts()->getType();
if (!isOK(lhsType, rhsType))
{
report(
DiagnosticsEngine::Warning,
"rather replace %0 with %1",
varDecl->getLocation())
<< lhsType
<< rhsType
<< varDecl->getSourceRange();
// lhsType->dump();
}
return true;
}
bool DropLong::VisitCastExpr(CastExpr const * castExpr)
{
if (ignoreLocation(castExpr))
return true;
StringRef fileName { compiler.getSourceManager().getFilename(castExpr->getExprLoc()) };
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/include/tools/bigint.hxx"))
return true;
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/include/sal/types.h"))
return true;
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/include/rtl/math.hxx"))
return true;
// TODO
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/include/tools/helpers.hxx"))
return true;
if (isa<ImplicitCastExpr>(castExpr))
return true;
auto type = castExpr->getType();
if (loplugin::TypeCheck(type).Typedef())
{
TypedefType const * typedefType = type->getAs<TypedefType>();
if (typedefType->getDecl()->getName() == "sal_uLong")
report(
DiagnosticsEngine::Warning,
"sal_uLong cast from %0",
castExpr->getExprLoc())
<< castExpr->getSubExpr()->getType()
<< castExpr->getSourceRange();
}
else if (type->isSpecificBuiltinType(BuiltinType::Kind::Long)
|| type->isSpecificBuiltinType(BuiltinType::Kind::ULong))
{
report(
DiagnosticsEngine::Warning,
"long cast from %0",
castExpr->getExprLoc())
<< castExpr->getSubExpr()->getType()
<< castExpr->getSourceRange();
}
return true;
}
bool DropLong::isOK(QualType lhs, QualType rhs)
{
if (loplugin::TypeCheck(lhs).Typedef())
{
TypedefType const * typedefType = lhs->getAs<TypedefType>();
// Lots of stuff in the standard library and in sal/types.h is
// 'long' on Linux, so just ignore all typedefs.
if (typedefType->getDecl()->getName() != "sal_uLong")
return true;
}
else if (lhs->isSpecificBuiltinType(BuiltinType::Kind::Long)
|| lhs->isSpecificBuiltinType(BuiltinType::Kind::ULong))
{
if (rhs->isSpecificBuiltinType(BuiltinType::Kind::Long)
|| rhs->isSpecificBuiltinType(BuiltinType::Kind::ULong))
return true;
}
else
return true;
if (isa<SubstTemplateTypeParmType>(lhs))
return true;
if (isa<AutoType>(lhs))
return true;
return false;
}
loplugin::Plugin::Registration< DropLong > X("droplong", false);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
