1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* Based on LLVM/Clang.
*
* This file is distributed under the University of Illinois Open Source
* License. See LICENSE.TXT for details.
*
*/
#include <iostream>
#include <unordered_map>
#include "plugin.hxx"
#include <clang/Frontend/CompilerInstance.h>
#include <clang/Frontend/FrontendActions.h>
#include <clang/Tooling/CommonOptionsParser.h>
#include <clang/Tooling/Refactoring.h>
#include <llvm/Support/Signals.h>
/// Finds duplicated preprocessor defines, which generally indicate that some definition
/// needs to be centralised somewhere.
namespace
{
struct Entry
{
clang::SourceLocation m_aLoc;
};
class DuplicateDefines : public clang::PPCallbacks, public loplugin::Plugin
{
public:
explicit DuplicateDefines(const loplugin::InstantiationData& data);
virtual void run() override;
void MacroDefined(const Token& MacroNameTok, const MacroDirective* MD) override;
void MacroUndefined(const Token& MacroNameTok, const MacroDefinition& MD,
const MacroDirective* Undef) override;
enum
{
isPPCallback = true
};
private:
clang::Preprocessor& m_rPP;
std::unordered_map<std::string, Entry> m_aDefMap;
};
DuplicateDefines::DuplicateDefines(const loplugin::InstantiationData& data)
: Plugin(data)
, m_rPP(compiler.getPreprocessor())
{
compiler.getPreprocessor().addPPCallbacks(std::unique_ptr<PPCallbacks>(this));
}
void DuplicateDefines::run()
{
// nothing, only check preprocessor usage
}
void DuplicateDefines::MacroDefined(const Token& rMacroNameTok, const MacroDirective*)
{
auto aLoc = rMacroNameTok.getLocation();
if (ignoreLocation(aLoc))
return;
std::string aMacroName = m_rPP.getSpelling(rMacroNameTok);
// some testing macro
if (aMacroName == "RTL_STRING_CONST_FUNCTION")
return;
if (aMacroName == "rtl")
return;
// we replicate this macro in all the .hrc files
if (aMacroName == "NC_")
return;
// TODO no obvious fix for these
if (aMacroName == "FID_SEARCH_NOW" || aMacroName == "FID_SVX_START" || aMacroName == "FN_PARAM")
return;
if (!m_aDefMap.emplace(aMacroName, Entry{ aLoc }).second)
{
report(DiagnosticsEngine::Warning, "duplicate defines", aLoc);
report(DiagnosticsEngine::Note, "previous define", m_aDefMap[aMacroName].m_aLoc);
return;
}
}
void DuplicateDefines::MacroUndefined(const Token& rMacroNameTok, const MacroDefinition& /*MD*/,
const MacroDirective* /*Undef*/)
{
auto aLoc = rMacroNameTok.getLocation();
if (ignoreLocation(aLoc))
return;
std::string aMacroName = m_rPP.getSpelling(rMacroNameTok);
m_aDefMap.erase(aMacroName);
}
loplugin::Plugin::Registration<DuplicateDefines> X("duplicatedefines", false);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
