blob: b15a1c28a06b260cb5924395a2263c4a3c11597b (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <string>
#include "plugin.hxx"
// Having an extern prototype for a method in a module and not actually declaring that method is dodgy.
//
namespace {
class ExternAndNotDefined:
public RecursiveASTVisitor<ExternAndNotDefined>, public loplugin::Plugin
{
public:
explicit ExternAndNotDefined(InstantiationData const & data): Plugin(data) {}
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitFunctionDecl(const FunctionDecl * decl);
};
bool ExternAndNotDefined::VisitFunctionDecl(const FunctionDecl * functionDecl) {
if (ignoreLocation(functionDecl)) {
return true;
}
if (functionDecl->isDefined() || functionDecl->isPure()
|| (functionDecl->getLinkageAndVisibility().getLinkage()
!= ExternalLinkage)) {
return true;
}
//TODO, filtering out anything template for now:
if (functionDecl->isDependentContext()) {
return true;
}
CXXRecordDecl const * r = dyn_cast<CXXRecordDecl>(functionDecl->getDeclContext());
if (r != nullptr && r->getTemplateSpecializationKind() != TSK_Undeclared) {
return true;
}
// this is the bison/flex C API, it has to be defined this way
std::string functionName = functionDecl->getNameAsString();
if (functionName == "yyerror" || functionName == "YYWarning" || functionName == "yyparse" || functionName == "yylex") {
return true;
}
// see vcl/unx/gtk/app/gtksys.cxx, typename conflicts prevent using the right include
if (functionName == "gdk_x11_screen_get_screen_number") {
return true;
}
if (!compiler.getSourceManager().isInMainFile(functionDecl->getLocation()))
{
return true;
}
StringRef fileName { compiler.getSourceManager().getFilename(functionDecl->getLocation()) };
// the filters use some kind of dynamic loading stunt
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/filter/qa/")) {
return true;
}
report(
DiagnosticsEngine::Warning,
"extern prototype in main file without definition",
functionDecl->getLocation())
<< functionDecl->getSourceRange();
return true;
}
loplugin::Plugin::Registration< ExternAndNotDefined > X("externandnotdefined");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
