1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include "plugin.hxx"
#include "check.hxx"
#include "compat.hxx"
#include <iostream>
/**
TODO multiplying/otherop on a combination of a float and int, and then truncating to int. like this:
float getRotation() {}
int moRotation = -F_PI180 * 90 * getRotation();
*/
namespace
{
class IntVsFloat : public loplugin::FilteringPlugin<IntVsFloat>
{
public:
explicit IntVsFloat(loplugin::InstantiationData const& data)
: loplugin::FilteringPlugin<IntVsFloat>(data)
{
}
void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitVarDecl(VarDecl const*);
bool VisitBinaryOperator(BinaryOperator const*);
private:
compat::optional<double> getExprValue(Expr const* expr);
};
bool IntVsFloat::VisitVarDecl(VarDecl const* varDecl)
{
if (ignoreLocation(varDecl->getLocation()))
return true;
auto init = varDecl->getInit();
if (!init)
return true;
init = init->IgnoreImpCasts();
if (varDecl->getType()->isFloatingType())
return true;
// init->dump();
compat::optional<double> d = getExprValue(init);
if (!d)
return true;
if (static_cast<long>(*d) == *d)
return true;
report(DiagnosticsEngine::Warning, "assigning constant float value to int truncates data",
init->getBeginLoc())
<< init->getSourceRange();
return true;
}
bool IntVsFloat::VisitBinaryOperator(BinaryOperator const* op)
{
if (op->getOpcode() != BO_EQ)
{
return true;
}
if (ignoreLocation(op->getBeginLoc()))
return true;
auto lhs = op->getLHS()->IgnoreImpCasts();
auto rhs = op->getRHS()->IgnoreImpCasts();
if (!lhs->getType()->isFloatingType())
std::swap(lhs, rhs);
if (!lhs->getType()->isFloatingType())
return true;
if (rhs->getType()->isFloatingType())
return true;
compat::optional<double> d = getExprValue(lhs);
if (!d)
return true;
if (static_cast<long>(*d) == *d)
return true;
report(DiagnosticsEngine::Warning, "comparing integer to float constant, can never be true",
op->getBeginLoc())
<< op->getSourceRange();
return true;
}
compat::optional<double> IntVsFloat::getExprValue(Expr const* expr)
{
// Of the available clang Evaluate* APIs, this is the __only__ one that produces useful output
// (as of 17 Aug 2018 checkout of clang, ie. towards clang 7)
if (expr->isValueDependent())
return compat::optional<double>();
Expr::EvalResult evalResult;
if (!expr->EvaluateAsRValue(evalResult, compiler.getASTContext()))
return compat::optional<double>();
if (!evalResult.Val.isFloat())
return compat::optional<double>();
llvm::APFloat floatResult = evalResult.Val.getFloat();
bool losesInfo;
floatResult.convert(APFloat::IEEEdouble(), APFloat::rmNearestTiesToEven, &losesInfo);
double d = floatResult.convertToDouble();
return d;
}
loplugin::Plugin::Registration<IntVsFloat> intvsfloat("intvsfloat");
} // namespace
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
