blob: 4c414821000454247a23835222e7606828b22e92 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <string>
#include <iostream>
#include "plugin.hxx"
#include "clang/AST/CXXInheritance.h"
// Check that we're not unnecessarily copying variables in a range based for loop
// e.g. "for (OUString a: aList)" results in a copy of each string being made,
// whereas "for (const OUString& a: aList)" does not.
namespace
{
class RangedForCopy:
public RecursiveASTVisitor<RangedForCopy>, public loplugin::Plugin
{
public:
explicit RangedForCopy(InstantiationData const & data): Plugin(data) {}
virtual void run() override {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitCXXForRangeStmt( const CXXForRangeStmt* stmt );
};
bool RangedForCopy::VisitCXXForRangeStmt( const CXXForRangeStmt* stmt )
{
if (ignoreLocation( stmt ))
return true;
const VarDecl* varDecl = stmt->getLoopVariable();
if (!varDecl)
return true;
const QualType type = varDecl->getType();
if (type->isRecordType() && !type->isReferenceType() && !type->isPointerType())
{
std::string name = type.getAsString();
report(
DiagnosticsEngine::Warning,
"Loop variable passed by value, pass by reference instead, e.g. 'const %0&'",
varDecl->getLocStart())
<< name << varDecl->getSourceRange();
}
return true;
}
loplugin::Plugin::Registration< RangedForCopy > X("rangedforcopy");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
