blob: cde2f80babc5a7748fd0f126b5cfc678968a5ebd (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include "plugin.hxx"
#include "check.hxx"
#include "compat.hxx"
#include <iostream>
namespace
{
class StaticConstField : public loplugin::FilteringPlugin<StaticConstField>
{
public:
explicit StaticConstField(loplugin::InstantiationData const& data)
: loplugin::FilteringPlugin<StaticConstField>(data)
{
}
void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool TraverseConstructorInitializer(CXXCtorInitializer* init);
};
bool StaticConstField::TraverseConstructorInitializer(CXXCtorInitializer* init)
{
if (!init->getSourceLocation().isValid() || ignoreLocation(init->getSourceLocation()))
return true;
if (!init->getMember())
return true;
auto type = init->getMember()->getType();
auto tc = loplugin::TypeCheck(type);
bool found = false;
if (!tc.Const())
return true;
if (tc.Const().Class("OUString").Namespace("rtl").GlobalNamespace()
|| tc.Const().Class("OString").Namespace("rtl").GlobalNamespace())
{
if (auto constructExpr = dyn_cast<CXXConstructExpr>(init->getInit()))
{
if (constructExpr->getNumArgs() >= 1
&& isa<clang::StringLiteral>(constructExpr->getArg(0)))
found = true;
}
}
else if (type->isIntegerType())
{
if (isa<IntegerLiteral>(init->getInit()->IgnoreParenImpCasts()))
found = true;
// isIntegerType includes bool
else if (isa<CXXBoolLiteralExpr>(init->getInit()->IgnoreParenImpCasts()))
found = true;
}
else if (type->isFloatingType())
{
if (isa<FloatingLiteral>(init->getInit()->IgnoreParenImpCasts()))
found = true;
}
else if (type->isEnumeralType())
{
if (auto declRefExpr = dyn_cast<DeclRefExpr>(init->getInit()->IgnoreParenImpCasts()))
{
if (isa<EnumConstantDecl>(declRefExpr->getDecl()))
found = true;
}
}
// If we find more than one non-copy-move constructor, we can't say for sure if a member can be static
// because it could be initialised differently in each constructor.
if (auto cxxRecordDecl = dyn_cast<CXXRecordDecl>(init->getMember()->getParent()))
{
int cnt = 0;
for (auto it = cxxRecordDecl->ctor_begin(); it != cxxRecordDecl->ctor_end(); ++it)
{
if (!it->isCopyOrMoveConstructor())
cnt++;
}
if (cnt > 1)
return true;
}
if (!found)
return true;
std::string fn = handler.getMainFileName();
loplugin::normalizeDotDotInFilePath(fn);
// unusual case where a user constructor sets a field to one value, and a copy constructor sets it to a different value
if (fn == SRCDIR "/sw/source/core/attr/hints.cxx")
return true;
if (fn == SRCDIR "/oox/source/core/contexthandler2.cxx")
return true;
report(DiagnosticsEngine::Warning, "field can be static const", init->getSourceLocation())
<< init->getSourceRange();
report(DiagnosticsEngine::Note, "field here", init->getMember()->getLocation())
<< init->getMember()->getSourceRange();
return true;
}
loplugin::Plugin::Registration<StaticConstField> X("staticconstfield", true);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
