blob: 6dda5d333191f7488df3963ab138cba846e385e3 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <mutex>
static std::mutex gSolarMutex;
class SolarMutexGuard : public std::unique_lock<std::mutex>
{
public:
SolarMutexGuard()
: std::unique_lock<std::mutex>(gSolarMutex)
{
}
};
namespace test1
{
struct Foo
{
int m_foo;
// expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
int bar1()
{
SolarMutexGuard guard;
return 1;
}
// no warning expected
int bar2()
{
SolarMutexGuard guard;
return m_foo;
}
};
}
namespace test2
{
struct Foo
{
std::mutex m_aMutex;
int m_foo;
// expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
int bar1()
{
std::unique_lock guard(m_aMutex);
return 1;
}
// expected-error@+1 {{unnecessary locking [loplugin:unnecessarylocking]}}
int bar2()
{
std::scoped_lock guard(m_aMutex);
return 1;
}
// no warning expected
int bar3()
{
std::scoped_lock guard(m_aMutex);
return m_foo;
}
};
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
