1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <sal/config.h>
#include <config_clang.h>
#include <o3tl/typed_flags_set.hxx>
struct Base
{
virtual ~Base();
virtual void f();
void variadic(int, ...);
void cv() const volatile;
void ref();
static void staticFn();
void defaults(void* = nullptr, int = 0, double = 1, Base const& = {}, char const* = "foo");
};
struct SimpleDerived : Base
{
void
f() override // expected-error {{public virtual function just calls public parent [loplugin:unnecessaryoverride]}}
{
Base::f();
}
};
struct Intermediate1 : Base
{
};
struct MultiFunctionIntermediate2 : Base
{
void f() override;
};
struct MultiFunctionDerived : Intermediate1, MultiFunctionIntermediate2
{
void f() override { Intermediate1::f(); } // no warning
};
struct MultiClassIntermediate2 : Base
{
};
struct MultiClassDerived : Intermediate1, MultiClassIntermediate2
{
void f() override { Intermediate1::f(); } // no warning
};
struct DerivedDifferent : Base
{
void variadic(int x) { Base::variadic(x); } // no warning
void cv() { Base::cv(); } // no warning
void ref() && { Base::ref(); } // no warning
void staticFn() { Base::staticFn(); } // no warning
void defaults(void* x1, int x2, double x3, Base const& x4, char const* x5)
{
Base::defaults(x1, x2, x3, x4, x5); // no warning
}
};
struct DerivedSame : Base
{
#if CLANG_VERSION >= 30900 // cf. corresponding condition in Plugin::checkIdenticalDefaultArguments
void
defaults( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
void* x1 = 0, int x2 = (1 - 1), double x3 = 1.0, Base const& x4 = (Base()),
char const* x5 = "f"
"oo")
{
Base::defaults(x1, x2, x3, x4, x5);
}
#endif
};
struct DerivedSlightlyDifferent : Base
{
void defaults( // no warning
void* x1 = nullptr, int x2 = 0, double x3 = 1, Base const& x4 = DerivedSlightlyDifferent(),
char const* x5 = "foo")
{
Base::defaults(x1, x2, x3, x4, x5);
}
};
enum class E
{
E1 = 1,
E2 = 2,
E3 = 4
};
namespace o3tl
{
template <> struct typed_flags<E> : is_typed_flags<E, 7>
{
};
}
struct Base2
{
void default1(Base const& = SimpleDerived());
void default2(Base const& = SimpleDerived());
void default3(Base = Base());
void default4(E = (E::E1 | E::E2 | E::E3));
};
struct Derived2 : Base2
{
void default1(Base const& x = Intermediate1()) { Base2::default1(x); } // no warning
void
default2( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
Base const& x = SimpleDerived())
{
Base2::default2(x);
}
void
default3( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
Base x = Base())
{
(Base2::default3(x));
}
void
default4( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
E x = (E::E1 | E::E2 | E::E3))
{
Base2::default4(x);
}
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
