blob: 359231f262e61bbf6d1d33a318813e61eed2fce6 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
// Find (in-)equality comparisons between typeid expressions that can never succeed. For now, just
// detects cases where the two involved types are structurally different, one a pointer type and the
// other a non-pointer type.
#ifndef LO_CLANG_SHARED_PLUGINS
#include "plugin.hxx"
namespace
{
class TypeidComparison final : public loplugin::FilteringPlugin<TypeidComparison>
{
public:
explicit TypeidComparison(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
// For CXXRewrittenBinaryOperator `typeid(...) != typeid(...)`:
bool shouldVisitImplicitCode() const { return true; }
bool preRun() override { return compiler.getLangOpts().CPlusPlus; }
void run() override
{
if (preRun())
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
}
bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const* expr)
{
if (ignoreLocation(expr))
{
return true;
}
auto const op = expr->getOperator();
if (op != OO_EqualEqual && op != OO_ExclaimEqual)
{
return true;
}
assert(expr->getNumArgs() == 2);
auto const e1 = dyn_cast<CXXTypeidExpr>(expr->getArg(0)->IgnoreParenImpCasts());
if (e1 == nullptr)
{
return true;
}
auto const e2 = dyn_cast<CXXTypeidExpr>(expr->getArg(1)->IgnoreParenImpCasts());
if (e2 == nullptr)
{
return true;
}
auto const t1 = getOperandType(e1);
auto const t2 = getOperandType(e2);
if (t1->isPointerType() == t2->isPointerType())
{
return true;
}
report(DiagnosticsEngine::Warning,
"comparison of type info of mixed pointer and non-pointer types %0 and %1 can never "
"succeed",
expr->getExprLoc())
<< t1 << t2 << expr->getSourceRange();
return true;
}
private:
QualType getOperandType(CXXTypeidExpr const* expr)
{
return expr->isTypeOperand() ? expr->getTypeOperand(compiler.getASTContext())
: expr->getExprOperand()->getType();
}
};
static loplugin::Plugin::Registration<TypeidComparison> typeidcomparison("typeidcomparison");
}
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
