blob: 6fdf3b45d94fb9633a3231f85df96209b7b1bd8a (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include "check.hxx"
#include "plugin.hxx"
class UnoAny:
public RecursiveASTVisitor<UnoAny>, public loplugin::Plugin
{
public:
explicit UnoAny(InstantiationData const & data): Plugin(data) {}
void run() override {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const * expr);
};
bool UnoAny::VisitCXXOperatorCallExpr(CXXOperatorCallExpr const * expr)
{
if (ignoreLocation(expr)) {
return true;
}
StringRef aFileName = compiler.getSourceManager().getFilename(compiler.getSourceManager().getSpellingLoc(expr->getLocStart()));
if (aFileName == SRCDIR "/include/com/sun/star/uno/Any.hxx") {
return true;
}
if (expr->getOperator() != OO_Equal) {
return true;
}
if (!loplugin::TypeCheck(expr->getArg(0)->getType()).Class("Any").
Namespace("uno").Namespace("star").Namespace("sun").Namespace("com").GlobalNamespace())
{
return true;
}
if (auto expr2 = dyn_cast<MaterializeTemporaryExpr>(expr->getArg(1))) {
if (auto expr3 = dyn_cast<CXXBindTemporaryExpr>(expr2->GetTemporaryExpr())) {
if (auto expr4 = dyn_cast<CallExpr>(expr3->getSubExpr())) {
if (loplugin::DeclCheck(expr4->getDirectCallee()).Function("makeAny").
Namespace("uno").Namespace("star").Namespace("sun").Namespace("com").GlobalNamespace()) {
report(
DiagnosticsEngine::Warning,
"unnecessary copy, rather use <<= operator",
expr->getOperatorLoc())
<< expr->getSourceRange();
return true;
}
}
}
if (isa<CXXFunctionalCastExpr>(expr2->GetTemporaryExpr())) {
//expr->getArg(1)->dump();
report(
DiagnosticsEngine::Warning,
"unnecessary copy, rather use <<= operator",
expr->getOperatorLoc())
<< expr->getSourceRange();
return true;
}
}
//expr->getArg(1)->dump();
return true;
}
loplugin::Plugin::Registration<UnoAny> X("unoany");
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
