summaryrefslogtreecommitdiff
path: root/fontconfig/Module_fontconfig.mk
blob: 1bfcbdb7878a02b3d7e6a9014dfb909ebeb0a4b5 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#

$(eval $(call gb_Module_Module,fontconfig))

ifeq ($(OS),ANDROID)

$(eval $(call gb_Module_add_targets,fontconfig,\
	ExternalPackage_fontconfig \
	ExternalProject_fontconfig \
	UnpackedTarball_fontconfig \
))

endif

# vim: set noet sw=4 ts=4:
<vmiklos@collabora.com> 2018-11-27Refactor calc non-linear ViewToDevice transformArmin Le Grand This change solves the non-linear World-To-View trans- formation that calc uses due to it's screen rendering as good as currently possible (AFAIK). Calcv view is layouted on pixel base (due to better homogen distances and full pixel lines between cells), but this leads to having a non-linear transformation between discrete units (pixels, view) and model coordinates (World). In principle, each cell has it's own (so called) ViewTransformation -> the position on screen depends on the mappings of all cells top/left from it. This is obvioulsly non-linear and can sometimes be seen by producing 'offset' errors when many cells (small and thin) are shown in low zoom stages. No better solution for this comes to mind easily. The extremes are - on the one hand AntiAliasing the whole calc edit view and accept 'unsharp/AAed' lines - on the other hand what we have now. Maybe a future solution could find a mapping that gets close to linear mapping for the full view. On the long run this state is hard to keep correct. Even with this extended solution the mapping of SdrObjects spawning mutiple cells is assumed 'linear' in that area - which is in reality currently not the case (!) Note: This is only true for the screen visualization, print and/or PDF export do not do that pixel-based layouting. Note2: This mechanism is general in DrawingLayer (look for '.*GridOffset.*'. If it is deactivated by providing no offsets, the result is the unchanged, linear mapping. First step: Add interfaces to get a possible GridOffset at ViewObjectContact. There it belongs, we have a view- dependent offset per object and view. Add mechanisms to create on-demand and reach back to the view (aka calc's derivation of it). Second step: Implement the on-demand creation, adapt to use it in ViewObjectContact::getPrimitive2DSequence, add stuff to reset on zoom change, disable temporarily old mechanism -> paint already works. Need to adapt the places from old mechanism where the GridOffset was used, but no longer the geometry creations. Third step: Isolated and disabled old mechanism (by already removing SetGridOffset). Marked all places that possibly need change with '//Z' tag. Main work now will be to adapt in the SdrView implementations in svx to know about having a SdrObject-dependent ViewTransformation at all (currently not known, was hard-coded at some places from the old code, ViewTransformation set as MapMode at a target OutputDevice, not member at SdrView at all...). Fourth step: Adapt the Handles and OverlayObjects to use an evtl. existing GridOffset. The mechanism is that the SdrHdl(s) can be seen as 'Model-Objects', these get converted to OverlayObjects in the ::CreateB2dIAObject() implementations, for all SdrMarkView and SdrPageView, so this is the place where the ObjectContact is known (the SdrPageWindow *is* a ObjectContact) and the view- dependent GridOffset can be calculated per SdrObject. I modified OverlayObject to be able to work with a set Offset that embeds the created visualization using this additionally. Handles get now correctly set and have a working HitTest (due to that already using the primitives). Some inter- action stuff already working, some will need more adaption. We simply have no concept for this stuff... Refactored to not get dependencies to SdrObject in ObjectContact. Fifth Step: Make HitTest work by adding the View-And- Object dependent GridOffset in the View when HitTest is triggered. This is in SdrMarkView::CheckSingleSdrObjectHit where pObj->GetCurrentBoundRect() is used that gets the view-independent form. To make HitTest work, add a possible GridOffset. Since this will be necessary more often in SdrView hierarchy, added a tooling method (getPossibleGridOffsetForSdrObject) at that level after checking that at that level will be reachable at all potential spots. Inside that method the correct ObjectContact will be identified and the object-specific offset requested there. Sixth Step: Adaptions and started some cleanups. Still some adaptions needed: - After creation of new object, need to relocate from used GridOffset setting to WorldCoordinates - Interactions, e.g. start with dragging handles or full object/points Seventh Step: React on EndCreateObj. Here, the created SdrObject is in model coordinates and needs to be adapted to evtl. GridOffset. This is 'tricky' due to calculating the possible offset based on new coordinates 'close' to the target position, but may be in the wrong cell. Nonetheless this is the best we can do here. Last (hopefully) missing are now all interaction viszualizations. They already work and are applied correctly, but wrong visualized. Have taken the time to unify adding OverlayObjects for selection visualization to OverlayManager, see handleNewOverlayObject. This does all needed when adding OverlayObjects in one place where the GridOffset can also be handled. It makles things more safe - not possible to forget one of the three steps for others. Eighth Step: Do the same unification for creating the OverlayGeometry, also rename methods to make usage more clear. We now have SdrHdl::insertNewlyCreatedOverlayObjectForSdrHdl SdrDragMethod::insertNewlyCreatedOverlayObjectForSdrDragMethod which can do the needed GridOffset changes centralized. Needed to get a ObjectContact for this at SdrDragMethod, so adapted ::CreateOverlayGeometry implementations accordingly. Missing is now the implementation in insertNewlyCreatedOverlayObjectForSdrDragMethod to add the GridOffset - if used. This has no SdrObject at this time, so we will need a fallback to do the same using a Range (Rectangle). The stuff doing this for SdrObject already has a fallback and is based on using the Rectangle from the SdrObject anyways, so this will be possible. Ninth Step: Cleanup of old stuff (no more //Z), adapted some usages of OverlayObject creations to use getViewIndependentPrimitive2DContainer instead of the view dependent parts so that offset applied to drag-overlays is correct and not already added. Adapted insertNewlyCreatedOverlayObjectForSdrDragMethod to use calculateGridOffsetForB2DRange. Use now that instead of SdrObject-based approach in calc - is more generic. Getting closer, but still not complete - there is an error with dragging the grepped handle somehow - the offset for drag is somehow wrong. Tenth Step: Corrected that offset error. Of course at interaction start and progress (move) the coordinates are in GrifOffset coordinates and need to be corrected to Model coordinates. Done that at ::BegDragObj and ::MovDragObj, works well. Of course there are exceptions for the crop-handles, so needed to add setting the correct parameters at SdrHdl when these got created, then all works as expected. The strategy is to *not* change the model data itself in any way, instead do all changes/adaptions in the view-only code. This has minimal impact and is needed due to having a 1:n relationship between model and views anyways. There are two directions: All visualizations are adapted to take the GridOffset into account (SdrObjects, overlay, handles, InteractionObjects, ...). In the other direction input like MousePosition is in principle in calc EditView in 'GridOffset'-coordinates and needs to be mapped back before usage. Change-Id: I2ecdd409def96a7248a26a65a22e59eb962880a0 Reviewed-on: https://gerrit.libreoffice.org/64057 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> 2018-10-15use range based loops over B2DPolyPolygon in svxJochen Nitschke avoid copy when adapting polygon in SdrPathObj::ImpForceKind() Change-Id: Ifd830ecd181563102ee269c6a609ef8ebeab670c Reviewed-on: https://gerrit.libreoffice.org/61767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2018-08-10unnecessary null check before dynamic_cast, in svxNoel Grandin Change-Id: I5174c9530d18e5d88ad8a41cc2bb02c6d090f3cf Reviewed-on: https://gerrit.libreoffice.org/58771 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> 2017-12-29loplugin:passstuffbyref improved return in svxNoel Grandin Change-Id: I33bdbd416709ce46afb3c17aeab0d2e19a68ab30 Reviewed-on: https://gerrit.libreoffice.org/47150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-11-21Avoid bad static type in dynamic_castStephan Bergmann ...when the casted object is already in destruction, beyond the static type stated in the dynamic_cast. Happens e.g. during 'make CppunitTest_sw_ooxmlexport2' (with a backtrace as per below). With <https://reviews.llvm.org/D40295> "-fsanitize=vptr warnings on bad static types in dynamic_cast and typeid" this will be found by Clang's -fsanitize=vptr. (On macOS with Apple's libcxxabi with _LIBCXX_DYNAMIC_FALLBACK enabled, this caused---somewhat misleading---messages like > dynamic_cast error 2: One or more of the following type_info's has hidden visibility. They should all have public visibility. 7SdrView, 12SdrPaintView, 10FmFormView. in /var/log/system.log during e.g. 'make CppunitTest_sw_ooxmlexport2', where libcxxabi's __dynamic_cast does not expect to be called with such invalid data.) > #0: libsystem_asl.dylib`syslog > #1: libc++abi.dylib`__dynamic_cast + 339 > #2: libsvxcorelo.dylib`SdrPageWindow::~SdrPageWindow(this=0x00000001b3a86aa0) + 289 at svx/source/svdraw/sdrpagewindow.cxx:139 > #3: libsvxcorelo.dylib`SdrPageWindow::~SdrPageWindow(this=0x00000001b3a86aa0) + 21 at svx/source/svdraw/sdrpagewindow.cxx:130 > #4: libsvxcorelo.dylib`SdrPageView::ClearPageWindows(this=0x0000000208635180) + 543 at svx/source/svdraw/svdpagv.cxx:112 > #5: libsvxcorelo.dylib`SdrPageView::~SdrPageView(this=0x0000000208635180) + 25 at svx/source/svdraw/svdpagv.cxx:167 > #6: libsvxcorelo.dylib`SdrPageView::~SdrPageView(this=0x0000000208635180) + 21 at svx/source/svdraw/svdpagv.cxx:164 > #7: libsvxcorelo.dylib`SdrPaintView::ClearPageView(this=0x0000000101112000) + 81 at svx/source/svdraw/svdpntv.cxx:401 > #8: libsvxcorelo.dylib`SdrPaintView::~SdrPaintView(this=0x0000000101112000) + 514 at svx/source/svdraw/svdpntv.cxx:213 > #9: libsvxcorelo.dylib`SdrSnapView::~SdrSnapView(this=0x0000000101112000) + 135 at svx/source/svdraw/svdsnpv.cxx:199 > #10: libsvxcorelo.dylib`SdrMarkView::~SdrMarkView(this=0x0000000101112000) + 149 at svx/source/svdraw/svdmrkv.cxx:165 > #11: libsvxcorelo.dylib`SdrEditView::~SdrEditView(this=0x0000000101112000) + 21 at svx/source/svdraw/svdedtv.cxx:99 > #12: libsvxcorelo.dylib`SdrPolyEditView::~SdrPolyEditView(this=0x0000000101112000) + 49 at svx/source/svdraw/svdpoev.cxx:55 > #13: libsvxcorelo.dylib`SdrGlueEditView::~SdrGlueEditView(this=0x0000000101112000) + 21 at svx/source/svdraw/svdglev.cxx:40 > #14: libsvxcorelo.dylib`SdrObjEditView::~SdrObjEditView(this=0x0000000101112000) + 673 at svx/source/svdraw/svdedxv.cxx:106 > #15: libsvxcorelo.dylib`SdrExchangeView::~SdrExchangeView(this=0x0000000101112000) + 21 at include/svx/svdxcgv.hxx:28 > #16: libsvxcorelo.dylib`SdrDragView::~SdrDragView(this=0x0000000101112000) + 139 at svx/source/svdraw/svddrgv.cxx:84 > #17: libsvxcorelo.dylib`SdrCreateView::~SdrCreateView(this=0x0000000101112000) + 179 at svx/source/svdraw/svdcrtv.cxx:213 > #18: libsvxcorelo.dylib`SdrView::~SdrView(this=0x0000000101112000) + 172 at svx/source/svdraw/svdview.cxx:164 > #19: libsvxcorelo.dylib`E3dView::~E3dView(this=0x0000000101112000) + 21 at svx/source/engine3d/view3d.cxx:1500 > #20: libsvxcorelo.dylib`FmFormView::~FmFormView(this=0x0000000101112000) + 269 at svx/source/form/fmview.cxx:139 > #21: libsvxcorelo.dylib`FmFormView::~FmFormView(this=0x0000000101112000) + 21 at svx/source/form/fmview.cxx:134 > #22: libsvxcorelo.dylib`FmFormView::~FmFormView(this=0x0000000101112000) + 25 at svx/source/form/fmview.cxx:134 > #23: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::default_delete<FmFormView>::operator(this=0x00007ffeefbe3650, __ptr=0x0000000101112000)(FmFormView*) const + 6894 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2397 > #24: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::unique_ptr<FmFormView, std::__1::default_delete<FmFormView> >::reset(this=0x00007ffeefbe3650, __p=0x0000000000000000) + 125 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2603 > #25: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::unique_ptr<FmFormView, std::__1::default_delete<FmFormView> >::~unique_ptr(this=0x00007ffeefbe3650) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2571 > #26: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::unique_ptr<FmFormView, std::__1::default_delete<FmFormView> >::~unique_ptr(this=0x00007ffeefbe3650) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2571 > #27: libsclo.dylib`ScPrintFunc::DrawToDev(pDoc=0x0000000102b34460, pDev=0x0000000208603810, (null)=1, rBound=0x00007ffeefbe38e8, pViewData=0x00007ffeefbe3928, bMetaFile=true) + 6729 at sc/source/ui/view/printfun.cxx:601 > #28: libsclo.dylib`ScDocShell::Draw(this=0x0000000102b34400, pDev=0x0000000208603810, (null)=0x00007ffeefbe4068, nAspect=1) + 631 at sc/source/ui/docshell/docsh4.cxx:2007 > #29: libsfxlo.dylib`SfxObjectShell::DoDraw_Impl(this=0x0000000102b34400, pDev=0x0000000208603810, rViewPos=0x00007ffeefbe4070, rScaleX=0x00007ffeefbe3eb0, rScaleY=0x00007ffeefbe3ea8, rSetup=0x00007ffeefbe4068, nAspect=1) + 1314 at sfx2/source/doc/objembed.cxx:231 > #30: libsfxlo.dylib`SfxObjectShell::DoDraw(this=0x0000000102b34400, pDev=0x0000000208603810, rObjPos=0x00007ffeefbe4070, rSize=0x00007ffeefbe4118, rSetup=0x00007ffeefbe4068, nAspect=1) + 578 at sfx2/source/doc/objembed.cxx:178 > #31: libsfxlo.dylib`SfxObjectShell::CreatePreviewMetaFile_Impl(this=0x0000000102b34400, bFullContent=true) const + 1666 at sfx2/source/doc/objcont.cxx:169 > #32: libsfxlo.dylib`SfxObjectShell::GetPreviewMetaFile(this=0x0000000102b34400, bFullContent=true) const + 43 at sfx2/source/doc/objcont.cxx:116 > #33: libsfxlo.dylib`SfxBaseModel::getTransferData(this=0x0000000152f7d228, aFlavor=0x00007ffeefbe4c40) + 2917 at sfx2/source/doc/sfxbasemodel.cxx:1933 > #34: libsfxlo.dylib`SfxBaseModel::getPreferredVisualRepresentation(this=0x0000000152f7d228, (null)=1) + 245 at sfx2/source/doc/sfxbasemodel.cxx:3544 > #35: libsfxlo.dylib`non-virtual thunk to SfxBaseModel::getPreferredVisualRepresentation(this=0x0000000152f7d228, (null)=1) + 54 at sfx2/source/doc/sfxbasemodel.cxx:0 > #36: libembobj.dylib`OCommonEmbeddedObject::getPreferredVisualRepresentation(this=0x0000000152f7db28, nAspect=1) + 1775 at embeddedobj/source/commonembedding/visobj.cxx:185 > #37: libcomphelper.dylib`comphelper::EmbeddedObjectContainer::GetGraphicReplacementStream(nViewAspect=1, xObj=0x0000000208630470, pMediaType=0x0000000208630488) + 147 at comphelper/source/container/embeddedobjectcontainer.cxx:1504 > #38: libsvtlo.dylib`svt::EmbeddedObjectRef::GetGraphicReplacementStream(nViewAspect=1, xObj=0x0000000208630470, pMediaType=0x0000000208630488) + 44 at svtools/source/misc/embedhlp.cxx:777 > #39: libsvtlo.dylib`svt::EmbeddedObjectRef::GetGraphicStream(this=0x0000000208643c58, bUpdate=true) const + 3482 at svtools/source/misc/embedhlp.cxx:601 > #40: libsvtlo.dylib`svt::EmbeddedObjectRef::GetReplacement(this=0x0000000208643c58, bUpdate=true) + 1501 at svtools/source/misc/embedhlp.cxx:419 > #41: libsvtlo.dylib`svt::EmbeddedObjectRef::UpdateReplacement(this=0x0000000208643c58) + 26 at svtools/source/misc/embedhlp.cxx:808 > #42: libsvtlo.dylib`svt::EmbedEventListener_Impl::modified(this=0x0000000150a04d28, (null)=0x00007ffeefbe5d10) + 211 at svtools/source/misc/embedhlp.cxx:170 > #43: libsvtlo.dylib`non-virtual thunk to svt::EmbedEventListener_Impl::modified(this=0x0000000150a04d28, (null)=0x00007ffeefbe5d10) + 44 at svtools/source/misc/embedhlp.cxx:0 > #44: libsfxlo.dylib`cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::util::XModifyListener, com::sun::star::lang::EventObject>::operator(this=0x00007ffeefbe5c50, listener=0x00007ffeefbe5bc0)(com::sun::star::uno::Reference<com::sun::star::util::XModifyListener> const&) const + 126 at include/cppuhelper/interfacecontainer.h:274 > #45: libsfxlo.dylib`void cppu::OInterfaceContainerHelper::forEach<com::sun::star::util::XModifyListener, cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::util::XModifyListener, com::sun::star::lang::EventObject> >(this=0x00000001eec5fcc8, func=0x00007ffeefbe5c50) + 163 at include/cppuhelper/interfacecontainer.h:287 > #46: libsfxlo.dylib`void cppu::OInterfaceContainerHelper::notifyEach<com::sun::star::util::XModifyListener, com::sun::star::lang::EventObject>(this=0x00000001eec5fcc8, NotificationMethod=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, Event=0x00007ffeefbe5d10)(com::sun::star::lang::EventObject const&), com::sun::star::lang::EventObject const&) + 126 at include/cppuhelper/interfacecontainer.h:300 > #47: libsfxlo.dylib`SfxBaseModel::NotifyModifyListeners_Impl(this=0x0000000152f7d228) const + 258 at sfx2/source/doc/sfxbasemodel.cxx:2747 > #48: libsfxlo.dylib`SfxBaseModel::changing(this=0x0000000152f7d228) + 262 at sfx2/source/doc/sfxbasemodel.cxx:2763 > #49: libsfxlo.dylib`SfxBaseModel::Notify(this=0x0000000152f7d228, rBC=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 261 at sfx2/source/doc/sfxbasemodel.cxx:2651 > #50: libsclo.dylib`ScModelObj::Notify(this=0x0000000152f7d228, rBC=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 573 at sc/source/ui/unoobj/docuno.cxx:1312 > #51: libsclo.dylib`non-virtual thunk to ScModelObj::Notify(this=0x0000000152f7d228, rBC=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 55 at sc/source/ui/unoobj/docuno.cxx:0 > #52: libsvllo.dylib`SfxBroadcaster::Broadcast(this=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 211 at svl/source/notify/SfxBroadcaster.cxx:49 > #53: libsclo.dylib`ScDocShell::SetModified(this=0x0000000102b34400, bModified=true) + 112 at sc/source/ui/docshell/docsh.cxx:2789 > #54: libsclo.dylib`ScDocShell::SetDrawModified(this=0x0000000102b34400) + 63 at sc/source/ui/docshell/docsh.cxx:2855 > #55: libsclo.dylib`ScDocShell::SetDocumentModified(this=0x0000000102b34400) + 337 at sc/source/ui/docshell/docsh.cxx:2811 > #56: libsclo.dylib`ScDocShell::UnlockPaint_Impl(this=0x0000000102b34400, bDoc=false) + 747 at sc/source/ui/docshell/docsh3.cxx:265 > #57: libsclo.dylib`ScDocShell::UnlockPaint(this=0x0000000102b34400) + 23 at sc/source/ui/docshell/docsh3.cxx:322 > #58: libsclo.dylib`ScModelObj::unlockControllers(this=0x0000000152f7d228) + 137 at sc/source/ui/unoobj/docuno.cxx:2111 > #59: libsclo.dylib`non-virtual thunk to ScModelObj::unlockControllers(this=0x0000000152f7d228) + 28 at sc/source/ui/unoobj/docuno.cxx:0 > #60: libooxlo.dylib`oox::core::FilterBase::filter(this=0x000000015317b5b0, rMediaDescSeq=0x00007ffeefbe6d90) + 2756 at oox/source/core/filterbase.cxx:499 > #61: libscfiltlo.dylib`oox::xls::ExcelFilter::filter(this=0x000000015317b5b0, rDescriptor=0x00007ffeefbe6d90) + 64 at sc/source/filter/oox/excelfilter.cxx:154 > #62: libscfiltlo.dylib`non-virtual thunk to oox::xls::ExcelFilter::filter(this=0x000000015317b5b0, rDescriptor=0x00007ffeefbe6d90) + 44 at sc/source/filter/oox/excelfilter.cxx:0 > #63: libwriterfilterlo.dylib`writerfilter::dmapper::OLEHandler::importStream(this=0x00000001ef171f80, xComponentContext=0x0000000102ad0830, xTextDocument=0x0000000102ad0818, xOLE=0x00007ffeefbe7378) + 2778 at writerfilter/source/dmapper/OLEHandler.cxx:221 > #64: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper_Impl::appendOLE(this=0x0000000102ad0800, rStreamName=0x00007ffeefbeaad0, pOLEHandler=std::__1::shared_ptr<writerfilter::dmapper::OLEHandler>::element_type @ 0x00000001ef171f80 strong=1 weak=1) + 4050 at writerfilter/source/dmapper/DomainMapper_Impl.cxx:1504 > #65: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper::sprmWithProps(this=0x00000001ef10bd30, rSprm=0x00000001ef139eb0, rContext=std::__1::shared_ptr<writerfilter::dmapper::PropertyMap>::element_type @ 0x00000001ef164750 strong=2 weak=1) + 50245 at writerfilter/source/dmapper/DomainMapper.cxx:2432 > #66: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper::lcl_sprm(this=0x00000001ef10bd30, rSprm=0x00000001ef139eb0) + 212 at writerfilter/source/dmapper/DomainMapper.cxx:1164 > #67: libwriterfilterlo.dylib`writerfilter::LoggedProperties::sprm(this=0x00000001ef10bd30, rSprm=0x00000001ef139eb0) + 688 at writerfilter/source/dmapper/LoggedResources.cxx:366 > #68: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLProperty::resolve(this=0x00000001ef139eb0, rProperties=0x00000001ef10bd30) + 147 at writerfilter/source/ooxml/OOXMLPropertySet.cxx:118 > #69: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLPropertySet::resolve(this=0x00000001ef16b130, rHandler=0x00000001ef10bd30) + 273 at writerfilter/source/ooxml/OOXMLPropertySet.cxx:351 > #70: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper::lcl_props(this=0x00000001ef10bd30, ref=<unavailable>) + 46 at writerfilter/source/dmapper/DomainMapper.cxx:3477 > #71: libwriterfilterlo.dylib`non-virtual thunk to writerfilter::dmapper::DomainMapper::lcl_props(this=0x00000001ef10bd30, ref=<unavailable>) + 25 at writerfilter/source/dmapper/DomainMapper.cxx:0 > #72: libwriterfilterlo.dylib`writerfilter::LoggedStream::props(this=0x00000001ef10bd30, ref=std::__1::shared_ptr<writerfilter::Reference<writerfilter::Properties> >::element_type @ 0x00000001ef16b130 strong=3 weak=1) + 396 at writerfilter/source/dmapper/LoggedResources.cxx:255 > #73: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandler::sendPropertiesWithId(this=0x00000001c6ae9190, nId=90005) + 534 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:733 > #74: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFactory_wml::endAction(this=0x000000015401b540, pHandler=0x00000001c6ae9190) + 1915 at workdir/CustomTarget/writerfilter/source/ooxml/OOXMLFactory_wml.cxx:7295 > #75: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFactory::endAction(pHandler=0x00000001c6ae9190) + 103 at writerfilter/source/ooxml/OOXMLFactory.cxx:190 > #76: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandler::endAction(this=0x00000001c6ae9190) + 21 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:269 > #77: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandlerProperties::lcl_endFastElement(this=0x00000001c6ae9190, (null)=921159) + 51 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:980 > #78: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandlerShape::lcl_endFastElement(this=0x00000001c6ae9190, Element=921159) + 113 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1693 > #79: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(this=0x00000001c6ae9190, Element=921159) + 888 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:175 > #80: libwriterfilterlo.dylib`non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(this=0x00000001c6ae9190, Element=921159) + 31 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:0 > #81: libexpwraplo.dylib`(anonymous namespace)::Entity::endElement(this=0x00000001049a4e00) + 362 at sax/source/fastparser/fastparser.cxx:500 > #82: libexpwraplo.dylib`sax_fastparser::FastSaxParserImpl::callbackEndElement(this=0x00000001dcee9480) + 744 at sax/source/fastparser/fastparser.cxx:1237 > #83: libexpwraplo.dylib`(anonymous namespace)::call_callbackEndElement(userData=0x00000001dcee9480, (null)="object", (null)="w", (null)="http://schemas.openxmlformats.org/wordprocessingml/2006/main") + 41 at sax/source/fastparser/fastparser.cxx:311 > #84: libxml2.2.dylib`xmlParseEndTag2 + 893 > #85: libxml2.2.dylib`xmlParseTryOrFinish + 3522 > #86: libxml2.2.dylib`xmlParseChunk + 1068 > #87: libexpwraplo.dylib`sax_fastparser::FastSaxParserImpl::parse(this=0x00000001dcee9480) + 300 at sax/source/fastparser/fastparser.cxx:1027 > #88: libexpwraplo.dylib`sax_fastparser::FastSaxParserImpl::parseStream(this=0x00000001dcee9480, maStructSource=0x00007ffeefbeda50) + 4739 at sax/source/fastparser/fastparser.cxx:825 > #89: libexpwraplo.dylib`sax_fastparser::FastSaxParser::parseStream(this=0x00000001ef4bd178, aInputSource=0x00007ffeefbeda50) + 60 at sax/source/fastparser/fastparser.cxx:1308 > #90: libexpwraplo.dylib`non-virtual thunk to sax_fastparser::FastSaxParser::parseStream(this=0x00000001ef4bd178, aInputSource=0x00007ffeefbeda50) + 44 at sax/source/fastparser/fastparser.cxx:0 > #91: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLDocumentImpl::resolve(this=0x00000001dcee9090, rStream=0x00000001ef10bd30) + 2735 at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:490 > #92: libwriterfilterlo.dylib`WriterFilter::filter(this=0x00000001c2a99b08, rDescriptor=0x00007ffeefbeec00) + 3407 at writerfilter/source/filter/WriterFilter.cxx:190 > #93: libwriterfilterlo.dylib`non-virtual thunk to WriterFilter::filter(this=0x00000001c2a99b08, rDescriptor=0x00007ffeefbeec00) + 44 at writerfilter/source/filter/WriterFilter.cxx:0 > #94: libsfxlo.dylib`SfxObjectShell::ImportFrom(this=0x00000001ef5f7550, rMedium=0x00000001ef51d370, xInsertPosition=0x00007ffeefbef328) + 3537 at sfx2/source/doc/objstor.cxx:2217 > #95: libsfxlo.dylib`SfxObjectShell::DoLoad(this=0x00000001ef5f7550, pMed=0x00000001ef51d370) + 5854 at sfx2/source/doc/objstor.cxx:757 > #96: libsfxlo.dylib`SfxBaseModel::load(this=0x00000001ef0eb420, seqArguments=0x00007ffeefbefda0) + 2185 at sfx2/source/doc/sfxbasemodel.cxx:1787 > #97: libsfxlo.dylib`non-virtual thunk to SfxBaseModel::load(this=0x00000001ef0eb420, seqArguments=0x00007ffeefbefda0) + 47 at sfx2/source/doc/sfxbasemodel.cxx:0 > #98: libsfxlo.dylib`(anonymous namespace)::SfxFrameLoader_Impl::load(this=0x0000000150a03f88, rArgs=0x00007ffeefbf0158, _rTargetFrame=0x00007ffeefbf01b0) + 2855 at sfx2/source/view/frmload.cxx:693 > #99: libsfxlo.dylib`non-virtual thunk to (anonymous namespace)::SfxFrameLoader_Impl::load(this=0x0000000150a03f88, rArgs=0x00007ffeefbf0158, _rTargetFrame=0x00007ffeefbf01b0) + 52 at sfx2/source/view/frmload.cxx:0 > #100: libfwklo.dylib`framework::LoadEnv::impl_loadContent(this=0x00007ffeefbf0878) + 4564 at framework/source/loadenv/loadenv.cxx:1098 > #101: libfwklo.dylib`framework::LoadEnv::startLoading(this=0x00007ffeefbf0878) + 860 at framework/source/loadenv/loadenv.cxx:372 > #102: libfwklo.dylib`framework::LoadEnv::loadComponentFromURL(xLoader=0x00007ffeefbf09f0, xContext=0x000000010b9a6198, sURL=0x000000010c9d2430, sTarget=0x00007ffeefbf12a0, nFlags=0, lArgs=0x00007ffeefbf1298) + 292 at framework/source/loadenv/loadenv.cxx:158 > #103: libfwklo.dylib`framework::Desktop::loadComponentFromURL(this=0x000000010b9a6078, sURL=0x000000010c9d2430, sTargetFrameName=0x00007ffeefbf12a0, nSearchFlags=0, lArguments=0x00007ffeefbf1298) + 337 at framework/source/services/desktop.cxx:618 > #104: libfwklo.dylib`non-virtual thunk to framework::Desktop::loadComponentFromURL(this=0x000000010b9a6078, sURL=0x000000010c9d2430, sTargetFrameName=0x00007ffeefbf12a0, nSearchFlags=0, lArguments=0x00007ffeefbf1298) + 75 at framework/source/services/desktop.cxx:0 > #105: libunotest.dylib`unotest::MacrosTest::loadFromDesktop(this=0x000000010c9d23e8, rURL=0x000000010c9d2430, rDocService=0x00007ffeefbf1b00, rExtraArgs=0x00007ffeefbf1af8) + 4485 at unotest/source/cpp/macros_test.cxx:50 > #106: libtest_sw_ooxmlexport2.dylib`SwModelTestBase::reload(this=0x000000010c9d23a0, pFilter="Office Open XML Text", filename="fdo51550.odt", pPassword=0x0000000000000000) + 2004 at sw/qa/extras/inc/swmodeltestbase.hxx:706 > #107: libtest_sw_ooxmlexport2.dylib`SwModelTestBase::executeImportExportImportTest(this=0x000000010c9d23a0, filename="fdo51550.odt", pPassword=0x0000000000000000) + 269 at sw/qa/extras/inc/swmodeltestbase.hxx:243 > #108: libtest_sw_ooxmlexport2.dylib`testFdo51550::Import_Export_Import(this=0x000000010c9d23a0) + 32 at sw/qa/extras/ooxmlexport/ooxmlexport2.cxx:434 > #109: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] decltype(__f=0x000000010c9d2378, __a0=0x000000010c9d2388)).*fp(std::__1::forward<>(fp1))) std::__1::__invoke<void (testFdo51550::*&)(), testFdo51550*&, void>(void (testFdo51550::*&&&)(), testFdo51550*&&&) + 127 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:4232 > #110: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] std::__1::__bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<>, __is_valid_bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (__f=0x000000010c9d2378, __bound_args=0x000000010c9d2388, __args=0x00007ffeefbf1e60)(), std::__1::tuple<testFdo51550*>, 0ul, std::__1::tuple<> >(void (testFdo51550::*&)(), std::__1::tuple<testFdo51550*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) + 48 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:2214 > #111: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] std::__1::__bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<>, __is_valid_bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (this=0x000000010c9d2378)(), testFdo51550*&>::operator()<>() + 35 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:2247 > #112: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] decltype(__f=0x000000010c9d2378)(), testFdo51550*&>&>(fp)(std::__1::forward<>(fp0))) std::__1::__invoke<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) + 23 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:4291 > #113: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (__args=0x000000010c9d2378)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), frame #119: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e46b24d0)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #120: unobootstrapprotector.dylib`(anonymous namespace)::Prot::protect(this=0x00000001003025f0, functor=0x00000001e46b24d0, (null)=0x00007ffeefbf2758) + 33 at unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89 > #121: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e4690140)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #122: unoexceptionprotector.dylib`(anonymous namespace)::Prot::protect(this=0x0000000103000370, functor=0x00000001e4690140, context=0x00007ffeefbf2758) + 79 at unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63 > #123: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e466b8f0)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #124: libcppunit-1.14.0.dylib`CppUnit::DefaultProtector::protect(this=0x0000000100300120, functor=0x00000001e466b8f0, context=0x00007ffeefbf2758) + 79 at workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15 > #125: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e46a78d0)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #126: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::protect(this=0x0000000100304410, functor=0x00007ffeefbf28e8, context=0x00007ffeefbf2758) + 1307 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86 > #127: libcppunit-1.14.0.dylib`CppUnit::TestResult::protect(this=0x00007ffeefbf3a58, functor=0x00007ffeefbf28e8, test=0x000000010c9d2330, shortDescription="") + 110 at workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182 > #128: libcppunit-1.14.0.dylib`CppUnit::TestCase::run(this=0x000000010c9d2330, result=0x00007ffeefbf3a58) + 777 at workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91 > #129: libcppunit-1.14.0.dylib`CppUnit::TestComposite::doRunChildTests(this=0x000000010c9b4bd0, controller=0x00007ffeefbf3a58) + 125 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 > #130: libcppunit-1.14.0.dylib`CppUnit::TestComposite::run(this=0x000000010c9b4bd0, result=0x00007ffeefbf3a58) + 90 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 > #131: libcppunit-1.14.0.dylib`CppUnit::TestComposite::doRunChildTests(this=0x000000010bfa05b0, controller=0x00007ffeefbf3a58) + 125 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 > #132: libcppunit-1.14.0.dylib`CppUnit::TestComposite::run(this=0x000000010bfa05b0, result=0x00007ffeefbf3a58) + 90 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 > #133: libcppunit-1.14.0.dylib`CppUnit::TestRunner::WrappingSuite::run(this=0x000000010bfa0570, result=0x00007ffeefbf3a58) + 78 at workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47 > #134: libcppunit-1.14.0.dylib`CppUnit::TestResult::runTest(this=0x00007ffeefbf3a58, test=0x000000010bfa0570) + 82 at workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149 > #135: libcppunit-1.14.0.dylib`CppUnit::TestRunner::run(this=0x00007ffeefbf3058, controller=0x00007ffeefbf3a58, testPath="") + 126 at workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96 > #136: cppunittester`(anonymous namespace)::ProtectedFixtureFunctor::run(this=0x00007ffeefbf3840) const + 3030 at sal/cppunittester/cppunittester.cxx:319 > #137: cppunittester`sal_main() + 3856 at sal/cppunittester/cppunittester.cxx:469 > #138: cppunittester`main(argc=23, argv=0x00007ffeefbf3b00) + 39 at sal/cppunittester/cppunittester.cxx:376 > #139: libdyld.dylib`start + 1 Change-Id: I332421e1ab4e7cc5937d9d73d3a001c2f6744dcb 2017-10-26vcl: make MapMode constructor explicitMichael Stahl Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988 2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> 2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-07-20Annotate some more Timers and IdlesJan-Marek Glogowski Change-Id: Ic8ca00db385ed59bb16744581f9d7cc0fcbb4f5b Reviewed-on: https://gerrit.libreoffice.org/40188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> 2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> 2017-05-12convert SdrLayerId to strong_intNoel Grandin Also - rename SetOfByte to SdrLayerIDSet - add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't allocate overlapping SdrLayerID values - add a new constant SDRLAYERPOS_NOTFOUND to be returned from SdrLayerAdmin::GetLayerPos Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8 Reviewed-on: https://gerrit.libreoffice.org/37467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-05-05loplugin:checkunusedparams in svx(part3)Noel Grandin Change-Id: I4b9b749565750acc7f674957fd619870b0e29237 Reviewed-on: https://gerrit.libreoffice.org/37240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-04-25lok: When we actually have the OutputDevice, prefer that.Jan Holesovsky Writer invalidation functionality depends on this actually. Change-Id: I0933c56ff3999a09118112ccf49bf00062c42444 Reviewed-on: https://gerrit.libreoffice.org/36914 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/36915 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> 2017-03-31svx: fix missing namespaceMiklos Vajna Change-Id: Ibfd783f42b376952442e017537276a00f4dafc8e 2017-03-31lok sc: Don't depend on the OutputDevice existence when invalidating.Jan Holesovsky We know that the drawinglayer operates in 100th of millimetre, and that we need twips for LOK. Change-Id: I8813f936ab66eaca4d6b9c03341e090d703decb8 2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> 2017-01-25loplugin: unnecessary destructor svxNoel Grandin Change-Id: I7feed30eea4f7367943fa2d6e0d75be5ca209068 Reviewed-on: https://gerrit.libreoffice.org/33516 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> 2016-12-07tdf#91260 svx, sw: don't paint off-page part of drawing objectMichael Stahl Since commit a4dee94afed9ade6ac50237c8d99a6e49d3bebc1 Writer no longer forces drawing objects to be entirely on one page. However since there is only one SdrPage for the entire document, a drawing object dangleing off the bottom of one page will be painted again on the next page, which is clearly undesirable since Word doesn't do that (and it also destroys the nice invariant that a fly on page N never overlaps a fly on page N+1). So force the SdrPageView code to ignore the drawing object on the next page, by passing in the area of the page frame so that ViewObjectContactOfSdrObj::isPrimitiveVisible() can verify that the anchor position of the SdrObject is actually on the painted page. This requires passing in another parameter; in the usual case the DisplayInfo::maRedrawArea already contains the page frame since commit 8af09bf33291df2fb2bfbbd6e42f9bf074fcc4fc, but there are special cases in SwFrame::Retouch() and SwFlyFrameFormat::MakeGraphic() where some sub-area is passed in, which cannot be used to check the anchor. Change-Id: Ia0476216ca41dbdaa3de1063fa18cb94fe2e5ae8 2016-06-06tdf#89329: use unique_ptr for pImpl in sdrpagewindowXisco Fauli Change-Id: I001da407617c5dc992986191e78f2cba403ac161 Reviewed-on: https://gerrit.libreoffice.org/25939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> 2016-02-09Remove excess newlinesChris Sherlock A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> 2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann Change-Id: I71682f28c6a54d33da6b0c971f34d0a705ff04f5 2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin Change-Id: I2f8c9cb71a06f7796576509f605796624e654422 2015-10-01tdf#94559: third step to remove rtti.hxxOliver Specht replaced use of PTR_CAST, IS_TYPE, ISA in oox, reportdesign, svl, svtools, svx, tools Change-Id: I1f85ff92267a0668eba625fa61b4f07feb8f3d4e Reviewed-on: https://gerrit.libreoffice.org/19002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de> 2015-05-26convert INVALIDATE constants to scoped enumNoel Grandin fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d 2015-05-25remove some unnecessary casts and convert some to const_castNoel Grandin Change-Id: I590a87c832bc59947ae04e52d3ac5ea71574bb11 Reviewed-on: https://gerrit.libreoffice.org/15888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> 2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann Change-Id: I76a990da8aba9b62b3925d9632150930656e510f 2015-04-30Get rid of initial :: for the sdr namespaceTor Lillqvist Change-Id: Ibbeb069b6fcb2aa0581429ac5cb6db519548fd00 2014-11-04Remove com::sun::star.Kohei Yoshida Change-Id: Id656f1ef1cdfb695bcfcb35e393def3682e8c556 2014-11-04Remove indirection...Kohei Yoshida Change-Id: Ia01ed40391a4d5725a9f9e22817406216020c0d2 2014-11-04Apply pimpl to SdrPageWindow.Kohei Yoshida Change-Id: I54554a229c03ff87096782344a728a49636c1de1 2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> 2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf 2014-09-30fdo#82577: Handle RegionNoel Grandin Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291 2014-09-23fdo#82577: Handle WindowNoel Grandin Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a 2014-08-22Rectangle coordinates are long, not sal_Int32Stephan Bergmann Change-Id: I2f4bd53bbf94ea439e774ea85e61adcdb920c497 2014-05-06Move headers included only in svx from include/svx/sdr/* to svx/inc/sdr/*Tor Lillqvist Change-Id: I084cbab30dfb0a7d567d1b172a79320687d20a06 2014-02-26Remove visual noise from svxAlexander Wilms Change-Id: I56497d953b0500ba0967fddb36ca8bbbe86c62ad Reviewed-on: https://gerrit.libreoffice.org/8321 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2014-01-28bool improvementsStephan Bergmann Change-Id: Ic32faa81bfbb66a9d8632fb3db187e33c31188ed 2014-01-28coverity#705897 Dereference before null checkCaolán McNamara Change-Id: I947abe661c0e85a65d915422f9d800256167d639 2013-06-29remove OUString wrap for string literalsThomas Arnhold For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>