summaryrefslogtreecommitdiff
path: root/offapi
ModeNameSize
-rw-r--r--Makefile478logplain
-rw-r--r--Module_offapi.mk1000logplain
-rw-r--r--README1008logplain
-rw-r--r--UnoApi_offapi.mk98103logplain
d---------com / sun / star30logplain
d---------org / freedesktop / PackageKit38logplain
d---------type_reference89logplain
d---------util85logplain
generated by cgit (git 2.34.1) at 2025-01-15 13:39:54 +0000
='logheader'>2024-05-28no need to dynamic_cast hereNoel Grandin Change-Id: Ib2e08e58fc2f09161eda0cd32bf7ba2704387070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2023-12-21Remove DeleteItemOnIdlexArmin Le Grand (allotropia) There are some CrashReports in 7.6 which have DeleteItemOnIdle on the stack, but there is nothing reproducable. So I took a look... I first thought it's a MCGR regression, due to classes on the stack. But the Item involved is just random, can happen with any Item. Then I thought it may have to do with ITEM refactorings, but it happens with DeleteItemOnIdle involved, so also not the case. I already saw DeleteItemOnIdle when doing these and qualified as 'hack' in the way. already It is only on Windows and DeleteItemOnIdle is involved. This again (took a deeper look now) is an old hack to keep an SfxPoolItem 'alive' for some 'time'. For that, it triggers an async reschedule which then deletes the Item when being called. If the Item will be used after that is pure coincidence - seems to work in most cases. It seems as if for Windows the timing slightly changed for some scenarios, so a reschedule is too early. This can happen with this hack anytime. DeleteItemOnIdle is used in scenarios where SfxPoolItem* is e.g. returned, but is *not* anchored, so e.g. not member of an SfxItemSet. Or in short: Lifetime is not safe. DeleteItemOnIdle exists since 1st import, but was changed to AsyncEvent ca. 4 months ago (see 57145acf9ec47c23e307b7a5c0029d21d937cc35), so that may have caused it. It is possible that these errors happen on Windows since then. Before something more complicated was used to delete it late, but surely also not really safe. Due to ITEM refactor I have the knowledge/tooling to solve this. It will not be a 1-5 lines fix, but it is a hack and in the way for further ITEM refactor anyways. What we have nowadays is a SfxPoolItemHolder -> it's like an SfxItemSet for a single Item. It safely holds/ controls the lifetime of an SfxPoolItem. It is already used in quite some places. It helps to solve many hacks, also the ones putting Items directly to the Pool - due to there never was an alternative for that. In principle the ItemPool/ItemSet/Item paradigm was never complete without SfxPoolItemHolder. Thus I started to fix that (and remove that hack for good, sooo many changes over the years, sigh), but as said is not straightforward. Will have to change retvals of involved stuff to SfxPoolItemHolder - it's just two pointers and designed to be copied (one is a Pool, needed to cleanup when destructing). CopyConstruct/destroy just counts the RefCnt up/down, so cheap. 1st version compiling, let's check on gerrit... Corrected one error in QueryState for securitypage, also added some security features/asserts. Change-Id: Ida49fd35ca88ead84b11d93e18b978cb9e395090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161083 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> 2023-12-19cid#1557601 COPY_INSTEAD_OF_MOVECaolán McNamara and cid#1546498 COPY_INSTEAD_OF_MOVE cid#1546384 COPY_INSTEAD_OF_MOVE cid#1546376 COPY_INSTEAD_OF_MOVE cid#1546374 COPY_INSTEAD_OF_MOVE cid#1546373 COPY_INSTEAD_OF_MOVE cid#1546368 COPY_INSTEAD_OF_MOVE cid#1546365 COPY_INSTEAD_OF_MOVE cid#1546356 COPY_INSTEAD_OF_MOVE cid#1546340 COPY_INSTEAD_OF_MOVE cid#1546266 COPY_INSTEAD_OF_MOVE cid#1546236 COPY_INSTEAD_OF_MOVE cid#1546188 COPY_INSTEAD_OF_MOVE cid#1546178 COPY_INSTEAD_OF_MOVE cid#1546166 COPY_INSTEAD_OF_MOVE cid#1546156 COPY_INSTEAD_OF_MOVE cid#1546144 COPY_INSTEAD_OF_MOVE cid#1546143 COPY_INSTEAD_OF_MOVE cid#1546100 COPY_INSTEAD_OF_MOVE cid#1546078 COPY_INSTEAD_OF_MOVE cid#1546041 COPY_INSTEAD_OF_MOVE cid#1546036 COPY_INSTEAD_OF_MOVE cid#1546033 COPY_INSTEAD_OF_MOVE Change-Id: Ib3586d93198992e206baf5c2de5a663d5574aa3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> 2023-10-17tdf#144349 related: Make master document navigator track Text contentJim Raykowski Done, with a related patch to make the master document navigator track TOX content, to make the Navigator less likely not to have an item selected, which may be enough to resolve tdf#155741 - Allow insertion of items into master without a selected item Change-Id: I1a9d2a12a01ca2c5f3f162e8da932c04ced9a461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157741 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> 2023-10-17tdf#144349 related: Make master document navigator track TOX contentJim Raykowski Done, with a related patch to make the master document navigator track 'Text' content, to make the Navigator less likely not to have an item selected, which may be enough to resolve tdf#155741 - Allow insertion of items into master without a selected item Change-Id: I6df1b668c502cadbe057229e031ede9aa4f4089a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157695 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> 2023-10-07Master Document Navigator: Improve sensitivity of tool box itemsJim Raykowski Change-Id: I45f16267d7a46aacb5fb5ad4d138a63acfb687c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157579 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> 2023-09-20tdf#139923 Part A: Master Navigator: Fix Insert popup menuJim Raykowski Makes Master Navigator content tree popup menu item 'Insert' submenu items set sensitivity settings work for SalInstanceMenu. GtkInstanceMenu doesn't seem to require additional menu declarations for submenu items to be able to set sensitivity. Change-Id: Ifec28429927591f80859e3b20765c59374a64faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156980 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> 2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> 2023-03-07no need to allocate these separatelyNoel Grandin they are all one or two words in size Change-Id: I9a0f971d72c998c26e567c6abc2f9fe2a734207e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2023-02-17check GetActiveWrtShell() and CheckAndGetWrtShell()Xisco Fauli See https://crashreport.libreoffice.org/stats/signature/SwModule::ApplyItemSet(unsigned%20short,SfxItemSet%20const%20&) Change-Id: I7c719c5fe4cda9f6571592c30f39bd440053dbe9 Change-Id: Iaa4448dccd1a0ec1aefa539e476b5046ed50f7b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2023-02-16SfxViewShell::GetViewFrame never returns null, change to a referenceCaolán McNamara various null checks can be seen to be redundant and removed Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2022-12-20tdf#114441 Convert use of sal_uLong to better integer typesLeonid Ryzhov sw/source/filter/html/parcss1.cxx: all variables are temporary storage for values of type sal_uInt32; sw/source/uibase/uiview/scroll.cxx: nVisSize removed, GetVisibleSize() used as parameter in the setPageSize(); sw/source/uibase/utlui/glbltree.cxx:int is used for nSelCount; int is used for nSource, nDest and nEntryCount; Change-Id: Ifdf4de276306bc3b89f6e1198fe03ec94aefd18e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143746 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> 2022-08-31cid#1500462 Dereference before null checkNoel Grandin appears to be dead code all the way back to commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:15:01 2000 +0000 initial import Change-Id: I591cd51097daa641ccf1f583f7770ade138726ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139096 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-06-21End listening and clear active shell when the dying shell view is theJim Raykowski active shell view Corrects listening not being ended. This patch is based on the code in SwContentTree::Notify to end listening and clear the active shell when the dying shell view is the active shell view. Change-Id: Ic51e8b5355668e3bd133a8370eeb407694cc9e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135034 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> 2022-05-24tdf#149231 Fix crash on print preview of masterJim Raykowski caused by commit 1f9a792a391f0811bbb5f570ad5c84d13312c539. Change-Id: Iecfa019b04b84bb70b5e04af51f9f786d7cd9fdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134846 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> 2022-02-21sw: prefix members of SwGlobalFrameListener_Impl, SwGlobalTree, ...Miklos Vajna ... SwGraphicContent and SwPercentField See tdf#94879 for motivation. Change-Id: Ida015287f722bdec4dbe6c5329d307fa95246583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130234 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins 2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2021-10-10use SfxItemSetFixed in swNoel Grandin Change-Id: I69e188d7599b7fc439f613cec0a0967ccb748b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2021-09-28gives names to all the Idles and TasksNoel Grandin enforce it by making the constructor parameter non-default. Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2021-09-19cid#1492160 Dereference before null checkCaolán McNamara Change-Id: If53b117a69c37907c4d3871eec6c8b3ecfc9c461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2021-09-18tdf#144349 Make Navigator global tree track sub-document sectionsJim Raykowski Master document relies on the Navigator listing all the sub-documents. However there is no connection between the currently selected section (containing the sub-document) and the entry in the Navigator making it very hard to see what file needs to be edited. This patch highlights the corresponding item in the Navigator at the current cursor position in the document. Change-Id: Iee32d1db0e40e302bfff7a879d47a5632ce4ed43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122103 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> 2021-08-24tdf#127978 - Don't URL encode filename for navigator's tooltip (D&D)Andreas Heinisch Change-Id: I3a5d6404755698be81818c4636fcc505992e1a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120936 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> 2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2021-07-19Move svl::Items to include/svl/whichranges.hxx, and unify its usageMike Kaganski ... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed to explicitly use 'value' in WhichRangesContainer's ctor, or create an instance for use in SfxItemSet ctor (svl::Items is already defined as a template value of corresponding type). Instead of WhichRangesContainer Foo(svl::Items<1, 2>::value); SfxItemSet Bar(rItemPool, svl::Items<1, 2>{}); now use: WhichRangesContainer Foo(svl::Items<1, 2>); SfxItemSet Bar(rItemPool, svl::Items<1, 2>); Change-Id: I4681d952b6442732025e5a26768098878907a238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> 2021-07-01tdf#127978 - Don't URL encode filename for navigator's tooltipAndreas Heinisch Change-Id: I70ea7fb739f14c5c60915acc6c66ea241f67524c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118197 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> 2021-05-28no need to allocate these on the heapNoel Grandin Change-Id: I5ed00fe80e96e9d07d56eb7841a66ba98f328a91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2021-04-09Recheck include/ with IWYUGabor Kelemen See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2021-03-29tdf#140556 master document view not launching subdocument from context menuCaolán McNamara Change-Id: I0ae61e51266ae050e340c1af99e0dd6a481e6ff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2021-03-11remove intermediate containers in sidebarsCaolán McNamara tested extension sidebars of: a) Wollmux extension sidebars b) Analog Clock Extension demo https://wiki.openoffice.org/wiki/Sidebar_for_Developers#Example:_Analog_Clock_Extension Change-Id: If9729e20526681928137989f01a8ae733a9b0cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2021-03-09let SwMultiTOXTabDialog have a Widget parent instead of a WindowCaolán McNamara Change-Id: I7a7ae6cd5240257a0f2e33e89d20a1799b29013d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2021-03-05don't use the vcl::Window parent to derive a treeview sizeCaolán McNamara Change-Id: I8076c3db1fd917110445900404b599e821df698d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111997 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2020-11-24tdf#42949 Fix new IWYU warnings in directory swGabor Kelemen Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4bb84c3f401aba8a3dede9cec3a7f2187a2ba02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106473 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2020-10-06loplugin:const* make some params and methods constNoel Change-Id: I3c8ca72b2b41a4f82ee20cbe025b41425f32e715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104028 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2020-07-30loplugin:flatten in sw/uibase/utl..sw/uibase/wrtshNoel Grandin Change-Id: I9010524952ce3b99a62e53dbf715a72c86a89b01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2020-06-20indicate popup menu was shownCaolán McNamara Change-Id: I4d0e8f31fd8c30368497e52c6eb1ba2b7e960bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96773 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> 2020-06-18distinguish active dnd-operation case from simple query caseCaolán McNamara Change-Id: I1d8e95e46b45c71c0c83316ab4f19ba85eddcf75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96598 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>