summaryrefslogtreecommitdiff
path: root/sd/inc/helper
ModeNameSize
-rw-r--r--simplereferencecomponent.hxx3414logplain
cb6b14665c56c07a2f10526329b08c64cbe Reviewed-on: https://gerrit.libreoffice.org/73630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2019-04-14loplugin:sequentialassign in starmath..svlNoel Grandin Change-Id: I95d7b67cd8b6b68c087ff96fdb6bb283ab8b49ec Reviewed-on: https://gerrit.libreoffice.org/70718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-12-14No need to keep these whitelisted functions decorated with SAL_CALLStephan Bergmann The only effect SAL_CALL effectively has on LO-internal code is to change non- static member functions from __thiscall to __cdecl in MSVC (where all other functions are __cdecl by default, anyway). (For 3rd-party code, it could be argued that SAL_CALL is useful on function declarations in the URE stable interface other than non-static member functions, too, in case 3rd-party code uses a compiler switch to change the default calling convention to something other than __cdecl. But loplugin:salcall exempts the URE stable interface, anyway.) One could argue that SAL_CALL, even if today it effectively only affects non- static member functions in MSVC, could be extended in the future to affect more functions on more platforms. However, the current code would already not support that. For example, 3af500580b1c82eabd60335c9ebc458a3f68850c "loplugin:salcall fix functions" changed FrameControl_createInstance in UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even though its address (in ctl_component_getFacrory, in the same file) is passed to cppuhelper::createSingleFactory as an argument of type cppu::ComponentInstantiation, which is a pointer to SAL_CALL function. Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6 Reviewed-on: https://gerrit.libreoffice.org/46436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> 2017-12-11loplugin:salcall fix functionsNoel Grandin since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-10-23loplugin:includeform: svlStephan Bergmann Change-Id: I769b091515d1e6b7d16652d11ff2b94a75584ad0 2017-02-06Add missing #includesStephan Bergmann ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067 2017-01-26Remove dynamic exception specificationsStephan Bergmann ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> 2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann Change-Id: I0f2f81dae91f62639e79799b1bed1b2df1fd79ab 2015-08-18Remove newly unused ucbhelper/fileidentifierconverter.hxxStephan Bergmann Change-Id: I7c272383ecb115e19699ed96bf5622d979403a01 2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann Change-Id: I7e0e4982611d2680d657f99eb2359db1f80e4f96 2014-07-25fdo#39468 Make svl/ German comment cleanPhilipp Weissenbacher I went through all files manually and checked with the tool. Change-Id: I2eba5e61a0814dd88d7c2c001cd85db8032f1b9f Reviewed-on: https://gerrit.libreoffice.org/10545 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> 2014-05-15fix-includes.pl: svlThomas Arnhold Change-Id: I18fb7a677e2bb98c83f43f5af3fa988393dc23f9 2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3 2014-01-28bool improvementsStephan Bergmann Change-Id: I6cf511b92383f3cd60923620518b9233b82850c0 2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f 2013-11-08remove unnecessary use of OUString constructor in SVL moduleNoel Grandin Change-Id: Ib3c2f2b43895fe45e9efff888bbd81d8be5969e4 2013-10-17fdo#54938: Adapt svtools and comphelper module ...Marcos Paulo de Souza to use cppu::supportsService and other pieces. Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826 Signed-off-by: Stephan Bergmann <sbergman@redhat.com> 2013-08-27These shall apparently check for URL scheme prefix matchStephan Bergmann ...they had originally been aURL.equalsIgnoreAsciiCaseAsciiL( "vnd.sun.star.pkg", 16 ) etc., so where likely confused with the OUString compareTo functions that take a maxLength argument. Change-Id: Ie12df4f589dda310b7e49eb93535ad797f88a8a7 2013-07-17fdo#62475 removed pointless commentsJelle van der Waa Change-Id: Id9d579960a9b641b7b2cdf05eabea8bfbfc06bd6 Reviewed-on: https://gerrit.libreoffice.org/4901 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> 2013-06-05fdo#46808, Convert XMultiServiceFactory in svl moduleNoel Grandin Change-Id: Ia51d748af3b29a6021e6f5307a60d87f17917f24 2013-04-10fdo#62096: Replaced some OUString 'compareTo' with '=='Prashant Pandey Change-Id: I1d095cf5640595789f4ae99f1b0679be88b0baa9 2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09 2013-03-19Simplify equalsIgnoreAsciiCaseAscii[L] callsStephan Bergmann Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49 2013-02-20typo: allways -> alwaysAndras Timar Change-Id: I48bd0161dd76c36eeaa39c45e9539584a4ef6841 2013-02-05Better error reportingStephan Bergmann Change-Id: I48bd329e1a29ce9cbf9840bf5e3cb48a92cb8073