Fix ahelps and bookmarks on Add / Edit XForms item pages

- Drop some unneeded ahelps and redundant bookmarks
- Add missing ahelps
- Drop missing UI item description

Change-Id: I70dc32b11e693d8b419937896d88d7feacdc8325
Reviewed-on: https://gerrit.libreoffice.org/73780
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2 files changed, 8 insertions, 15 deletions

diff --git a/source/text/shared/01/xformsdataadd.xhp b/source/text/shared/01/xformsdataadd.xhp
index bd0ea6a8e1..a22eb22bf0 100644
--- a/source/text/shared/01/xformsdataadd.xhp
+++ b/source/text/shared/01/xformsdataadd.xhp
@@ -40,14 +40,12 @@
   <comment>MW added a new entry and deleted "editing;" and "adding;"</comment>
   <paragraph xml-lang="en-US" id="par_idN10547" role="heading" level="1">Add / Edit</paragraph>
   <paragraph xml-lang="en-US" id="par_idN1054B" role="paragraph"><ahelp hid=".">Adds a new item or edits the selected item in the XForms Data Navigator.</ahelp> Items can be elements, attributes, submissions, or bindings.</paragraph>
-  <paragraph xml-lang="en-US" id="par_idN10560" role="paragraph"><ahelp hid=".">%PRODUCTNAME inserts a new item directly after the currently selected item in the Data Navigator. A new attribute is added to the currently selected element.</ahelp></paragraph>
+  <paragraph xml-lang="en-US" id="par_idN10560" role="paragraph">%PRODUCTNAME inserts a new item directly after the currently selected item in the Data Navigator. A new attribute is added to the currently selected element.</paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/name" id="bm_id5775627" localize="false"/>
   <paragraph xml-lang="en-US" id="par_idN10563" role="heading" level="3">Name</paragraph>
   <paragraph xml-lang="en-US" id="par_idN10567" role="paragraph"><ahelp hid=".">Enter the name of the item.</ahelp></paragraph>
   <paragraph xml-lang="en-US" id="par_idN1056A" role="note">The attribute names must be unique within the same group.</paragraph>
-  <paragraph xml-lang="en-US" id="par_idN1056D" role="heading" level="3">Type</paragraph>
-  <paragraph xml-lang="en-US" id="par_idN10571" role="paragraph"><ahelp hid=".">Select the type of a new item. You cannot change the type of an edited item.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/value" id="bm_id9302041" localize="false"/>
   <paragraph xml-lang="en-US" id="par_idN10574" role="heading" level="3">Default value</paragraph>
@@ -61,47 +59,42 @@
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/required" id="bm_id2487258" localize="false"/>
 
-<bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_REQUIRED" id="bm_id1239661" localize="false"/>
   <paragraph xml-lang="en-US" id="par_idN10589" role="heading" level="3">Required</paragraph>
   <paragraph xml-lang="en-US" id="par_idN1058D" role="paragraph"><ahelp hid=".">Specifies if the item must be included on the XForm.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/requiredcond" id="bm_id1404156" localize="false"/>
-  <paragraph xml-lang="en-US" id="par_idN10590" role="paragraph">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter used namespaces and full XPath expressions.</paragraph>
+  <paragraph xml-lang="en-US" id="par_idN10590" role="paragraph"><ahelp hid=".">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter used namespaces and full XPath expressions.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/relevant" id="bm_id8867458" localize="false"/>
 
-<bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_RELEVANT" id="bm_id3679616" localize="false"/>
   <paragraph xml-lang="en-US" id="par_idN105AA" role="heading" level="3">Relevant</paragraph>
   <paragraph xml-lang="en-US" id="par_idN105AE" role="paragraph"><ahelp hid=".">Declares the item as relevant.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/relevantcond" id="bm_id3488570" localize="false"/>
-  <paragraph xml-lang="en-US" id="par_idN105B1" role="paragraph">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter used namespaces and full XPath expressions.</paragraph>
+  <paragraph xml-lang="en-US" id="par_idN105B1" role="paragraph"><ahelp hid=".">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter used namespaces and full XPath expressions.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/constraint" id="bm_id2007812" localize="false"/>
 
-<bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_CONSTRAINT" id="bm_id8594622" localize="false"/>
   <paragraph xml-lang="en-US" id="par_idN105CB" role="heading" level="3">Constraint</paragraph>
   <paragraph xml-lang="en-US" id="par_idN105CF" role="paragraph"><ahelp hid=".">Declares the item as a constraint.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/constraintcond" id="bm_id2240058" localize="false"/>
-  <paragraph xml-lang="en-US" id="par_idN106C7" role="paragraph">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can specify the constraint condition.</paragraph>
+  <paragraph xml-lang="en-US" id="par_idN106C7" role="paragraph"><ahelp hid=".">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can specify the constraint condition.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/readonly" id="bm_id6203192" localize="false"/>
 
-<bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_READONLY" id="bm_id4252449" localize="false"/>
   <paragraph xml-lang="en-US" id="par_idN105E4" role="heading" level="3">Read-only</paragraph>
   <paragraph xml-lang="en-US" id="par_idN105E8" role="paragraph"><ahelp hid=".">Declares the item as read-only.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/readonlycond" id="bm_id165105" localize="false"/>
-  <paragraph xml-lang="en-US" id="par_idN105EB" role="paragraph">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter used namespaces and full XPath expressions.</paragraph>
+  <paragraph xml-lang="en-US" id="par_idN105EB" role="paragraph"><ahelp hid=".">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter used namespaces and full XPath expressions.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/calculate" id="bm_id6361583" localize="false"/>
 
-<bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_CALCULATION" id="bm_id383617" localize="false"/>
-  <paragraph xml-lang="en-US" id="par_idN10605" role="heading" level="3">Calculate / Calculation<comment>UFI: inconsistent use of name</comment></paragraph>
+  <paragraph xml-lang="en-US" id="par_idN10605" role="heading" level="3">Calculate</paragraph>
   <paragraph xml-lang="en-US" id="par_idN10609" role="paragraph"><ahelp hid=".">Declares that the item is calculated.</ahelp></paragraph>
 
 <bookmark xml-lang="en-US" branch="hid/svx/ui/adddataitemdialog/calculatecond" id="bm_id2518997" localize="false"/>
-  <paragraph xml-lang="en-US" id="par_idN1076B" role="paragraph">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter the calculation.</paragraph>
+  <paragraph xml-lang="en-US" id="par_idN1076B" role="paragraph"><ahelp hid=".">The <emph>Condition</emph> button opens the <link href="text/shared/01/xformsdataaddcon.xhp">Add Condition</link> dialog where you can enter the calculation.</ahelp></paragraph>
  </body>
 </helpdocument>
diff --git a/source/text/shared/01/xformsdatatab.xhp b/source/text/shared/01/xformsdatatab.xhp
index 0954bbd80a..9718a620fc 100644
--- a/source/text/shared/01/xformsdatatab.xhp
+++ b/source/text/shared/01/xformsdatatab.xhp
@@ -94,7 +94,7 @@
 <bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_LENGTH" id="bm_id4897915" localize="false"/>
 <paragraph xml-lang="en-US" id="hd_id1614429" role="heading" level="3">Length</paragraph>
       <paragraph xml-lang="en-US" id="par_id1589098" role="paragraph"><ahelp hid=".">Specifies the number of characters for a string.</ahelp></paragraph>
-<!-- removed HID 38008 --><comment>UFI: found 37998 which is already in use</comment>
+<bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_MIN_LENGTH" id="bm_id3908809" localize="false"/>
 <paragraph xml-lang="en-US" id="hd_id1278420" role="heading" level="3">Length (at least)</paragraph>
       <paragraph xml-lang="en-US" id="par_id8746910" role="paragraph"><ahelp hid=".">Specifies the minimum number of characters for a string.</ahelp></paragraph>
 <bookmark xml-lang="en-US" branch="hid/EXTENSIONS_HID_PROP_XSD_MAX_LENGTH" id="bm_id3908810" localize="false"/>