aboutsummaryrefslogtreecommitdiff
path: root/source/as/editeng
diff options
context:
space:
mode:
authorAndras Timar <atimar@suse.com>2013-05-25 20:03:16 +0200
committerAndras Timar <atimar@suse.com>2013-05-25 21:06:48 +0200
commit7db61e0f23b962f97e9246e0a8fb60e47fff0ac9 (patch)
tree909b091e57c275100a8792591c22fa92e5bdab44 /source/as/editeng
parent048550216b445425fc8d86277696f8f9bfb0c8bf (diff)
initial import of 4.1 translations
Change-Id: Ia93f31dedcdff3e180c36473e0667022795d96a7
Diffstat (limited to 'source/as/editeng')
-rw-r--r--source/as/editeng/source/accessibility.po2
-rw-r--r--source/as/editeng/source/editeng.po12
-rw-r--r--source/as/editeng/source/items.po20
-rw-r--r--source/as/editeng/source/misc.po2
-rw-r--r--source/as/editeng/source/outliner.po2
5 files changed, 19 insertions, 19 deletions
diff --git a/source/as/editeng/source/accessibility.po b/source/as/editeng/source/accessibility.po
index 57da768af79..6884c881a9c 100644
--- a/source/as/editeng/source/accessibility.po
+++ b/source/as/editeng/source/accessibility.po
@@ -3,7 +3,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: https://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED&component=UI\n"
-"POT-Creation-Date: 2012-12-26 11:14+0100\n"
+"POT-Creation-Date: 2013-05-23 12:05+0200\n"
"PO-Revision-Date: 2012-10-12 16:07+0000\n"
"Last-Translator: ngoswami <ngoswami@redhat.com>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
diff --git a/source/as/editeng/source/editeng.po b/source/as/editeng/source/editeng.po
index 070478e2e82..890810f36e8 100644
--- a/source/as/editeng/source/editeng.po
+++ b/source/as/editeng/source/editeng.po
@@ -3,7 +3,7 @@ msgid ""
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: https://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED&component=UI\n"
-"POT-Creation-Date: 2013-01-11 14:29+0100\n"
+"POT-Creation-Date: 2013-05-23 12:05+0200\n"
"PO-Revision-Date: 2013-01-11 15:21+0000\n"
"Last-Translator: ngoswami <ngoswami@redhat.com>\n"
"Language-Team: as_IN <kde-i18n-doc@kde.org>\n"
@@ -12,7 +12,7 @@ msgstr ""
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=n != 1;\n"
-"X-Generator: Pootle 2.5.0-beta1\n"
+"X-Generator: LibreOffice\n"
"X-Accelerator-Marker: ~\n"
"X-POOTLE-MTIME: 1357917687.0\n"
@@ -103,8 +103,8 @@ msgctxt ""
"RID_MENU_SPELL\n"
"MN_INSERT\n"
"menuitem.text"
-msgid "~Add"
-msgstr "যোগ কৰক (~A)"
+msgid "~Add to Dictionary"
+msgstr ""
#: editeng.src
msgctxt ""
@@ -112,8 +112,8 @@ msgctxt ""
"RID_MENU_SPELL\n"
"MN_INSERT_SINGLE\n"
"menuitem.text"
-msgid "~Add"
-msgstr "যোগ কৰক (~A)"
+msgid "~Add to Dictionary"
+msgstr ""
#: editeng.src
msgctxt ""
diff --git a/source/as/editeng/source/items.po b/source/as/editeng/source/items.po
index 2e25e13c3ef..ab9444294f7 100644
--- a/source/as/editeng/source/items.po
+++ b/source/as/editeng/source/items.po
@@ -3,7 +3,7 @@ msgid ""
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: https://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED&component=UI\n"
-"POT-Creation-Date: 2012-12-26 11:14+0100\n"
+"POT-Creation-Date: 2013-05-23 12:05+0200\n"
"PO-Revision-Date: 2012-10-12 16:07+0000\n"
"Last-Translator: ngoswami <ngoswami@redhat.com>\n"
"Language-Team: as_IN <kde-i18n-doc@kde.org>\n"
@@ -846,7 +846,7 @@ msgctxt ""
"RID_SVXITEMS_ADJUST_BLOCKLINE\n"
"string.text"
msgid "Justify"
-msgstr "শুদ্ধ প্ৰমাণীত কৰকস"
+msgstr "শুদ্ধ প্ৰমাণীত কৰক"
#: svxitems.src
msgctxt ""
@@ -1454,24 +1454,24 @@ msgctxt ""
"svxitems.src\n"
"RID_SVXITEMS_HYPHEN_MINLEAD\n"
"string.text"
-msgid "Characters at end of line"
-msgstr "শাৰীৰ শেষত আখৰসমূহ"
+msgid "%1 characters at end of line"
+msgstr ""
#: svxitems.src
msgctxt ""
"svxitems.src\n"
"RID_SVXITEMS_HYPHEN_MINTRAIL\n"
"string.text"
-msgid "Characters at beginning of line"
-msgstr "শাৰীৰ আৰম্ভত আখৰসমূহ"
+msgid "%1 characters at beginning of line"
+msgstr ""
#: svxitems.src
msgctxt ""
"svxitems.src\n"
"RID_SVXITEMS_HYPHEN_MAX\n"
"string.text"
-msgid "Hyphens"
-msgstr "হাইফেনসমূহ"
+msgid "%1 hyphens"
+msgstr ""
#: svxitems.src
msgctxt ""
@@ -1839,7 +1839,7 @@ msgctxt ""
"RID_SVXITEMS_HORJUST_RIGHT\n"
"string.text"
msgid "Align right"
-msgstr "সোঁফালে সংস্থাপন কৰক"
+msgstr "সোফালে সংস্থাপন কৰক"
#: svxitems.src
msgctxt ""
@@ -1847,7 +1847,7 @@ msgctxt ""
"RID_SVXITEMS_HORJUST_BLOCK\n"
"string.text"
msgid "Justify"
-msgstr "শুদ্ধ প্ৰমাণ কৰক"
+msgstr "শুদ্ধ প্ৰমাণীত কৰক"
#: svxitems.src
msgctxt ""
diff --git a/source/as/editeng/source/misc.po b/source/as/editeng/source/misc.po
index 88fb215d656..1eaee3c540f 100644
--- a/source/as/editeng/source/misc.po
+++ b/source/as/editeng/source/misc.po
@@ -3,7 +3,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: https://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED&component=UI\n"
-"POT-Creation-Date: 2012-12-26 11:14+0100\n"
+"POT-Creation-Date: 2013-05-23 12:05+0200\n"
"PO-Revision-Date: 2012-10-12 16:07+0000\n"
"Last-Translator: ngoswami <ngoswami@redhat.com>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
diff --git a/source/as/editeng/source/outliner.po b/source/as/editeng/source/outliner.po
index f9a444fd522..439c3f2a2b6 100644
--- a/source/as/editeng/source/outliner.po
+++ b/source/as/editeng/source/outliner.po
@@ -3,7 +3,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: https://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED&component=UI\n"
-"POT-Creation-Date: 2012-12-26 11:14+0100\n"
+"POT-Creation-Date: 2013-05-23 12:05+0200\n"
"PO-Revision-Date: 2012-10-12 16:07+0000\n"
"Last-Translator: ngoswami <ngoswami@redhat.com>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
reoffice-7-1-2'>libreoffice-7-1-2 LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
path: root/connectivity/source/drivers/calc
AgeCommit message (Collapse)Author
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in connectivityNoel Grandin
Change-Id: Ibb485324c71b78ff569cb15b6cf6f7f3889e1dc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-30use more concrete UNO type in file::OConnectionNoel Grandin
Change-Id: I6fe51ae569430d8f31217d7781b3e98e79e1c607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-07loplugin:ostr in connectivityNoel Grandin
Change-Id: Ice633719b05240ab5a052b62ca4eafe89f97e12f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-05use [[noreturn]] for these throw helpersCaolán McNamara
Change-Id: Ia50d6f2be91e830201689cc428e55203eeb41eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-29Drop uses of css::uno::Sequence::getConstArray in canvas .. connectivityMike Kaganski
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code 2021-11-05). Change-Id: I9467028fd1a7eeafad7f0dd776a91a9a40770b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166816 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-01tdf#146619 Drop unused 'using namespace' in: connectivity/Gabor Kelemen
Change-Id: Ie185575d699751b79e98c4fae0bc5405a165df9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165529 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-01-19cid#1545244 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546433 COPY_INSTEAD_OF_MOVE cid#1546428 COPY_INSTEAD_OF_MOVE cid#1546175 COPY_INSTEAD_OF_MOVE cid#1545866 COPY_INSTEAD_OF_MOVE Change-Id: I1d1e684faa422654fd90513cf459cde58d3d8914 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-14Use exception ctors, instead of setting members laterMike Kaganski
Avoids overwriting source location in message Change-Id: Ia0290c7dd1ab3ea1357712a27ecab75c7b583dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157893 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-04Use getXWeak in connectivityMike Kaganski
Change-Id: Id301a9321f77e5ccc1269a3b677e9faeb19a4011 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150841 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-16XUnoTunnel->dynamic_cast in connectivityyNoel Grandin
Change-Id: Ibe5e87a1ef1bdc11451e8fe240d017f1ef60dfe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145556 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-20loplugin:passstuffbyrefNoel Grandin
Change-Id: I336fd329b577b6fa141265d8bc7ce67784bd7306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21loplugin:flatten in canvas..cuiNoel Grandin
Change-Id: I208767eaa60d913fe2882403f1f9351eb08256f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-29Prepare for removal of non-const operator[] from Sequence in connectivityMike Kaganski
Change-Id: If92f9af5e248f4b066359fe043adf221102e8561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124353 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-08loplugin:moveparam in connectivityNoel Grandin
Change-Id: Ie5c2f6ec1573ab2c47218dd4da8c9150b23bcd2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 4Mike Kaganski
- Change implementations of getSomething to use getSomethingImpl Or where that's impossible, use getSomething_cast to unify this and reduce number of places where we reinterpret_cast. All static methods getting tunnel ids were renamed to getUnoTunnelId, to comply with the convention used in <comphelper/servicehelper.hxx>. TODO (in separate commits): - Revise uses of getSomething to use getFromUnoTunnel Change-Id: Ifde9e214b52e5df678de71fcc32d2199c82e85cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122100 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE]Mike Kaganski
- Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> OImplementationId uses broken double checked locking; additionally, it uses it at the first call to getImplementationId, not when the object is constructed. This implementation can't be changed, cince it's part of published API; it can't rely on C++11, which would be required for use of thread-safe statics and move the initialization to ctor. The class has obsolete _bUseEthernetAddress member, that is unused and ignored since 4e9fa7e339a1cd6cb2fec643715991bcf5057cec. No need to implement it when replacing its uses to UnoIdInit. The deprecation is the API CHANGE. No published API is introduced to replace it; 3rd-party code should seek alternative solutions, or just keep using the deprecated functionality. TODO (in separate commits): - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 1Mike Kaganski
The header got some changes: 1. Move UnoTunnelIdInit and isUnoTunnelId into 'comphelper' namespace 2. Rename UnoTunnelIdInit to UnoIdInit, as a precondition to replace of uses of OImplementationId with it, including in XTypeProvider 3. Introduce convenience functions 'getSomething_cast' to cast between sal_Int64 and object pointers uniformly. 4. Rename getUnoTunnelImplementation to getFromUnoTunnel, both to make it a bit shorter, and to reflect its function better. Templatize it to take also css::uno::Any for convenience. 5. Introduce getSomethingImpl, inspired by sw::UnoTunnelImpl; allow it handle cases both with and without fallback to parent. 6. Adjust UNO3_GETIMPLEMENTATION_* macros TODO (in separate commits): - Drop sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation - Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: If4a3cb024130f1f552f988f0479589da1cd066e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122022 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-14Directly initialize ODatabaseMetaDataResultSet in CDatabaseMetaData.cxxJulien Nabet
Change-Id: I32af6d9c699689b688d996c56fd5f64c5ed2f71d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115608 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-22loplugin:refcounting in connectivityNoel
Change-Id: Iff2f096e7ee00d9cb29d47462dd7e1963c6b06e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13tdf#123936 Formatting files in module connectivity with clang-formatPhilipp Hofer
Change-Id: I2c2f170c19663002637c702e9168c19c067ebbc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105656 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-10-21use tools::Long in comphelper..cuiNoel
Change-Id: I65167999c6049038f8f5d530a0c5cb0552ab0e06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29Remove some unused includesMiklos Vajna
Change-Id: I9af7e2fa0a450ebe396c0f049831a20100dbdc9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99659 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-11connectivity: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Id678e4c51459429dd3953c0e54558d2c36e85eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-18loplugin:flatten connectivityNoel Grandin
Change-Id: Ic1d9eb84b64ebde99e15704a10b27f21447df4d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-18simplify ORefVector codeNoel Grandin
by making it extend std::vector - it wants to be a ref-counted vector, so let it be, and we can simplify the usage sites Change-Id: I93ff6ee1522da965e16223dca171401d36fd67b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90664 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14tdf#42949 Fix IWYU warnings in connectivity/*/*cxxGabor Kelemen
Except for platform specific drivers/ado and drivers/macab dirs Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I24b741cded8995e29ac3d518aeaa0d60b3c55b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86317 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-18sal_Char->char in connectivityNoel Grandin
Change-Id: Ie32cbef9b03d69044c401f79bc737cde6dd0ed5d Reviewed-on: https://gerrit.libreoffice.org/85396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-16tdf#42949 Fix IWYU warnings in connectivity/*/*hxxGabor Kelemen
Except for non Linux specific parts: connectivity/source/drivers/macab/ connectivity/source/inc/ado/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iba6d0cd0effdac777be6fbc8f12f2e92cae47887 Reviewed-on: https://gerrit.libreoffice.org/84174 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>