aboutsummaryrefslogtreecommitdiff
path: root/source/szl/vcl
AgeCommit message (Expand)Author
2023-07-07update translations for master/7.6.0 rc1Christian Lohmaier
2023-05-10update translations for masterChristian Lohmaier
2023-03-03update translations for masterChristian Lohmaier
2022-10-10update translations for masterChristian Lohmaier
2022-08-24update tranlsations for 7.4.1 rc1/masterChristian Lohmaier
2022-05-25update translations for master/7.4Christian Lohmaier
2022-04-04update translations for masterChristian Lohmaier
2022-02-18update translations for masterChristian Lohmaier
2022-01-31update translations for masterChristian Lohmaier
2021-11-16update translations for masterChristian Lohmaier
2021-10-25update translations for masterChristian Lohmaier
2021-09-14update translations for masterChristian Lohmaier
2021-06-13update translations for 7.2.0 beta1libreoffice-7-2-branch-pointChristian Lohmaier
2021-05-14update translations for 7.2.0 alpha1Christian Lohmaier
2021-04-28update translations for masterChristian Lohmaier
2021-04-06update translations for masterChristian Lohmaier
2021-03-23update translations for masterChristian Lohmaier
2021-02-17update translations for masterChristian Lohmaier
2021-01-25update translations for masterChristian Lohmaier
2021-01-14update translations for masterChristian Lohmaier
2020-11-16update translations for masterChristian Lohmaier
2020-10-27update translations for master / 7.1.0.0 alpha1Christian Lohmaier
2020-10-23update translations for master/7.1.0 alpha1Christian Lohmaier
2020-10-12update translations for masterChristian Lohmaier
2020-08-27update translations for masterChristian Lohmaier
2020-07-27update translations for masterChristian Lohmaier
2020-07-13update translations for master/7.0Christian Lohmaier
2020-06-16update translations for 7.0 beta2Christian Lohmaier
2020-04-29update translations for masterChristian Lohmaier
2020-04-03update translations from weblateChristian Lohmaier
2020-02-28update translations for master and add Friulian (fur)Christian Lohmaier
2020-01-22update translations for masterChristian Lohmaier
2019-11-13update translations for 6.4.0 Beta1libreoffice-6-4-branch-pointChristian Lohmaier
2019-11-08update translations from weblateChristian Lohmaier
2019-10-14update translations for masterChristian Lohmaier
2019-10-02update translations from weblateChristian Lohmaier
2019-07-04update translations for 6.3.0 rc1Christian Lohmaier
2019-04-25update translations for masterChristian Lohmaier
2018-12-19update translations for 6.2.0 rc1Christian Lohmaier
2018-11-13update translations for masterChristian Lohmaier
2018-10-03update translations for masterChristian Lohmaier
2018-07-09update translations for masterChristian Lohmaier
2018-05-23update translations for master/6.1 beta1Christian Lohmaier
2018-04-25update translatiosn for 6.1.0 alpha1Christian Lohmaier
2017-11-24another set of translation updates for 6.0 beta1libreoffice-6-0-branch-pointChristian Lohmaier
2017-11-22update translations for 6.0 beta1Christian Lohmaier
2017-10-19update templates for 6.0.0 alpha1Christian Lohmaier
2017-09-14convert to gettext formatCaolán McNamara
2017-04-28update translations for 5.4.0 alpha1Christian Lohmaier
2016-11-23update translations for 5.3.0 beta1libreoffice-5-3-branch-pointChristian Lohmaier
on value='libreoffice-6-3-1'>libreoffice-6-3-1 LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
path: root/connectivity/source/parse
AgeCommit message (Collapse)Author
7 daystdf#130672: handle Rule::factor explicitlyMike Kaganski
When representing a signed number, the rule may consist of two subnodes: a punctuation bearing "+" or "-", and then the following digits (see 'factor:' in connectivity/source/parse/sqlbison.y). After punctuation was added to the string buffer, the following number is passed to parseLeaf, where it checks if the buffer is not empty, and then adds a space between the preceding sign and the digits. This change handles the 'factor' rule explicitly. Change-Id: I0c929418ad88c5bf653a4e820f45b7d627b07da7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180917 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in connectivityNoel Grandin
Change-Id: Ibb485324c71b78ff569cb15b6cf6f7f3889e1dc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-27cid#1555789 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556865 COPY_INSTEAD_OF_MOVE cid#1556871 COPY_INSTEAD_OF_MOVE cid#1556939 COPY_INSTEAD_OF_MOVE cid#1556951 COPY_INSTEAD_OF_MOVE cid#1556964 COPY_INSTEAD_OF_MOVE cid#1556966 COPY_INSTEAD_OF_MOVE cid#1556968 COPY_INSTEAD_OF_MOVE cid#1556971 COPY_INSTEAD_OF_MOVE cid#1556989 COPY_INSTEAD_OF_MOVE cid#1557001 COPY_INSTEAD_OF_MOVE cid#1557011 COPY_INSTEAD_OF_MOVE cid#1557032 COPY_INSTEAD_OF_MOVE cid#1557038 COPY_INSTEAD_OF_MOVE cid#1557041 COPY_INSTEAD_OF_MOVE cid#1557055 COPY_INSTEAD_OF_MOVE cid#1557056 COPY_INSTEAD_OF_MOVE cid#1557057 COPY_INSTEAD_OF_MOVE cid#1557065 COPY_INSTEAD_OF_MOVE cid#1557068 COPY_INSTEAD_OF_MOVE cid#1557087 COPY_INSTEAD_OF_MOVE cid#1557090 COPY_INSTEAD_OF_MOVE cid#1557093 COPY_INSTEAD_OF_MOVE cid#1557113 COPY_INSTEAD_OF_MOVE cid#1557122 COPY_INSTEAD_OF_MOVE cid#1557126 COPY_INSTEAD_OF_MOVE cid#1557145 COPY_INSTEAD_OF_MOVE cid#1557151 COPY_INSTEAD_OF_MOVE cid#1557152 COPY_INSTEAD_OF_MOVE cid#1557197 COPY_INSTEAD_OF_MOVE cid#1557216 COPY_INSTEAD_OF_MOVE cid#1557245 COPY_INSTEAD_OF_MOVE cid#1557272 COPY_INSTEAD_OF_MOVE cid#1557310 COPY_INSTEAD_OF_MOVE cid#1557314 COPY_INSTEAD_OF_MOVE cid#1557318 COPY_INSTEAD_OF_MOVE cid#1557333 COPY_INSTEAD_OF_MOVE cid#1557340 COPY_INSTEAD_OF_MOVE cid#1557358 COPY_INSTEAD_OF_MOVE cid#1557359 COPY_INSTEAD_OF_MOVE cid#1557365 COPY_INSTEAD_OF_MOVE cid#1557367 COPY_INSTEAD_OF_MOVE cid#1557395 COPY_INSTEAD_OF_MOVE cid#1557418 COPY_INSTEAD_OF_MOVE cid#1557488 COPY_INSTEAD_OF_MOVE cid#1557493 COPY_INSTEAD_OF_MOVE cid#1557506 COPY_INSTEAD_OF_MOVE cid#1557514 COPY_INSTEAD_OF_MOVE cid#1557528 COPY_INSTEAD_OF_MOVE cid#1557534 COPY_INSTEAD_OF_MOVE cid#1557537 COPY_INSTEAD_OF_MOVE cid#1557562 COPY_INSTEAD_OF_MOVE cid#1557563 COPY_INSTEAD_OF_MOVE cid#1557592 COPY_INSTEAD_OF_MOVE cid#1557608 COPY_INSTEAD_OF_MOVE cid#1557615 COPY_INSTEAD_OF_MOVE cid#1557619 COPY_INSTEAD_OF_MOVE cid#1557637 COPY_INSTEAD_OF_MOVE cid#1557648 COPY_INSTEAD_OF_MOVE cid#1557712 COPY_INSTEAD_OF_MOVE cid#1557750 COPY_INSTEAD_OF_MOVE cid#1557762 COPY_INSTEAD_OF_MOVE cid#1557765 COPY_INSTEAD_OF_MOVE Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-25cid#1633781 Initialization or destruction ordering is unspecifiedCaolán McNamara
and cid#1633780 Initialization or destruction ordering is unspecified cid#1633778 Initialization or destruction ordering is unspecified cid#1633777 Initialization or destruction ordering is unspecified cid#1633776 Initialization or destruction ordering is unspecified Change-Id: I8ae7cbede6df2ad747fe57d0ac2800e1b6a31038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175576 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-22move vcl::DeleteOnDeinit to toolsNoel Grandin
so we can fix a shutdown use-after-free in sot. Change-Id: I32f83bd94627d72d7bee7ea2ebd6ab77a7f78435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-18make UStringLess single-arg constructor explicitNoel Grandin
Change-Id: I0fb4723fa878f8ebdbe5ac0fe080559ffd4736dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170679 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-28Fix "lets see" -> "let's see"Andrea Gelmini
Change-Id: I7aa939681720bc0dc81c8f114a3608a8cdfb4f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169722 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-05-07loplugin:ostr in connectivityNoel Grandin
Change-Id: Ice633719b05240ab5a052b62ca4eafe89f97e12f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-01WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: Ic2c2e227a50994298377485e9e807cd9142cc386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166949 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-29Drop uses of css::uno::Sequence::getConstArray in canvas .. connectivityMike Kaganski
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code 2021-11-05). Change-Id: I9467028fd1a7eeafad7f0dd776a91a9a40770b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166816 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-10tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if condition is LIKEJulien Nabet
Let's consider "SQL_TOKEN_LOWER" and "SQL_TOKEN_UPPER" as "string_function_1Argument" like "SQL_TOKEN_LCASE" and "SQL_TOKEN_UCASE" Change-Id: I288fd5f3d9e3d104345c73a060ba11d9701500a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163099 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-30cid#1545421 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545403 COPY_INSTEAD_OF_MOVE cid#1545397 COPY_INSTEAD_OF_MOVE cid#1545376 COPY_INSTEAD_OF_MOVE cid#1545339 COPY_INSTEAD_OF_MOVE cid#1545288 COPY_INSTEAD_OF_MOVE Change-Id: I0e24a3fc7148d0b7ff8126debe3cddbb4fbdd713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-22Use emplace_back instead of push_back (connectivity)Julien Nabet
Change-Id: Ie90901832dafbaab56d3ac22bdb1cf91e3564fd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161181 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-03cid#1546453 COPY_INSTEAD_OF_MOVECaolán McNamara
a sample commit Change-Id: I226569c5d3b066a5c328b67a36c17df57b5a668d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-20Extended loplugin:ostr: connectivityStephan Bergmann
Change-Id: I284c896777c4f62499eb6b7c0a9883d9abf8d1f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159721 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: connectivityStephan Bergmann
Change-Id: I8220cf4e83a59aa55394d01f29a6af108dcc0619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158149 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-09-01connectiviy: fix to detect column data typeHenry Castro
if Base SQL query: SELECT COUNT("test"."id") from Test If changed to Spanish UI, detect the column type from a neutral context parser. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I1faa8ff8417a0fc4996b289bd2ce0baad52fc00c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156298 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156425 Tested-by: Jenkins
2023-09-01connectivity: add neutral context parserHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I12b0fe811d141873aaa64af5b6c457051c3356b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156297 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156424 Tested-by: Jenkins
2023-09-01connectivity: fix return column type "DataType::SQLNULL"Henry Castro
The Base SQL query: SELECT COUNT( "Test"."id" ) FROM "Test" And the UI language is set to Spanish, the function "getFunctionReturnType" returns misleading column type. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I2b57d1dfc005711374d7ae0de66b412f4f551d89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156295 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156422 Tested-by: Jenkins
2023-08-18tdf#156534 Add Firebird's DATEADD function to SQL parserjucasaca
Add DATEADD function to SQL parser, so the function can be used in Query's Design and can produce editable queries Change-Id: I14f9d88f6a96021b0f9199fd79df18c8f4bb5ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155071 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-07tdf#104918 Add Firebird's DATEDIFF syntax to the sql parserjucasaca
Add one of the Firebird's DATEDIFF syntax to the parser so now it is possible to execute DATEDIFF(unit, datetime, datetime) in the Base Query designer and don't need to execute it in SQL direct anymore Change-Id: I0514542785c47a2a4693cba26de1815c96ee1b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155027 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-22fixing a typo in sqlbison.yjucasaca
schema_glement_list is not registered, son can't be used. schema_element_list is registered and defined and seems to be the correct Change-Id: I7661532707ce6ddb32b95629192e9ba9847f21df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154766 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Lionel Mamane <lionel@mamane.lu>
2023-07-18Revert "tdf#155431: SQL Editor does not recognize UNSIGNED"Julien Nabet
This reverts commit 408a51a964d06e86c12d3a938c1295c75eecea63. Reason for revert: I gave a new try, it indeed doesn't work, I must have missed something. Change-Id: Ibf3318374cf68eaf093b9fa140b79beef2ddbd3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154546 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-18tdf#155431: SQL Editor does not recognize UNSIGNEDJulien Nabet
Change-Id: I2d618b27a92e1a85a6b7730aca3341f5259c4037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152128 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-17tdf#118817: add WEEK, WEEKDAY, YEARDAY AND MILLISECOND for EXTRACTJulien Nabet
Change-Id: I912e9c2f8394f487dc3753d653f5a9ba19d7f416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154524 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-15wrap OSQLParser::s_xLocaleData in vcl::DeleteOnDeinitNoel Grandin
since my adaption of i18npool to use OUStringLiteral, this data structure might get torn down after the i18npool data is has pointers to. Change-Id: If83d232d5bfb003ed4dbfb70d47f707a73d2bcc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-20Typo: nCurentPos->nCurrentPos (connectivity/sqliterator)Julien Nabet
Change-Id: I6580e81a8a792ff98e1b8594ed79bd77b684b719 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150684 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-11osl::Mutex->std::mutex in OSQLParserNoel Grandin
Change-Id: Ibc56fee796914a6dd39970f7a7879d5b5b2c219f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148660 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-22osl::Mutex->std::mutex in OSQLParseNodesContainerNoel Grandin
Change-Id: Ie47589a454799494bc150eec1e135c8948eb7fbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-17cid#1500499 Resource leakCaolán McNamara
the only change should be to the two trailing cases in OSQLParseNode::substituteParameterNames which do seem to leak. The closest I got to triggering the actual code is toggling into sqlview mode of a query but couldn't quite construct a sql statement to trigger it. Change-Id: I320dc4df3b18a18b236c91ee30329c10001c9a08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-16OSL_ENSURE->assert where we would crash if not trueCaolán McNamara
Change-Id: I1544573ea9f57b5ca732c9b05acae9b4f91f53ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-08Simplify by using replace instead of replaceAt in loop in connectivity (4)Julien Nabet
Change-Id: Iab92f1ee2be1e5b9ab3fa005890acfe9acbf3732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139460 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-04tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macrojsala
Change associated for by std::find_if in sqlbison.y Also change some integer by std::size_t Change-Id: I0d2100fbd7c22729da6ce0462c6cc093e0767fb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136263 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-18cid#1500536 silence Resource leakCaolán McNamara
Change-Id: Ibd626a90136f89af731dc2bfa684d99609d44b90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-13clang-tidy modernize-pass-by-value in connectivityNoel Grandin
Change-Id: I1f1b609254c7f8cfba14c248167f81b51684d8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135727 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-24Use o3tl::make_unsigned in some placesStephan Bergmann
...where a signed and an unsigned value are compared, and the signed value has just been proven to be non-negative here Change-Id: I20600d61a5d59d739bc1bee838c0038e4611aec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-09tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroPragat Pandya
Change-Id: I54257e87da0cd66da59d820c7960c3e4b020fda3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134027 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Jenkins
2022-05-05loplugin:unusedvariableplusNoel Grandin
Change-Id: Id93086be1224b6f6bf0bdaa1d50b4f289099027e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133876 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-04Just use Any ctor instead of makeAny in connectivityStephan Bergmann
Change-Id: I68e7354f094ee0e673d105dd8770a658810703d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133838 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11use more string_viewNoel Grandin
found by tweaking the loplugin:stringview and making it whitelist getLength Change-Id: Ic41cd4e3026d93b70a76fe1279c6de3abbe6b4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11loplugin:stringview add check for getToken().toInt32Noel Grandin
where we can convert that to o3tl::toInt32(o3tl::getToken( and avoid the heap allocation of a temporary string Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28cid#1500397 silence Resource leakCaolán McNamara
this reverts commit 1142dc2398de2e2be0e057ecb432ad9c8895313a Date: Sun Feb 27 14:14:18 2022 +0100 cid#1500397: Resource leak with an alternative that hopefully silences coverity and helps show better what is going on Change-Id: Ifb117d65789e80e66419911dbb6b327bdf7ed948 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-27cid#1500397: Resource leakJulien Nabet
Change-Id: I765df1eef9ccf447cdd0a80497c1ca6f22bb9e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130625 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-21cid#1500693 Resource leakJulien Nabet
Change-Id: Ic560c2079be0b04ce382350390e03e0ec2d8abcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-08cid#1497933 suppress Macro compares unsigned to 0Caolán McNamara
Change-Id: I7f06f889f2bd687028c00d79bdcf9e2edacc5c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>