From 3e76f6b637c8034330436568b26302c4472c1a0f Mon Sep 17 00:00:00 2001 From: Christian Lohmaier Date: Tue, 15 Dec 2015 15:56:38 +0100 Subject: update translations for 5.1.0 rc1 and force-fix errors using pocheck Change-Id: I10477683ddfb993e73ab615b2c031ea7bbbe6fe5 --- .../registry/data/org/openoffice/Office/UI.po | 185 ++++++++++++++------- 1 file changed, 125 insertions(+), 60 deletions(-) (limited to 'source/ja/officecfg') diff --git a/source/ja/officecfg/registry/data/org/openoffice/Office/UI.po b/source/ja/officecfg/registry/data/org/openoffice/Office/UI.po index ef9d0340217..b53dc6529bf 100644 --- a/source/ja/officecfg/registry/data/org/openoffice/Office/UI.po +++ b/source/ja/officecfg/registry/data/org/openoffice/Office/UI.po @@ -3,9 +3,9 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED&component=UI\n" -"POT-Creation-Date: 2015-11-16 19:03+0100\n" -"PO-Revision-Date: 2015-12-02 10:19+0000\n" -"Last-Translator: baffclan \n" +"POT-Creation-Date: 2015-12-11 12:58+0100\n" +"PO-Revision-Date: 2015-12-10 00:06+0000\n" +"Last-Translator: Souichirou Ishikawa \n" "Language-Team: LANGUAGE \n" "Language: ja\n" "MIME-Version: 1.0\n" @@ -14,7 +14,7 @@ msgstr "" "Plural-Forms: nplurals=1; plural=0;\n" "X-Generator: Pootle 2.7\n" "X-Accelerator-Marker: ~\n" -"X-POOTLE-MTIME: 1449051578.000000\n" +"X-POOTLE-MTIME: 1449705970.000000\n" #: BaseWindowState.xcu msgctxt "" @@ -1995,7 +1995,7 @@ msgctxt "" "Label\n" "value.text" msgid "Insert ~Rows Above" -msgstr "上に行を挿入(~R)" +msgstr "行を上に挿入(~R)" #: CalcCommands.xcu msgctxt "" @@ -2007,14 +2007,13 @@ msgid "Rows ~Above" msgstr "" #: CalcCommands.xcu -#, fuzzy msgctxt "" "CalcCommands.xcu\n" "..CalcCommands.UserInterface.Commands..uno:InsertRowsBefore\n" "Label\n" "value.text" msgid "Insert ~Rows Above" -msgstr "上に行を挿入(~R)" +msgstr "行を上に挿入(~R)" #: CalcCommands.xcu msgctxt "" @@ -2069,7 +2068,7 @@ msgctxt "" "Label\n" "value.text" msgid "Insert ~Rows Below" -msgstr "下に行を挿入(~R)" +msgstr "行を下に挿入(~R)" #: CalcCommands.xcu msgctxt "" @@ -6451,15 +6450,6 @@ msgctxt "" msgid "~Notes Master" msgstr "ノートマスター(~N)" -#: DrawImpressCommands.xcu -msgctxt "" -"DrawImpressCommands.xcu\n" -"..DrawImpressCommands.UserInterface.Commands..uno:TitleMasterPage\n" -"Label\n" -"value.text" -msgid "~Title Slide Master" -msgstr "タイトルスライドマスター(~T)" - #: DrawImpressCommands.xcu msgctxt "" "DrawImpressCommands.xcu\n" @@ -7117,6 +7107,24 @@ msgctxt "" msgid "Notes" msgstr "" +#: DrawImpressCommands.xcu +msgctxt "" +"DrawImpressCommands.xcu\n" +"..DrawImpressCommands.UserInterface.Commands..uno:DisplayMode\n" +"Label\n" +"value.text" +msgid "Display Mode" +msgstr "" + +#: DrawImpressCommands.xcu +msgctxt "" +"DrawImpressCommands.xcu\n" +"..DrawImpressCommands.UserInterface.Commands..uno:ToggleTabBarVisibility\n" +"Label\n" +"value.text" +msgid "Toggle Tab bar visibility" +msgstr "" + #: DrawImpressCommands.xcu #, fuzzy msgctxt "" @@ -11707,6 +11715,15 @@ msgctxt "" msgid "Glitter" msgstr "" +#: Effects.xcu +msgctxt "" +"Effects.xcu\n" +"..Effects.UserInterface.TransitionSets.honeycomb\n" +"Label\n" +"value.text" +msgid "Honeycomb" +msgstr "" + #: Effects.xcu msgctxt "" "Effects.xcu\n" @@ -14808,8 +14825,8 @@ msgctxt "" "..GenericCommands.UserInterface.Commands..uno:GridMenu\n" "Label\n" "value.text" -msgid "Gr~id" -msgstr "グリッド線(~I)" +msgid "Gr~id and Helplines" +msgstr "" #: GenericCommands.xcu #, fuzzy @@ -14875,6 +14892,15 @@ msgctxt "" msgid "Save to Remote Ser~ver" msgstr "" +#: GenericCommands.xcu +msgctxt "" +"GenericCommands.xcu\n" +"..GenericCommands.UserInterface.Commands..uno:SaveAsRemote\n" +"PopupLabel\n" +"value.text" +msgid "Save Remote File..." +msgstr "" + #: GenericCommands.xcu msgctxt "" "GenericCommands.xcu\n" @@ -15031,11 +15057,22 @@ msgid "Smooth Transition" msgstr "滑らかな移行" #: GenericCommands.xcu +#, fuzzy msgctxt "" "GenericCommands.xcu\n" "..GenericCommands.UserInterface.Commands..uno:ToggleObjectBezierMode\n" "Label\n" "value.text" +msgid "Edit Points" +msgstr "制御点の編集" + +#: GenericCommands.xcu +#, fuzzy +msgctxt "" +"GenericCommands.xcu\n" +"..GenericCommands.UserInterface.Commands..uno:ToggleObjectBezierMode\n" +"ContextLabel\n" +"value.text" msgid "Poi~nts" msgstr "制御点(~N)" @@ -15481,13 +15518,14 @@ msgid "Demote" msgstr "レベルを下げる" #: GenericCommands.xcu +#, fuzzy msgctxt "" "GenericCommands.xcu\n" "..GenericCommands.UserInterface.Commands..uno:OutlineFormat\n" "Label\n" "value.text" msgid "Show Formatting" -msgstr "" +msgstr "ページの書式設定" #: GenericCommands.xcu msgctxt "" @@ -15671,14 +15709,13 @@ msgid "~Edit Style..." msgstr "スタイルの編集(~D)..." #: GenericCommands.xcu -#, fuzzy msgctxt "" "GenericCommands.xcu\n" "..GenericCommands.UserInterface.Commands..uno:StyleNewByExample\n" "Label\n" "value.text" -msgid "~New Style from Selection..." -msgstr "選択スタイルから新規作成" +msgid "~New Style..." +msgstr "" #: GenericCommands.xcu msgctxt "" @@ -16530,6 +16567,36 @@ msgctxt "" msgid "~Shape" msgstr "シェイプ(~S)" +#: GenericCommands.xcu +#, fuzzy +msgctxt "" +"GenericCommands.xcu\n" +"..GenericCommands.UserInterface.Commands..uno:ShapesLineMenu\n" +"Label\n" +"value.text" +msgid "~Line" +msgstr "線" + +#: GenericCommands.xcu +#, fuzzy +msgctxt "" +"GenericCommands.xcu\n" +"..GenericCommands.UserInterface.Commands..uno:ShapesBasicMenu\n" +"Label\n" +"value.text" +msgid "~Basic" +msgstr "基本" + +#: GenericCommands.xcu +#, fuzzy +msgctxt "" +"GenericCommands.xcu\n" +"..GenericCommands.UserInterface.Commands..uno:ShapesSymbolMenu\n" +"Label\n" +"value.text" +msgid "~Symbol" +msgstr "記号" + #: GenericCommands.xcu msgctxt "" "GenericCommands.xcu\n" @@ -17666,15 +17733,6 @@ msgctxt "" msgid "Flip Horizontally" msgstr "左右反転" -#: GenericCommands.xcu -msgctxt "" -"GenericCommands.xcu\n" -"..GenericCommands.UserInterface.Commands..uno:FlipHorizontal\n" -"TooltipLabel\n" -"value.text" -msgid "Flip the selected object horizontally." -msgstr "" - #: GenericCommands.xcu msgctxt "" "GenericCommands.xcu\n" @@ -17684,15 +17742,6 @@ msgctxt "" msgid "Flip Vertically" msgstr "上下反転" -#: GenericCommands.xcu -msgctxt "" -"GenericCommands.xcu\n" -"..GenericCommands.UserInterface.Commands..uno:FlipVertical\n" -"TooltipLabel\n" -"value.text" -msgid "Flip the selected object vertically." -msgstr "" - #: GenericCommands.xcu msgctxt "" "GenericCommands.xcu\n" @@ -18655,8 +18704,17 @@ msgctxt "" "..GenericCommands.UserInterface.Commands..uno:SwitchControlDesignMode\n" "Label\n" "value.text" -msgid "Design Mode On/Off" -msgstr "デザインモード オン/オフ" +msgid "Toggle Design Mode" +msgstr "" + +#: GenericCommands.xcu +msgctxt "" +"GenericCommands.xcu\n" +"..GenericCommands.UserInterface.Commands..uno:SwitchControlDesignMode\n" +"ContextLabel\n" +"value.text" +msgid "Design Mode" +msgstr "" #: GenericCommands.xcu msgctxt "" @@ -22306,7 +22364,16 @@ msgctxt "" "..WriterCommands.UserInterface.Commands..uno:InsertMultiIndex\n" "Label\n" "value.text" -msgid "Table of Contents or ~Index..." +msgid "Insert Table of Contents, Index or Bibliography" +msgstr "" + +#: WriterCommands.xcu +msgctxt "" +"WriterCommands.xcu\n" +"..WriterCommands.UserInterface.Commands..uno:InsertMultiIndex\n" +"ContextLabel\n" +"value.text" +msgid "Table of Contents, ~Index or Bibliography..." msgstr "" #: WriterCommands.xcu @@ -22901,7 +22968,7 @@ msgstr "オブジェクトの挿入" #: WriterCommands.xcu msgctxt "" "WriterCommands.xcu\n" -"..WriterCommands.UserInterface.Commands..uno:ObjectMenu\n" +"..WriterCommands.UserInterface.Commands..uno:FormatObjectMenu\n" "Label\n" "value.text" msgid "~Text Box and Shape" @@ -23675,8 +23742,8 @@ msgctxt "" "..WriterCommands.UserInterface.Commands..uno:AlignTop\n" "Label\n" "value.text" -msgid "Align Top" -msgstr "上揃え" +msgid "Align Top to Anchor" +msgstr "" #: WriterCommands.xcu msgctxt "" @@ -23684,8 +23751,8 @@ msgctxt "" "..WriterCommands.UserInterface.Commands..uno:AlignBottom\n" "Label\n" "value.text" -msgid "Align Bottom" -msgstr "下揃え" +msgid "Align Bottom to Anchor" +msgstr "" #: WriterCommands.xcu msgctxt "" @@ -23693,8 +23760,8 @@ msgctxt "" "..WriterCommands.UserInterface.Commands..uno:AlignVerticalCenter\n" "Label\n" "value.text" -msgid "Align Vertical Center" -msgstr "中央揃え(上下）" +msgid "Align Middle to Anchor" +msgstr "" #: WriterCommands.xcu msgctxt "" @@ -23784,7 +23851,7 @@ msgctxt "" "Label\n" "value.text" msgid "Insert Rows Above" -msgstr "上に行を挿入" +msgstr "行を上に挿入" #: WriterCommands.xcu msgctxt "" @@ -23805,14 +23872,13 @@ msgid "Insert Row" msgstr "行の挿入" #: WriterCommands.xcu -#, fuzzy msgctxt "" "WriterCommands.xcu\n" "..WriterCommands.UserInterface.Commands..uno:InsertRowsAfter\n" "Label\n" "value.text" msgid "Insert Rows Below" -msgstr "下に行を挿入" +msgstr "行を下に挿入" #: WriterCommands.xcu msgctxt "" @@ -23839,7 +23905,7 @@ msgctxt "" "Label\n" "value.text" msgid "Insert Columns Left" -msgstr "左に列を挿入" +msgstr "列を左に挿入" #: WriterCommands.xcu msgctxt "" @@ -23860,14 +23926,13 @@ msgid "Insert Column" msgstr "列の挿入" #: WriterCommands.xcu -#, fuzzy msgctxt "" "WriterCommands.xcu\n" "..WriterCommands.UserInterface.Commands..uno:InsertColumnsAfter\n" "Label\n" "value.text" msgid "Insert Columns Right" -msgstr "右に列を挿入" +msgstr "列を右に挿入" #: WriterCommands.xcu msgctxt "" @@ -23983,8 +24048,8 @@ msgctxt "" "..WriterCommands.UserInterface.Commands..uno:OptimizeTable\n" "Label\n" "value.text" -msgid "Optimize" -msgstr "最適化" +msgid "Optimize Size" +msgstr "" #: WriterCommands.xcu msgctxt "" @@ -25981,7 +26046,7 @@ msgstr "" #, fuzzy msgctxt "" "WriterCommands.xcu\n" -"..WriterCommands.UserInterface.Popups..uno:StyleApply?Style:string=Text Body&FamilyName:string=ParagraphStyles\n" +"..WriterCommands.UserInterface.Popups..uno:StyleApply?Style:string=Text body&FamilyName:string=ParagraphStyles\n" "Label\n" "value.text" msgid "Text Body" -- cgit eature/allo_contract45533b'>feature/allo_contract45533b LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
path: root/svl/source/items/voiditem.cxx
AgeCommit message (Collapse)Author
2023-11-07ITEM: Get away from classic 'poolable' Item flagArmin Le Grand (allotropia)
To understand this, some look back in history will be needed to see why it is as it is today. In some (reworked) comments 'poolable' is described as flag to hold Items in the ItemPool, also always having only one incarnation of each possible Item. This is not the original intention, but a side-effect. The reason is what the binary format in the office did: To save a document, the Objects & the Pool were saved, *not* individual Items *together* with the objects. The Pool was completely (binary) saved (and loaded) in one run. Temporary IDs were used to represent at the objects in file which Items were referenced. This *required* to have only one incarnation per item to have a minimal binary file size, thus this high effort was put into this. At doc load, the pool was loaded, all Items were set to RefCount 5000, the references from the objects were restored and then for each Item the RefCount was lowered by 5000 again and - if being zero - deleted. Items for UI were marked 'non-poolable' to *not* safe them with the document, so poolable was a flag to decide if that Info/Item was to be saved with the document - or more direct: if it is Model Data. Items are small, so if we prefer runtime it is okay to no longer being strict with this, anyways does not happen often and has only marginal memory effects - compared to runtime effects/savings. Other problems which this caused: One example is that objects in the UNDO stack were still in the pool, so e.g. deleted pictures were saved with the document despite no longer being used (!). That is the reason we have an UndoItemPool and a method MigrateItemPool to move stuff to that Pool when objects go to the UNDO stack - all of this is also no longer needed. Cleaning this up means to ideally have all items in the SfxItemSet, no longer at the Pool. The Pool should be reduced to a 'Default-Item- Holder' and a 'Slot-to-whichId-mapper'. This needs thorough cleanups/removals, but will be worth it because that massive simplification(s) will increase safety an runtime and make migrating to the goal of completely type-based ItemSet stuff easier for the future. Hopefully only view code in the office working with items will have to be changed for this. In this 1st step I already found that some 'compromizes' will be needed: - There are still Items that have to be at the pool to make the Surrogate-stuff working. This gives back all Items in a Pool of a type and is used in ca. 80 cases. Each one looks at these Items *without* context (e.g. a SfxItemSet at an Object would be a context), so if e.g. a dialog is open that temporarily uses Items of that type you would also get these - without knowing about it... To make that work there is still a mechanism to have Items at the Pool, but now just *registering* (and un-reg) them without any sort/search/ remove needs. Also only for Items that need that, so I evaluated the GetItemSurrogates calls and added some asserts when GetItemSurrogates tries to access an unregistered item type which needs to be added. - Another caveat is that there are about 250 places that directly put Items to the Pool (not all remove these, that is done at pool deletion, so some kind of silent 'garbage-collection' is in place). To have an overview I renamed the accessing methods to separate them from the same functionality at the SfxItemSet, which had the same names. An implementation does still add these directly to the pool, there is no way to cleanup those usages for now. In principle all these should be changed to hold the data at an SfxItemSet. I am still hunting problems. But you can build the office, all apps work (including chart) and you can do speed comparisons already. There are test throwing errors, so I hunt these now. It is hard to give an estimation about how much more changes/corrections will be needed. Completed adaptions to new registered Items at Pool, that reduces the failing tests. Still many that I need to hunt. Added stuff to work around that 'compromize' in ScDocumentPool: It overloads ::PutImpl of the pool to implement special handling for a single Item in SC, the ScPatternAttr. In former code that method was used from SfxItemSet and ::PutImpl at the pool directly, so it was only used in one place. I am not sure if it was used from the SfxItemSet functionality, but better offer it for now. To not waste too much runtime the callbacks depend on the boolean 'NewItemCallback' at the SfxPoolItem, it gets set for that single Item in SC and only then the callbacks trigger. I hope to get rid of those again, e.g. newItem_UseDirect is only needed since we have no 'real' StaticPoolDefaults currently - another thing that needs to be cleaned up in a next step. Since usages of impl(Create|Cleanup)ItemEntry and Direct(Put|Remove)ItemInPoolImpl got more and more similar I decided to unify that: move impl(Create|Cleanup)ItemEntry to tooling, make it globally available in svl and use it also directly for Direct(Put|Remove)ItemInPoolImpl. This slightly increases the failing tests again, but only since in Direct(Put|Remove)ItemInPoolImpl that fallback (e.g. tryToGetEqualItem) was used before, thus this is the same class of errors (SfxPoolItem ptr-compare) as the others which I will need to find anyways. Also fixed some missing stuff. Have now idenified and redirected all SfxPoolItem ptr-compares to be able to debug these - one cause for the remaining errors is probably that before with bPoolable those often were sufficient, but are no longer. Used the [loplugin:itemcompare] and a local clang build to do so, see https://gerrit.libreoffice.org/c/core/+/157172 Stabilized Direct(Put|Remove)ItemInPoolImpl forwards, added parameter to implCreateItemEntry to signal that it gets called from DirectPool stuff - currently needed. Hopefully when getting rid of that DirectPool stuff we can remove that again Added two more debug functionalities: - Added a SerialNumber to allow targeted debugging for deterministic cases - Added registering & listing of still-allocated SfxPoolItems at office shutdown Found PtrComp error in thints.cxx - POC, thanks to areSfxPoolItemPtrsEqual. Will hopefully help more with other tests Found some wrong asserts/warnings where I was too careful and not finding something/succeeding is OK, fixes some UnitTests for SC For SC I now just tried to replace all areSfxPoolItemPtrsEqual with the full-ptr-content compare SfxPoolItem::areSame. I also needed to experiment/adapt the newItem_Callback solution but got it working. Did that replacement now for SW too, found some places where the direct ptr compare is OK. Continued for the rest of occurrences, now all 160 places evaluated. Also done some cleanups. Massive cleanups of stuff no longer needed with this paradigm change. Also decided to keep tryToGetEqualItem/ITEM_CLASSIC_MODE for now. It is used for *one* Item (ScPatternAttr/ATTR_PATTERN) in SC that already needs many exceptions. Also useful for testing if errors come up on this change to test if it is related to this. Added forwarding of target Pool for ::Clone in SvxSetItem and SvxSetItem, simplified SfxStateCache::SetState_Impl and returned to simple ptr compares in SfxPoolItem::areSame to not do the test in areSfxPoolItemPtrsEqual. Debugged through UITest_calc_tests9 and found that in tdf133629 where BoxStyle is applied to fully selected empty calc the Item- reuse fallback has to be used not only for ATTR_PATTERN, see comment @implCreateItemEntry. Maybe more... Problem with test_tdf156611_insert_hyperlink_like_excel. Found that in ScEditShell::GetFirstURLFieldFromCell the correct SvxURLField is found and returned as ptr, but it's usage crashes. That is due to the SfxItemSet aEditSet used there gets destroyed at function return what again deletes the SvxFieldItem that is holding the SvxURLField that gets returned. This shows a more general problem: There is no 'SfxPoolItemHolder' that safely holds a single SfxPoolItem - like a SfxItemSet for a single Item (if Items would be shared_ptrs, that would be a safe return value). That will be needed in the future, but for now use another solution: Since I see no reason why EE_FEATURE_FIELD should not be shareable I wil change this for ow in the SfxItemInfo for EditCharAttribField. That way the Item returned will be shared (RefCnt > 1) and thus not be deleted. I changed the return value for GetURLField() and GetFirstURLFieldFromCell() in ScEditShell: At least for GetFirstURLFieldFromCell the return type/value was not safe: The SvxFieldItem accessed there and held in the local temporary SfxItemSet may be deleted with it, so return value can be corrupted/deleted. To avoid that, return a Clone of SvxFieldData as a unique_ptr. With all that UnitTest debugging and hunting and to get the paradigm change working to no longer rely on shared/pooled items I lost a little bit focus on speed, so I made an optimization round for the two central methods implCreateItemEntry/implCleanupItemEntry to get back to the speed improvements that I detected when starting this change. It was mainly lost due to that 'strange' chained pool stuff we have, so I added to detect the target pool (the one at which the WhichID is registered) directly and only once. Next thing to cleanup will/should be the pool and it's concept, all this is not needed and really costs runtime. Since implCreateItemEntry/implCleanupItemEntry are executed millions of times, each cycle counts here. Had an error in the last changes: pool::*_Impl methods use index instead of WhichID - most of them. Another bad trap, I really need to cleanup pool stuff next. Change-Id: I6295f332325b33268ec396ed46f8d0a1026e2d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157559 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-09-11ITEM: Diverse further changes/cleanups/preparationArmin Le Grand (allotropia)
Added a counter for SfxItemSet usages, similar to the already added one for SfxPoolItems to allow quick info about evtl. problems/drawbacks of changes. Replaced enum SfxItemKind in favour of settable boolean flags directly at SfxPoolItem. These are organized as bitfield, do not need more space as the enum and allow to be set separately and multiple ones at the same time. Flags for PoolDefault/StaticDefault/DeleteOnIdle use this now and are quickly accessible booleans. It is not a problem that theoretically the flags for PoolDefault/StaticDefault could now both be set - this is internal to SfxItem stuff and not accessible from normal code, so can be managed. Added for debug build a bitfield boolean m_bDeleted that will be set in the SfxPoolItem destructor. Of course it's usability will depend on the freed space not yet being re-used, but will hopefully help in the debugger to detect reasons for failure (would have helped at least me before). Added for replacement of virtual method IsVoidItem() another bitfield bool m_bIsVoidItem that is set in the constructors of SfxVoidItem. Also had to add some constructors to do that which were defaulted before. This is mainly because the base class SfxPoolItem does *not* have a copy-constructor that copies the members (flags/RefCnt/WhichID) and we should keep that 'indirect reset' when Cloning. isVoidItem() is now a simple boolean member access - the bitfield does the needed masking. This spares one entry in the virtual function table of SfxPoolItem which is derived more than 500 times. Used the results of the experiment at https://gerrit.libreoffice.org/c/core/+/156774 to change some accesses to IsVoidItem() to use SfxItemState instead. This is for preparation of splitting up the two usages of SfxVoidItems, see commit text in the experiment. If this shows problems in the future those six places documented there may have to be changed back to use the new isVoidItem(), but should also check the ptr this time to be non-zero. Removed SFX_ITEMS_SPECIAL that is no more used anywhere. Change-Id: Ib687ca2362d72a4651c75aee0c67029088f68947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156805 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-08-18ITEM: preparations for more/easier changesArmin Le Grand (allotropia)
This change is not about speed improvements but diverse preparations to make changes/reading/understanding easier. It does not change speed AFAIK. Added a global static debug-only counter to allow getting an overview over number of all allocated SfxPoolItem's and the still alloated ones at office shutdown. The values are used in Application::~Application to make a short info statement. It allows to be able to quickly detect if an error in future changes may lead to memory losses - these would show in dramaitically higher numbers then (hopefully) immediately. Moved SfxVoidItem to own source/header. Added container library interface support to SfxItemSet, adapted already some methods to use it - not all possible, I will commit & get status from gerrit 1st if all still works and then continue. Changed INVALID_POOL_ITEM from -1 to use a global unique incarnation of an isolated derivation from SfxPoolItem. It allows to avoid the (-1) pointer hack. Since still just pointers are compared it's not worse. NOTE: That way, more 'special' SfxPoolItem's may be used for more States - a candidate is e.g. SfxVoidItem(0) which represents ::DISABLED state -- unfortunately not only, it is also used (mainly for UI stuff) with 'real' WhichIDs - hard to sort out, will have to stay that way for now AFAIK. Changed INVALID_POOL_ITEM stuff to use a static extern incarnated item in combination with a inline method to return it, called GetGlobalStaticInvalidItemInstance(). Isolated create/cleanup of a SfxPoolItem entry in SfxItemSet to further modularize/simplify that. It is currently from constructor & destructor but already shows that PoolDefaults are handled differently - probably an error. Still, for now, do no change in behaviour (yet). Got regular 'killed by the Kill-Wrapper' messages from gerrit, seems to have to do with UITest_sw_findReplace. That python/c++ scripting stuff is hard to debug, but finally I identified the problem has to do with the INVALID_POOL_ITEM change. It was in SfxItemSet::InvalidateAllItems() where still a (-1) was used -> chaos in detecting invalid items. Change-Id: I595e1f25ab660c35c4f2d19c233d1dfadfe25214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155675 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>