/source/bn-IN/helpcontent2/

ore' title='lo/core Git repository'/>
summaryrefslogtreecommitdiff
path: root/sc/source/ui/view/gridwin2.cxx
AgeCommit message (Collapse)Author
2025-02-11tdf#164685 Cleanup SfxItemSetFixed - Part 3rafaelhlima
This is the continuation of the cleanup of class SfxItemSetFixed, as described in the bug ticket. Change-Id: I567f985af181d326a6adb6c3d3af2a9e2fa8df34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180975 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2024-05-06ScGlobal::GetUserList never returns nullCaolán McNamara
Change-Id: Ibce3fc1b6d85fc6183fc2552a71ead6443b45fad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-26tdf#160338 Calc freeze on Text Attribute dialogNoel Grandin
This reverts commit 76e9023c8abc823447b1128056e55238f90da8d6 Author: Noel Grandin <noelgrandin@gmail.com> Date: Mon Jan 22 08:36:28 2024 +0200 convert more calc dialogs to async I fixed some lifetime issues, but even once that was happy, the Text Attributes dialog was not receiving mouse events properly, something else is unhappy when we mix async and modal dialogs. Change-Id: I4a35d886895c65af2085b606ff5c7a7c02fb5671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-24convert more calc dialogs to asyncNoel Grandin
Change-Id: I6349942f0a4d6156ef59f43a6e96049128f47524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-02cid#1528432 Argument cannot be negativeCaolán McNamara
Change-Id: Ic55c524a9ec8ae9a4df7f96d284d822616fa3b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151241 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-27sc: pivot table compact layoutDennis Francis
This implements compact layout for pivot tables. In ooxml each row field can have a compact layout setting. Support for any such "mixed" layout of tabular/outline/compact per field is also implemented. This also implements expand/collpse toggle buttons to field labels to make pivot tables with compact layout more usable. Such buttons are also available if other layouts are used. Conflicts: sc/qa/unit/pivottable_filters_test.cxx sc/source/ui/cctrl/checklistmenu.cxx sc/source/ui/inc/checklistmenu.hxx Change-Id: Ieaa1f3bd282ebdec804d0b45a0af7b3d95a2027f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151057 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-07-22tdf#117276 sc: Show hidden filter elements as inactive elementsBalazs Varga
Showing hidden values in the autofilter dropdown (as inactive when it was hidden by another row) - without changing the behaviour of autofilter. First those which belongs to non-hidden rows, then those which belongs to hidden rows. TODO: maybe we can add a global option where the user can switch on/off this feature. Change-Id: Iafeb43176efe7ab422b22697d399c68c95d0319d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136595 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-04-15jsdialog: autofilter: unify with regular popupSzymon Kłos
- remove special type "autofilter" - now autofilter will be handled by dialog code in online Change-Id: I3478c3e05ab2e83030a8d68632d0426a5cc0accd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132539 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132916 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-14lok: send logic autofilter positionSzymon Kłos
we need to show popup relative to the grid window Change-Id: Ib0cf66d2c0422b765a3b8035d5499b45e83f768d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130528 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131511 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-01-31lokCalcRTL: fix autofilter button hit detectionDennis Francis
No mirroring needed when not in tile painting mode. All positions are in document coordinates. Conflicts: sc/source/ui/view/gridwin2.cxx Change-Id: I45425e2ddce7f5ddc5086dcdce31bb6d081edc41 (cherry picked from commit 2eb5f597c3b1c5a680d6e0f9d0719f9f6977e1a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128903 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-12-02Resolves: tdf#144811 use the hover-style menu for color submenusCaolán McNamara
Change-Id: I8653c36d084f9df5a4d34baf7d88e2f2b5f1609b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126209 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-28don't need to have a specific mbCanHaveSubMenu mode anymoreCaolán McNamara
since the gap in the vcl treeview separator problem is fixed Change-Id: I105167127588c11895d81dd2aea3c9e119170069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125952 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-23tdf#139460 improve autofilter sub-menu interaction under gtkCaolán McNamara
so the submenu pops down when the mouse moves back into its parent. This removes layer of InterimItemWindow and for gtk (under wayland) the autofilter and its submenu can use native GtkPopovers Change-Id: I4c8c3d2087566f508d75eda72e272d9f7fba2f00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12Resolves: tdf#145645 pivot table popups don't dismiss when item activatedCaolán McNamara
Change-Id: I5a68a08600b7792d924ec77694a60651df5d9c83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-07use SfxItemSetFixed in scNoel Grandin
Change-Id: I5b1d66adb1b9e5dd0e470403ba7095183334cc66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-20clean up ambiguous confusing rectangle APIs like IsInside()Luboš Luňák
Reading 'rectA.IsInside( rectB )' kind of suggests that the code checks whether 'rectA is inside rectB', but it's actually the other way around. Rename IsInside() -> Contains(), IsOver() -> Overlaps(), which should make it clear which way the logic goes. Change-Id: I9347450fe7dc34c96df6d636a4e3e660de1801ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122271 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-07-19Move svl::Items to include/svl/whichranges.hxx, and unify its usageMike Kaganski
... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed to explicitly use 'value' in WhichRangesContainer's ctor, or create an instance for use in SfxItemSet ctor (svl::Items is already defined as a template value of corresponding type). Instead of WhichRangesContainer Foo(svl::Items<1, 2>::value); SfxItemSet Bar(rItemPool, svl::Items<1, 2>{}); now use: WhichRangesContainer Foo(svl::Items<1, 2>); SfxItemSet Bar(rItemPool, svl::Items<1, 2>); Change-Id: I4681d952b6442732025e5a26768098878907a238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-17split OutputDevice from WindowNoel Grandin
as part of a longer-term goal of doing our widget rendering only inside a top-level render- context. I moved all of the OutputDevice-related code that existed in vcl::Window into a new subclass of OutputDevice called WindowOutputDevice. Notes for further work (*) not sure why we are getting an 1x1 surface in SvpSalGraphics::releaseCairoContext, but to fix it I clamp the size there (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code? Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04Related: tdf#140968 avoid duplicated filter valuesBalazs Varga
Group and filter based on the actual cell format, like MSO does, to simplify filtering of values rounded by the cell format (e.g. selecting the single AutoFilter condition "1.0" to filter both 1.01 and 0.99). Followed up of 4fd1333ba4bb4f2311e9098291154772bd310429 (tdf#140968 tdf#140978 XLSX import: fix lost rounded filters) tdf#141916: odf export: Indicating the formatted filter values, by export the XML_DATA_TYPE with XML_TEXT, to avoid bad filtering of formatted filter values. tdf#141775: fix regression of 4fd1333ba4bb4f2311e9098291154772bd310429 (tdf#140968 tdf#140978 XLSX import: fix lost rounded filters) tdf#141915: fix OOXML import of 0.0 filter values of filter conditions by setting it byValue filtering in datauno.cxx. Change-Id: I1c840249ee1ef95aff33a4740b8bf2ebc47f2325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113314 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-08autofilter: handle click for scaled dropdown buttonSzymon Kłos
Missing thing for commit: 68892230ddcde135e9951047a3621438eb7987d0 autofilter: scale dropdown button according to zoom level rendering was scaled but click position was handled using non scaled button size Change-Id: I599b7e6aef39e8b5225b53423125f2b271597a46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110646 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112160 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30autofilter: fix submenu popup for onlineSzymon Kłos
Change-Id: If48428f99b921d3c6f9927c612e6ade81b980678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106847 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-28Improve spell checking performance and impl. in several ways:Dennis Francis
* do synchronous spell checking, avoiding an idle handler * avoid continuous invalidations caused per-cell by spell-checking * cache spell-checking information for a given SharedString to avoid repeated checking of frequently recurring strings. Change-Id: Ie251f263a8932465297dd8bd66dfc4aa10984947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20use tools::Long in scNoel
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25change pointers to references where never possible to be nullptrsCaolán McNamara
and drop some null checks then shown not to be needed Change-Id: I2806eeb64f43072a34aecd46424dbd063a119b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-21set whether dates are needed in the ctorCaolán McNamara
so its known from the start which mode will be in use Change-Id: I2fe69af481360a1668992010ad57c6bd3748d51d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15establish that ScViewData::GetDocument can always return ScDocument&Caolán McNamara
we can only be ctored with a ScDocShell& or ScDocument&, and ScDocShell provides a ScDocument& from its GetDocument() so we can always have a ScDocument& when a public ctor has completed some null checks can then be seen to be redundant and are removed Change-Id: Ifaf39cb06e8dbce363999c05ee0aeb3ec4f00428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102775 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-16size width request to fit column hintCaolán McNamara
Change-Id: I1439984e4ff52bebb1c1e777c1cdffcc5820c169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96472 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12weld checklistmenuCaolán McNamara
rework the "menu" to be a treeview using hover selection instead of a custom set of widgetry, and drop the newly unused custom a11y code Change-Id: Ie7d9b7875ce00843b3f262882816cebb472bf681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06lok: on calc spelling context menu didn't pop upMarco Cecchetti
The problem has been fixed by making visible cell range syncronized with client visible area Change-Id: I632f8ef4d5e8fa227b55fcb0459ed89d10798134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89856 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2019-11-14cid#1455325 establish that pDoc cannot be null thereCaolán McNamara
Change-Id: Ia7bca1e74a8ede90e29ec6cbd63c7fdcaf25b072 Reviewed-on: https://gerrit.libreoffice.org/82696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-22sc: rowcol: tdf#50916 convert gridwinNoel Grandin
Change-Id: Ifaaddbf17430cf7f2b64785f80afd3cfaa80cdd8 Reviewed-on: https://gerrit.libreoffice.org/81325 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-10Fix typosAndrea Gelmini
Change-Id: I22eef797ee934fa003a513a56145e1af9c5ad94e Reviewed-on: https://gerrit.libreoffice.org/78801 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-10Fix typosAndrea Gelmini
Change-Id: I79f87f033eeb67d1750bb595d311d74ef3db6ce9 Reviewed-on: https://gerrit.libreoffice.org/78795 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-13tdf#126848: sc pivot table popup: avoid flickerXisco Fauli
Follow-up of 4dadbff74eff5f8ad00df99c659f8a2b914e09a1 Regression from commit a4cb27f61376d8f2d8faed0022c291af68d437bd Change-Id: I4d0cd2ad2d7d239307c48c9bc8c1f1ced6597f47 Reviewed-on: https://gerrit.libreoffice.org/77408 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-12tdf#42949 Fix IWYU warnings in sc/source/ui/{view,xmlsource}/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie47dff381392ef57cb857184c179bf82d3b55862 Reviewed-on: https://gerrit.libreoffice.org/77258 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-26weld ScPivotFilterDlgCaolán McNamara
Change-Id: I0a2ffa6fd02dcf82d55f961ba229112b456eda8e Reviewed-on: https://gerrit.libreoffice.org/69733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-25Simplify containers iterations in sc/source/ui/{view,xmlsource}Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I5604325cd25c099d3b5580956417620f298faa1e Reviewed-on: https://gerrit.libreoffice.org/65572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-07use more std::unique_ptr in ScCheckListMenuWindowNoel Grandin
Change-Id: Ia63d663204af570fb0e7faa46e4925c2787fc59b Reviewed-on: https://gerrit.libreoffice.org/61433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-17cppcheck: variableScope in scJochen Nitschke
Change-Id: I9fe9c042a4990c6399765819f6b8e80c17dba9d2 Reviewed-on: https://gerrit.libreoffice.org/60551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>