Age	Commit message (Collapse)	Author
2024-04-22	pivot: handle whole row/column selections, added many tests	Tomaž Vajngerl
	This adds support for selecting whole rows/columns, where the field reference is set but no indices are present. This means that all the data cells apply (selecting the whole thing), which are not subtotals. For this the support for multiple matching and maybe matching results was added (previously max 1 would apply), which would apply the pattern to multiple cells in the pivot table. In addition handle labels of columns with multiple data fields correctly. This also adds many more test scenarios, which all cover the changes mentioned above. Change-Id: Ibcdaa933c69991eaa55a2ad18b9f9a838308d478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166384 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-21	crashtesting: crash seen on import of forum-mso-en4-602306.xlsx	Caolán McNamara
	Change-Id: Ib8bd453483c72382330b4c960cdbe735bdb97eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-18	crashtesting: crash on export of forum-mso-en4-470772.xlsx to xlsx	Caolán McNamara
	similar fix as: commit 1d5630c5deeec5dca724c29ec8c886bfa71a2099 Date: Tue Apr 16 15:21:49 2024 +0900 pivot: add checks that prevent reading out of vector bounds Change-Id: I190da7586cff9c7e8dd4011ad61e68abba6ecd53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-16	pivot: add checks that prevent reading out of vector bounds	Tomaž Vajngerl
	MSO likes to keep formats in the document even when the pivot table has been changed, so there might be references that contain indices values that are pointing out of bounds for the current pivot table result data. To prevent crashing the checks are added to prevent using an index that is out of vector bounds. Change-Id: I3824c787659d4e3817a5eb64fe2c8761ef00b610 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166138 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-16	pivot: suppprt multiple cell format reference indices	Tomaž Vajngerl
	This adds support for multiple cell format reference indices, so the same cell format is applied to multiple cells (defined by indices) so that each doesn't need to be defined by its own reference (as they are all the same anyway and only differ by single index). The solution is to create multiple format outputs for one format entry - each for a selection index, but have other data still the same. This is a bit tricky as previously it was one format output for one format entry, which is not the case anymore. Change-Id: I074ac03e7d81e26562a6a6cc395b11cfed16766d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166131 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-15	pivot: improve format matching, add empty cell checking to tests	Tomaž Vajngerl
	The patch improves the pivot table cell format matching with the output data, so we check if there is a complete match or a partial match. A partial match is when we found one match for a field, but other fields are not set, and if this partial match is found in exactly 1 line of output data, then we treat it as a complete match. This also refactors the code so there is code no duplication for column and row matching code - they work in the same way, just in a different orientation. This also adds checking of empty cells to the tests, so we can make sure there is no other cell in the pivot table that got the pivot table cell format applied to. A new test case was also added to the test class. Change-Id: I102ec8e33bc7a3f26bc898568ee0e33abe08bd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166086 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-12	sc: fix -Werror,-Wunused-but-set-variable	Miklos Vajna
	Pointed out by clang-15: sc/source/core/data/PivotTableFormatOutput.cxx:256:12: error: variable 'nEntryIndex' set but not used [-Werror,-Wunused-but-set-variable] size_t nEntryIndex = 0; ^ Change-Id: I3abf7fe6d4ed330cd713472ce4102eeef6aea4dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166022 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-12	pivot: PivotTableFormatOutput to resolve and set PT cell format	Tomaž Vajngerl
	This adds the PivotTableFormatOutput, which main responsibility is to resolve the reference for which the pivot table format is set to. It first prepares the format data into such a structure that it is easier to match with the pivot table fields and data. Then the pivot table data is filled during the output, where we remember the cell positions of the pivot table output. The last step is to resolve the pivot table format references with the filled data, where the cell formats are applied to the output. PivotTableFormatsImportExport was added to test the correctnes of the functionality. Change-Id: Ie67ea15b3aa74739f15937800d03d256b8f68277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165992 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>